Skip to contentSkip to conversation

net: macb: Use netif_napi_add_tx() instead of netif_napi_add() for TX NAPI

PATCH Applied Kevin Hao 2 participants 2 messages Apr 3 – Apr 7

Subsystems (3)
Networking Network drivers Atmel MACB Ethernet driver
lore
Share & tools
lore

Kevin Hao

author
#0 lore raw

PATCH 1/1 net: macb: Use netif_napi_add_tx() instead of netif_napi_add() for TX NAPI

The TX NAPI should be registered via netif_napi_add_tx() to avoid unnecessarily polluting the napi_hash table.

Signed-off-by Kevin Hao <[email protected]>
---
 drivers/net/ethernet/cadence/macb_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/cadence/macb_main.c +1 -1
index 7f061d7c95af9aec37f73d3529a8cb276b263452..6a386e5632ac48a82414c370d58ae99f40fc3727 100644
@@ -4770,7 +4770,7 @@ static int macb_init_dflt(struct platform_device *pdev)
 		queue->bp = bp;
 		spin_lock_init(&queue->tx_ptr_lock);
 		netif_napi_add(dev, &queue->napi_rx, macb_rx_poll);
-		netif_napi_add(dev, &queue->napi_tx, macb_tx_poll);
+		netif_napi_add_tx(dev, &queue->napi_tx, macb_tx_poll);
 		if (hw_q) {
 			queue->ISR  = GEM_ISR(hw_q - 1);
 			queue->IER  = GEM_IER(hw_q - 1);

---
base-commit: cc13002a9f984d37906e9476f3e532a8cdd126f5
change-id: 20260403-macb-napi-tx-7d5a8375d5d3

Best regards,

Signature · 1 line
Kevin Hao <[email protected]>
CI Applied
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Fri, 03 Apr 2026 22:23:39 +0800 you wrote:

The TX NAPI should be registered via netif_napi_add_tx() to avoid unnecessarily polluting the napi_hash table.

Signed-off-by Kevin Hao <[email protected]>
---
 drivers/net/ethernet/cadence/macb_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[...]

Here is the summary with links:
- [net-next] net: macb: Use netif_napi_add_tx() instead of netif_napi_add() for TX NAPI

    https://git.kernel.org/netdev/net-next/c/c321b5676d0c

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html