Skip to contentSkip to conversation

arm64: dts: qcom: sc8280xp: Add ADSP FastRPC node

PATCH Applied Pengyu Luo 4 participants 5 messages Apr 3 – May 7

Subsystems (3)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support
lore
Share & tools
lore

Pengyu Luo

author
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sc8280xp: Add ADSP FastRPC node

Add the FastRPC node to enable offloading compute tasks to the ADSP via the FastRPC framework.

Signed-off-by Pengyu Luo <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 27 ++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/qcom/sc8280xp.dtsi +27 -0
index 761f229e8f47..ee02acd18856 100644
@@ -2966,6 +2966,33 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
 				label = "lpass";
 				qcom,remote-pid = <2>;
 
+				fastrpc {
+					compatible = "qcom,fastrpc";
+					qcom,glink-channels = "fastrpcglink-apps-dsp";
+					label = "adsp";
+					qcom,non-secure-domain;
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					compute-cb@3 {
+						compatible = "qcom,fastrpc-compute-cb";
+						reg = <3>;
+						iommus = <&apps_smmu 0x0c03 0x0>;
+					};
+
+					compute-cb@4 {
+						compatible = "qcom,fastrpc-compute-cb";
+						reg = <4>;
+						iommus = <&apps_smmu 0x0c04 0x0>;
+					};
+
+					compute-cb@5 {
+						compatible = "qcom,fastrpc-compute-cb";
+						reg = <5>;
+						iommus = <&apps_smmu 0x0c05 0x0>;
+					};
+				};
+
 				gpr {
 					compatible = "qcom,gpr";
 					qcom,glink-channels = "adsp_apps";
Signature · 1 line
2.53.0
#2 lore raw
In reply to Pengyu Luo
Quoted 18 lines · Pengyu Luo

Add the FastRPC node to enable offloading compute tasks to the ADSP via the FastRPC framework.

Signed-off-by Pengyu Luo <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 27 ++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/qcom/sc8280xp.dtsi +2 -0
index 761f229e8f47..ee02acd18856 100644
@@ -2966,6 +2966,33 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
 				label = "lpass";
 				qcom,remote-pid = <2>;
 
+				fastrpc {
+					compatible = "qcom,fastrpc";

arch/arm64/boot/dts/qcom/sc8280xp.dtsi IPCC_MPROC_SIGNAL_GLINK_QMP · line 2980

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc8280xp.dtsi +10 -0
+					qcom,glink-channels = "fastrpcglink-apps-dsp";
+					label = "adsp";
+					qcom,non-secure-domain;
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					compute-cb@3 {
+						compatible = "qcom,fastrpc-compute-cb";
+						reg = <3>;
+						iommus = <&apps_smmu 0x0c03 0x0>;

These are SIDs destined for the CDSP.. (how) have you tested this patch?

+Srini, Ekansh I can't quite decode which SIDs are "allowed" for FastRPC on Hamoa's ADSP.. could you please help here?

Konrad

Reviewed-by
#3 lore raw
Quoted 33 lines · Konrad Dybcio
Quoted 18 lines · Pengyu Luo

Add the FastRPC node to enable offloading compute tasks to the ADSP via the FastRPC framework.

Signed-off-by Pengyu Luo <[email protected]>
---
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 27 ++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/qcom/sc8280xp.dtsi +2 -0
index 761f229e8f47..ee02acd18856 100644
@@ -2966,6 +2966,33 @@ IPCC_MPROC_SIGNAL_GLINK_QMP
 				label = "lpass";
 				qcom,remote-pid = <2>;
 
+				fastrpc {
+					compatible = "qcom,fastrpc";

arch/arm64/boot/dts/qcom/sc8280xp.dtsi IPCC_MPROC_SIGNAL_GLINK_QMP · line 2980

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc8280xp.dtsi +10 -0
+					qcom,glink-channels = "fastrpcglink-apps-dsp";
+					label = "adsp";
+					qcom,non-secure-domain;
+					#address-cells = <1>;
+					#size-cells = <0>;
+
+					compute-cb@3 {
+						compatible = "qcom,fastrpc-compute-cb";
+						reg = <3>;
+						iommus = <&apps_smmu 0x0c03 0x0>;

These are SIDs destined for the CDSP.. (how) have you tested this patch?

Quoted 2 lines

+Srini, Ekansh I can't quite decode which SIDs are "allowed" for FastRPC on Hamoa's ADSP.. could you please help here?

As I hit enter, I noticed this is indeed not hamoa and these numbers were just coincidental..

The patch is alright

Reviewed-by Konrad Dybcio <[email protected]>

Konrad

maintainer Applied
#4 lore raw
In reply to Pengyu Luo
Quoted 4 lines · Pengyu Luo

Add the FastRPC node to enable offloading compute tasks to the ADSP via the FastRPC framework.

Applied, thanks!

[1/1] arm64: dts: qcom: sc8280xp: Add ADSP FastRPC node

      commit: 1825ac5e2ad27ad72d1a550f6e19f8cc1ae90afe

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>