alpha: Select ARCH_SUPPORTS_ATOMIC_RMW
Matt Turner
maintainerPATCH 1/1 alpha: Select ARCH_SUPPORTS_ATOMIC_RMW
Alpha has native LL/SC instructions (LDL_L/STL_C, LDQ_L/STQ_C) that provide atomic read-modify-write capability, and already selects ARCH_HAVE_NMI_SAFE_CMPXCHG.
Selecting ARCH_SUPPORTS_ATOMIC_RMW enables MUTEX_SPIN_ON_OWNER and RWSEM_SPIN_ON_OWNER on SMP, allowing optimistic spinning on contended locks rather than immediately sleeping.
--- arch/alpha/Kconfig | 1 + 1 file changed, 1 insertion(+)
arch/alpha/Kconfig +1 -0
@@ -10,6 +10,7 @@ config ALPHA select ARCH_MODULE_NEEDS_WEAK_PER_CPU if SMP select ARCH_NO_PREEMPT select ARCH_NO_SG_CHAIN + select ARCH_SUPPORTS_ATOMIC_RMW select ARCH_SUPPORTS_PAGE_TABLE_CHECK select ARCH_USE_CMPXCHG_LOCKREF select FORCE_PCI
Signature · 1 line
2.52.0
Magnus Lindholm
maintainerQuoted 20 lines · Matt Turner
Alpha has native LL/SC instructions (LDL_L/STL_C, LDQ_L/STQ_C) that provide atomic read-modify-write capability, and already selects
ARCH_HAVE_NMI_SAFE_CMPXCHG.Selecting
ARCH_SUPPORTS_ATOMIC_RMWenablesMUTEX_SPIN_ON_OWNERandRWSEM_SPIN_ON_OWNERon SMP, allowing optimistic spinning on contended locks rather than immediately sleeping.Assisted-by Claude:claude-opus-4-6Signed-off-by Matt Turner <[email protected]>--- arch/alpha/Kconfig | 1 + 1 file changed, 1 insertion(+)arch/alpha/Kconfig +0
-0
arch/alpha/Kconfig config ALPHA
Quoted 8 lines
arch/alpha/Kconfig +1
-1@@ -10,6 +10,7 @@ config ALPHA select ARCH_MODULE_NEEDS_WEAK_PER_CPU if SMP select ARCH_NO_PREEMPT select ARCH_NO_SG_CHAIN + select ARCH_SUPPORTS_ATOMIC_RMW select ARCH_SUPPORTS_PAGE_TABLE_CHECK select ARCH_USE_CMPXCHG_LOCKREF select FORCE_PCI --
Hi Matt,
Support for pre-BWX CPUs has been removed from the kernel for quite some time, so all supported Alpha systems now have full byte/word instruction support along with the existing LL/SC primitives (LDL_L/STL_C, LDQ_L/STQ_C). Given that, selecting ARCH_SUPPORTS_ATOMIC_RMW at the architecture level
accurately reflects the capabilities of the CPUs we actually support today.
That said, there have also been efforts (by Maciej Rozycki) to reintroduce support for non-BWX Alpha systems. If that happens, we may need to revisit the rationale here, since the "all supported systems have BWX" argument would no longer apply as stated?
The patch itself fails to apply cleanly on top of v7.0-rc1, I guess there are entries in your arch/alpha/Kconfig that do not match what is in v7.0-rc1?
Regards
Magnus