Skip to contentSkip to conversation

HID: apple: Add Niz keyboard dongle to non-apple keyboards list

PATCH In review utzcoz 2 participants 3 messages Apr 3 – Apr 13 HID

lore
Share & tools
lore

utzcoz

author
#0 lore raw

PATCH 1/1 HID: apple: Add Niz keyboard dongle to non-apple keyboards list

Niz X99 uses a 2.4GHz wireless dongle (Milsky LL Dongle) that reports Apple's vendor and product IDs (05ac:0220), causing hid-apple to apply Apple function key translation. Since the dongle has no Apple Fn key, F1-F12 become unreachable when fnmode defaults to media-first behavior.

Add the Milsky LL Dongle to the non_apple_keyboards list so that fnmode=3 (auto) correctly resolves to fnmode=2, making F1-F12 work as standard function keys.

---
 drivers/hid/hid-apple.c | 1 +
 1 file changed, 1 insertion(+)
drivers/hid/hid-apple.c +1 -0
index fc5897a6bb53..c29834cfa468 100644
@@ -368,6 +368,7 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
 	{ "TH87" },			/* EPOMAKER TH87 BT mode */
 	{ "HFD Epomaker TH87" },	/* EPOMAKER TH87 USB mode */
 	{ "2.4G Wireless Receiver" },	/* EPOMAKER TH87 dongle */
+	{ "Milsky LL Dongle" },		/* Niz keyboard dongle */
 };
 
 static bool apple_is_non_apple_keyboard(struct hid_device *hdev)
Signature · 1 line
2.51.0
maintainer
#1 lore raw
Quoted 11 lines · utzcoz

Niz X99 uses a 2.4GHz wireless dongle (Milsky LL Dongle) that reports Apple's vendor and product IDs (05ac:0220), causing hid-apple to apply Apple function key translation. Since the dongle has no Apple Fn key, F1-F12 become unreachable when fnmode defaults to media-first behavior.

Add the Milsky LL Dongle to the non_apple_keyboards list so that fnmode=3 (auto) correctly resolves to fnmode=2, making F1-F12 work as standard function keys.

Thanks a lot for the patches.

I know that the kernel documentation is now a little bit more liberal about not having to use real names, but "well established identities" being fine, but stil ... would you mind submitting this under some more comprehensible authorship? (anonymous submissions are still not allowed, BTW).

utzcoz doesn't really sound too well established identity to me, unfortunately ... if it is, I'd be happy to stay corrected.

Thanks again,

Signature · 2 lines
Jiri Kosina
SUSE Labs
author
#2 lore raw

Hi Jiri,

Thanks for your review.

Sorry for sending this email again with plain text mode as the previous one has the html content part.

Quoted 1 line

doesn't really sound too well established identity to me,

Yeah. It's my id for code contribution, not my real name, and you can find me as a real person at https://github.com/utzcoz.

Quoted 1 line

know that the kernel documentation is now a little bit more liberal about not having to use real names

Sorry about it, and it's my contribution to Linux Kernel to resolve my personal issue, and I didn't notice this rule.

Quoted 1 line

but "well established identities" being fine

I also use this id to contribute code to many large open-source projects like AOSP, Chromium(although small contributions), Could you think of it as the "well established identities"?

Thanks for your reviewing and reminder again.