Skip to contentSkip to conversation

net/tap: avoid using netlink socket if closed

PATCH In review Stephen Hemminger 2 participants 2 messages Apr 3 – Apr 5 Network drivers

lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 net/tap: avoid using netlink socket if closed

Coverity flagged that nlsk_fd could be negative when passed to tap_nl_set_flags() during device close.

Coverity issue: 502576

Fixes b5d76639551e ("net/tap: replace ioctl with Netlink")
Cc [email protected]
Signed-off-by Stephen Hemminger <[email protected]>
---
 drivers/net/tap/rte_eth_tap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/tap/rte_eth_tap.c +1 -1
index a5d460a0b3..ba9aef74c0 100644
@@ -1124,7 +1124,7 @@ tap_dev_close(struct rte_eth_dev *dev)
 		}
 	}
 
-	if (internals->remote_if_index) {
+	if (internals->remote_if_index != 0 && internals->nlsk_fd != -1) {
 		/* Restore initial remote state */
 		int ret = tap_nl_set_flags(internals->nlsk_fd, internals->remote_if_index,
 					   internals->remote_initial_flags, 1);
Signature · 1 line
2.53.0