Skip to contentSkip to conversation

selftests: net: fix checkpatch warnings in iou-zcrx.c

PATCH In review Juanlu Herrero 2 participants 2 messages Apr 3

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: net: fix checkpatch warnings in iou-zcrx.c

---
 tools/testing/selftests/drivers/net/hw/iou-zcrx.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
tools/testing/selftests/drivers/net/hw/iou-zcrx.c +2 -3
index 240d13dbc54e..df44b0eb46cc 100644
@@ -266,7 +266,7 @@ static void process_accept(struct io_uring *ring, struct io_uring_cqe *cqe)
 
 static void process_recvzc(struct io_uring *ring, struct io_uring_cqe *cqe)
 {
-	unsigned rq_mask = rq_ring.ring_entries - 1;
+	unsigned int rq_mask = rq_ring.ring_entries - 1;
 	struct io_uring_zcrx_cqe *rcqe;
 	struct io_uring_zcrx_rqe *rqe;
 	struct io_uring_sqe *sqe;
@@ -406,8 +406,7 @@ static void run_client(void)
 
 static void usage(const char *filepath)
 {
-	error(1, 0, "Usage: %s (-4|-6) (-s|-c) -h<server_ip> -p<port> "
-		    "-l<payload_size> -i<ifname> -q<rxq_id>", filepath);
+	error(1, 0, "Usage: %s (-4|-6) (-s|-c) -h<server_ip> -p<port> -l<payload_size> -i<ifname> -q<rxq_id>", filepath);
 }
 
 static void parse_opts(int argc, char **argv)
Signature · 1 line
2.31.1
maintainer
#1 lore raw
Quoted 1 line · On Fri, 3 Apr 2026 14:57:53 -0500 Juanlu Herrero wrote:

Subject: [PATCH] selftests: net: fix checkpatch warnings in iou-zcrx.c

Quoting documentation:

Clean-up patches
~~~~~~~~~~~~~~~~

Netdev discourages patches which perform simple clean-ups, which are not in the context of other work. For example:

* Addressing ``checkpatch.pl``, and other trivial coding style warnings
* Addressing :ref:Local variable ordering<rcs> issues
* Conversions to device-managed APIs (``devm_`` helpers)

This is because it is felt that the churn that such changes produce comes at a greater cost than the value of such clean-ups.

Conversely, spelling and grammar fixes are not discouraged.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches

Signature · 1 line
pw-bot: reject