HID: winwing: add support for URSA MINOR combat joysticks
PATCH 1/1 HID: winwing: add support for URSA MINOR combat joysticks
Add device IDs for the Winwing URSA MINOR Combat Joystick L (0xbc29) and R (0xbc2a). These joysticks declare 128 buttons in their HID report descriptor, causing the generic HID driver to reject buttons above KEY_MAX (767) with "Invalid code" errors.
The URSA MINOR joysticks use buttons in the 33-64 range for grip controls including the index trigger, so map_more_buttons is set to 1 to enable the extended KEY_MACRO mapping.
Tested with both left and right URSA MINOR joysticks on kernel 6.19.
--- hid-winwing.c | 2 ++ 1 file changed, 2 insertions(+)
hid-winwing.c +2 -0
@@ -250,6 +250,8 @@ static const struct hid_device_id winwing_devices[] = { { HID_USB_DEVICE(0x4098, 0xbd64), .driver_data = 1 }, /* TGRIP-15EX */ { HID_USB_DEVICE(0x4098, 0xbe68), .driver_data = 0 }, /* TGRIP-16EX */ { HID_USB_DEVICE(0x4098, 0xbe62), .driver_data = 0 }, /* TGRIP-18 */ + { HID_USB_DEVICE(0x4098, 0xbc29), .driver_data = 1 }, /* URSA MINOR L */ + { HID_USB_DEVICE(0x4098, 0xbc2a), .driver_data = 1 }, /* URSA MINOR R */ {} };
Signature · 1 line
2.43.0
Jiri Kosina
maintainerhid-winwing.c
Quoted 20 lines · René Onier
Add device IDs for the Winwing URSA MINOR Combat Joystick L (
0xbc29) and R (0xbc2a). These joysticks declare 128 buttons in their HID report descriptor, causing the generic HID driver to reject buttons aboveKEY_MAX(767) with "Invalid code" errors.The URSA MINOR joysticks use buttons in the 33-64 range for grip controls including the index trigger, so
map_more_buttonsis set to 1 to enable the extendedKEY_MACROmapping.Tested with both left and right URSA MINOR joysticks on kernel 6.19.
Signed-off-by René Onier <[email protected]>--- hid-winwing.c | 2 ++ 1 file changed, 2 insertions(+)hid-winwing.c +0
-0
Thanks for the patch!
You seem to have generated it however without a full path, so it can't be applied using standard patch -p1 way ... could you please fix that up and resend?
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs