Skip to contentSkip to conversation

dt-bindings: display: rockchip: dw-hdmi: Allow resets for Rockchip HDMI

PATCH In review Fabio Estevam 2 participants 2 messages Apr 4 – Apr 15

Subsystems (5)
Device tree bindings DRM drivers DRM misc Arm Rockchip +1 more subsystems
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 dt-bindings: display: rockchip: dw-hdmi: Allow resets for Rockchip HDMI

The Rockchip DW HDMI binding sets unevaluatedProperties: false while also inheriting from synopsys,dw-hdmi.yaml via allOf.

The Synopsys binding defines the optional properties resets and reset-names, but due to dt-schema rules these are not considered allowed once unevaluatedProperties: false is set in the Rockchip schema unless they are re-declared locally.

This went unnoticed because most Rockchip SoCs do not wire a reset line to the HDMI controller in their DTS. The rk3228, however, does use a reset, which causes dtbs_check to emit:

Unevaluated properties are not allowed ('resets', 'reset-names')

Re-declare these properties in the Rockchip schema so they are accepted when present, matching the capabilities of the underlying Synopsys IP and fixing the dtbs_check warning for rk3228.

Signed-off-by Fabio Estevam <[email protected]>
---
 .../bindings/display/rockchip/rockchip,dw-hdmi.yaml         | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml +6 -0
index 29716764413a..59fb084bb4fb 100644
@@ -113,6 +113,12 @@ properties:
       - port@0
       - port@1
 
+  resets:
+    maxItems: 1
+
+  reset-names:
+    const: hdmi
+
   rockchip,grf:
     $ref: /schemas/types.yaml#/definitions/phandle
     description:
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 7 lines · Fabio Estevam

The Rockchip DW HDMI binding sets unevaluatedProperties: false while also inheriting from synopsys,dw-hdmi.yaml via allOf.

The Synopsys binding defines the optional properties resets and reset-names, but due to dt-schema rules these are not considered allowed once unevaluatedProperties: false is set in the Rockchip schema unless they are re-declared locally.

That's not how unevaluatedProperties works. There is no resets nor reset-names in synopsys,dw-hdmi.yaml.

Quoted 36 lines

This went unnoticed because most Rockchip SoCs do not wire a reset line to the HDMI controller in their DTS. The rk3228, however, does use a reset, which causes dtbs_check to emit:

Unevaluated properties are not allowed ('resets', 'reset-names')

Re-declare these properties in the Rockchip schema so they are accepted when present, matching the capabilities of the underlying Synopsys IP and fixing the dtbs_check warning for rk3228.

Signed-off-by Fabio Estevam <[email protected]>
---
 .../bindings/display/rockchip/rockchip,dw-hdmi.yaml         | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml +6 -0
index 29716764413a..59fb084bb4fb 100644
@@ -113,6 +113,12 @@ properties:
       - port@0
       - port@1
 
+  resets:
+    maxItems: 1
+
+  reset-names:
+    const: hdmi
+
   rockchip,grf:
     $ref: /schemas/types.yaml#/definitions/phandle
     description:
Signature · 1 line
2.43.0