staging: rtl8723bs: fix integer underflow in TKIP MIC verification
Subsystems (2)
PATCH 1/1 staging: rtl8723bs: fix integer underflow in TKIP MIC verification
In recvframe_chkmic(), datalen is computed as:
datalen = len - hdrlen - iv_len - icv_len - 8;
All operands are unsigned, so if the frame is shorter than the sum of header, IV, ICV, and MIC lengths, the subtraction wraps to a very large value. This corrupted datalen is then passed to rtw_seccalctkipmic() and used as a pointer offset, leading to out-of-bounds reads on kernel heap memory.
Add a minimum frame length check before the subtraction to prevent the unsigned integer underflow.
--- drivers/staging/rtl8723bs/core/rtw_recv.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/staging/rtl8723bs/core/rtw_recv.c +7 -0
@@ -390,6 +390,13 @@ static signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *p mickey = &stainfo->dot11tkiprxmickey.skey[0 ]; } +/* Ensure the frame is large enough for TKIP MIC verification */ +if (precvframe->u.hdr.len <= prxattrib->hdrlen + + prxattrib->iv_len + prxattrib->icv_len +8 ) { + res = _FAIL; + goto exit; + } + datalen = precvframe->u.hdr.len-prxattrib->hdrlen-prxattrib->iv_len-prxattrib->icv_len-8 ;/* icv_len included the mic code */ pframe = precvframe->u.hdr.rx_data; payload = pframe+prxattrib->hdrlen+prxattrib->iv_len;
Signature · 1 line
2.43.0
Quoted 10 lines · Delene Tchio Romuald
In
recvframe_chkmic(), datalen is computed as:datalen = len - hdrlen - iv_len - icv_len - 8;All operands are unsigned, so if the frame is shorter than the sum of header, IV, ICV, and MIC lengths, the subtraction wraps to a very large value. This corrupted datalen is then passed to
rtw_seccalctkipmic()and used as a pointer offset, leading to out-of-bounds reads on kernel heap memory.
Quoted 6 lines
Add a minimum frame length check before the subtraction to prevent the unsigned integer underflow.
Signed-off-by Delene Tchio Romuald <[email protected]>---
Doesn't apply to staging-next.
Thanks,
ET
PATCH v2 1/1 staging: rtl8723bs: fix integer underflow in TKIP MIC verification
In reply to Delene Tchio RomualdIn recvframe_chkmic(), datalen is computed as:
datalen = len - hdrlen - iv_len - icv_len - 8;
All operands are unsigned, so if the frame is shorter than the sum of header, IV, ICV, and MIC lengths, the subtraction wraps to a very large value. This corrupted datalen is then passed to rtw_seccalctkipmic() and used as a pointer offset, leading to out-of-bounds reads on kernel heap memory.
Add a minimum frame length check before the subtraction to prevent the unsigned integer underflow.
--- drivers/staging/rtl8723bs/core/rtw_recv.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/staging/rtl8723bs/core/rtw_recv.c +7 -0
@@ -390,6 +390,13 @@ static signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *p mickey = &stainfo->dot11tkiprxmickey.skey[0 ]; } +/* Ensure the frame is large enough for TKIP MIC verification */ +if (precvframe->u.hdr.len <= prxattrib->hdrlen + + prxattrib->iv_len + prxattrib->icv_len +8 ) { + res = _FAIL; + goto exit; + } + datalen = precvframe->u.hdr.len - prxattrib->hdrlen - prxattrib->iv_len - prxattrib->icv_len -8 ;/* icv_len included the mic code */ pframe = precvframe->u.hdr.rx_data; payload = pframe + prxattrib->hdrlen + prxattrib->iv_len;
Signature · 1 line
2.43.0
Greg KH
maintainerQuoted 41 lines · Delene Tchio Romuald
In
recvframe_chkmic(), datalen is computed as:datalen = len - hdrlen - iv_len - icv_len - 8;All operands are unsigned, so if the frame is shorter than the sum of header, IV, ICV, and MIC lengths, the subtraction wraps to a very large value. This corrupted datalen is then passed to
rtw_seccalctkipmic()and used as a pointer offset, leading to out-of-bounds reads on kernel heap memory.Add a minimum frame length check before the subtraction to prevent the unsigned integer underflow.
Signed-off-by Delene Tchio Romuald <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_recv.c | 7 +++++++ 1 file changed, 7 insertions(+)drivers/staging/rtl8723bs/core/rtw_recv.c +7
-0@@ -390,6 +390,13 @@ static signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *p mickey = &stainfo->dot11tkiprxmickey.skey[0 ]; } +/* Ensure the frame is large enough for TKIP MIC verification */ +if (precvframe->u.hdr.len <= prxattrib->hdrlen + + prxattrib->iv_len + prxattrib->icv_len +8 ) { + res = _FAIL; + goto exit; + } + datalen = precvframe->u.hdr.len - prxattrib->hdrlen - prxattrib->iv_len - prxattrib->icv_len -8 ;/* icv_len included the mic code */ pframe = precvframe->u.hdr.rx_data; payload = pframe + prxattrib->hdrlen + prxattrib->iv_len;Signature · 1 line
2.43.0
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot