Skip to contentSkip to conversation

package/freeradius-server: remove redundant pcre dependency

PATCH Applied Bernd Kuhls 2 participants 3 messages Apr 5 – Apr 14

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/freeradius-server: remove redundant pcre dependency

Buildroot commit 736c4c1655d93652a9a7e79235bbe726b3d46176 added the package with two identical code blocks dealing with the dependency to pcre:

https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L161
https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L218

Remove one of these code blocks.

---
 package/freeradius-server/freeradius-server.mk | 7 -------
 1 file changed, 7 deletions(-)
package/freeradius-server/freeradius-server.mk +0 -7
index 946750f1a5..9b5b3d13ea 100644
@@ -215,13 +215,6 @@ FREERADIUS_SERVER_CONF_OPTS += \
 	--without-rlm_eap_pwd
 endif
 
-ifeq ($(BR2_PACKAGE_PCRE),y)
-FREERADIUS_SERVER_CONF_OPTS += --with-pcre
-FREERADIUS_SERVER_DEPENDENCIES += pcre
-else
-FREERADIUS_SERVER_CONF_OPTS += --without-pcre
-endif
-
 ifeq ($(BR2_PACKAGE_RUBY),y)
 FREERADIUS_SERVER_CONF_OPTS += --with-rlm_ruby
 FREERADIUS_SERVER_DEPENDENCIES += ruby
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 10 lines · Bernd Kuhls

Buildroot commit 736c4c1655d93652a9a7e79235bbe726b3d46176 added the package with two identical code blocks dealing with the dependency to pcre:

https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L161
https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L218

Remove one of these code blocks.

Applied to master, thanks.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Bernd Kuhls

In reply of:

Quoted 10 lines

Buildroot commit 736c4c1655d93652a9a7e79235bbe726b3d46176 added the package with two identical code blocks dealing with the dependency to pcre:

https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L161
https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/freeradius-server/freeradius-server.mk#L218

Remove one of these code blocks.

Applied to 2025.02.x & 2026.02.x. Thanks

Quoted 29 lines
---
 package/freeradius-server/freeradius-server.mk | 7 -------
 1 file changed, 7 deletions(-)
package/freeradius-server/freeradius-server.mk +0 -7
index 946750f1a5..9b5b3d13ea 100644
@@ -215,13 +215,6 @@ FREERADIUS_SERVER_CONF_OPTS += \
 	--without-rlm_eap_pwd
 endif
 
-ifeq ($(BR2_PACKAGE_PCRE),y)
-FREERADIUS_SERVER_CONF_OPTS += --with-pcre
-FREERADIUS_SERVER_DEPENDENCIES += pcre
-else
-FREERADIUS_SERVER_CONF_OPTS += --without-pcre
-endif
-
 ifeq ($(BR2_PACKAGE_RUBY),y)
 FREERADIUS_SERVER_CONF_OPTS += --with-rlm_ruby
 FREERADIUS_SERVER_DEPENDENCIES += ruby
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot