Skip to contentSkip to conversation

dm vdo: use get_random_u32() where appropriate

PATCH In review David Carlier 2 participants 2 messages Apr 5 – Apr 6

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dm vdo: use get_random_u32() where appropriate

Use the typed random integer helpers instead of get_random_bytes() when filling a single integer variable. The helpers return the value directly, require no pointer or size argument, and better express intent.

---
 drivers/md/dm-vdo/indexer/index-layout.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/dm-vdo/indexer/index-layout.c +1 -1
index 61edf2b72427..8707930c9910 100644
@@ -256,7 +256,7 @@ static void create_unique_nonce_data(u8 *buffer)
 	u32 rand;
 	size_t offset = 0;
 
-	get_random_bytes(&rand, sizeof(u32));
+	rand = get_random_u32();
 	memcpy(buffer + offset, &now, sizeof(now));
 	offset += sizeof(now);
 	memcpy(buffer + offset, &rand, sizeof(rand));
Signature · 1 line
2.53.0
maintainer Reviewed-by on v3 1/1
#1 lore raw
Quoted 6 lines · David Carlier

Use the typed random integer helpers instead of get_random_bytes() when filling a single integer variable. The helpers return the value directly, require no pointer or size argument, and better express intent.

Quoted 17 lines
---
  drivers/md/dm-vdo/indexer/index-layout.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/md/dm-vdo/indexer/index-layout.c +1 -1
index 61edf2b72427..8707930c9910 100644
@@ -256,7 +256,7 @@ static void create_unique_nonce_data(u8 *buffer)
  	u32 rand;
  	size_t offset = 0;
 
-	get_random_bytes(&rand, sizeof(u32));
+	rand = get_random_u32();
  	memcpy(buffer + offset, &now, sizeof(now));
  	offset += sizeof(now);
  	memcpy(buffer + offset, &rand, sizeof(rand));