virtio-fs: avoid double-free on failed queue setup
Subsystems (4)
PATCH 1/1 virtio-fs: avoid double-free on failed queue setup
virtio_fs_setup_vqs() allocates fs->vqs and fs->mq_map before calling virtio_find_vqs(). If virtio_find_vqs() fails, the error path frees both pointers and returns an error to virtio_fs_probe().
virtio_fs_probe() then drops the last kobject reference, and virtio_fs_ktype_release() frees fs->vqs and fs->mq_map again. This leaves dangling pointers in struct virtio_fs and can trigger a double-free during probe failure cleanup.
Set fs->vqs and fs->mq_map to NULL immediately after kfree() in the virtio_fs_setup_vqs() error path so that the later kobject release sees an uninitialized state and kfree(NULL) becomes harmless.
---
This can be reproduced when a broken virtio-fs device advertises more request queues than the transport actually provides. In that case virtio_find_vqs() fails while setting up the extra queue, and the probe path reaches the double-free cleanup sequence.
fs/fuse/virtio_fs.c | 2 ++ 1 file changed, 2 insertions(+)
fs/fuse/virtio_fs.c +2 -0
@@ -988,7 +988,9 @@ static int virtio_fs_setup_vqs(struct virtio_device *vdev,kfree (vqs);if (ret) {kfree (fs->vqs); + fs->vqs =NULL ;kfree (fs->mq_map); + fs->mq_map =NULL ; }return ret; }
base-commit: 3aae9383f42f687221c011d7ee87529398e826b3
Signature · 1 line
2.43.0