Skip to contentSkip to conversation

ext4: fix missing brelse() in ext4_xattr_inode_dec_ref_all()

PATCH Applied [email protected] 4 participants 4 messages Apr 6 – Apr 10

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ext4: fix missing brelse() in ext4_xattr_inode_dec_ref_all()

From: Sohei Koyama <[email protected]>

The commit c8e008b60492 ("ext4: ignore xattrs past end") introduced a refcount leak in when block_csum is false.

ext4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to get iloc.bh, but never releases it with brelse().

Fixes c8e008b60492 ("ext4: ignore xattrs past end")
---
 fs/ext4/xattr.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/ext4/xattr.c +3 -1
index 7bf9ba19a89d..19c72e38fb82 100644
@@ -1165,7 +1165,7 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,
 {
 	struct inode *ea_inode;
 	struct ext4_xattr_entry *entry;
-	struct ext4_iloc iloc;
+	struct ext4_iloc iloc = { .bh = NULL };
 	bool dirty = false;
 	unsigned int ea_ino;
 	int err;
@@ -1260,6 +1260,8 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,
 			ext4_warning_inode(parent,
 					   "handle dirty metadata err=%d", err);
 	}
+
+	brelse(iloc.bh);
 }
 
 /*
Signature · 1 line
2.39.3 (Apple Git-146)
reviewer Reviewed-by on v2 1/1
#1 lore raw
Quoted 5 lines · On 2026/4/6 15:48, [email protected] wrote:

From: Sohei Koyama <[email protected]>

The commit c8e008b60492 ("ext4: ignore xattrs past end") introduced a refcount leak in when block_csum is false.

Quoted 8 lines

ext4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to get iloc.bh, but never releases it with brelse().

Fixes c8e008b60492 ("ext4: ignore xattrs past end")

Looks good, feel free to add:

Quoted 26 lines
---
 fs/ext4/xattr.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/ext4/xattr.c +3 -1
index 7bf9ba19a89d..19c72e38fb82 100644
@@ -1165,7 +1165,7 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,
 {
 	struct inode *ea_inode;
 	struct ext4_xattr_entry *entry;
-	struct ext4_iloc iloc;
+	struct ext4_iloc iloc = { .bh = NULL };
 	bool dirty = false;
 	unsigned int ea_ino;
 	int err;
@@ -1260,6 +1260,8 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,
 			ext4_warning_inode(parent,
 					   "handle dirty metadata err=%d", err);
 	}
+
+	brelse(iloc.bh);
 }
 
 /*
Reviewed-by on v2 1/1
#2 lore raw
In reply to [email protected]
Quoted 5 lines · On 4/6/2026 3:48 PM, [email protected] wrote:

From: Sohei Koyama <[email protected]>

The commit c8e008b60492 ("ext4: ignore xattrs past end") introduced a refcount leak in when block_csum is false.

Quoted 8 lines

ext4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to get iloc.bh, but never releases it with brelse().

Fixes c8e008b60492 ("ext4: ignore xattrs past end")

Looks good to me.

Quoted 26 lines
---
 fs/ext4/xattr.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
fs/ext4/xattr.c +3 -1
index 7bf9ba19a89d..19c72e38fb82 100644
@@ -1165,7 +1165,7 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,
 {
 	struct inode *ea_inode;
 	struct ext4_xattr_entry *entry;
-	struct ext4_iloc iloc;
+	struct ext4_iloc iloc = { .bh = NULL };
 	bool dirty = false;
 	unsigned int ea_ino;
 	int err;
@@ -1260,6 +1260,8 @@ ext4_xattr_inode_dec_ref_all(handle_t *handle, struct inode *parent,
 			ext4_warning_inode(parent,
 					   "handle dirty metadata err=%d", err);
 	}
+
+	brelse(iloc.bh);
 }
 
 /*
maintainer Applied
#3 lore raw
In reply to [email protected]
Quoted 8 lines · On Mon, 06 Apr 2026 16:48:30 +0900, [email protected] wrote:

The commit c8e008b60492 ("ext4: ignore xattrs past end") introduced a refcount leak in when block_csum is false.

ext4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to get iloc.bh, but never releases it with brelse().

[...]

Applied, thanks!

[1/1] ext4: fix missing brelse() in ext4_xattr_inode_dec_ref_all()

      commit: 77d059519382bd66283e6a4e83ee186e87e7708f

Best regards,

Signature · 1 line
Theodore Ts'o <[email protected]>