media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
PATCH 1/1 media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
--- drivers/media/v4l2-core/v4l2-subdev.c | 2 -- 1 file changed, 2 deletions(-)
drivers/media/v4l2-core/v4l2-subdev.c +0 -2
@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,if (WARN_ON (!state))return NULL ; -lockdep_assert_held (state->lock); -if (state->pads) {if (stream)return NULL ;
Signature · 1 line
2.43.0
On Sat, Apr 04, 2026 at 07:42:26PM +0530, Sunny Patel wrote:
Missing commit message. Please readDocumentation/process/submitting-patches.rst
Quoted 17 lines
--- drivers/media/v4l2-core/v4l2-subdev.c | 2 -- 1 file changed, 2 deletions(-)drivers/media/v4l2-core/v4l2-subdev.c +0
-2@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,if (WARN_ON (!state))return NULL ; -lockdep_assert_held (state->lock); -if (state->pads) {if (stream)return NULL ;
Signature · 3 lines
Regards, Laurent Pinchart
PATCH 1/1 media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
The __v4l2_subdev_state_get_interval() function has a duplicate lockdep_assert_held() call. Removed the redundant assertion.
--- drivers/media/v4l2-core/v4l2-subdev.c | 2 -- 1 file changed, 2 deletions(-)
drivers/media/v4l2-core/v4l2-subdev.c +0 -2
@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,if (WARN_ON (!state))return NULL ; -lockdep_assert_held (state->lock); -if (state->pads) {if (stream)return NULL ;
Signature · 1 line
2.43.0
When submitting new versions of a patch (or patch series), please remember to indicate the version in the subject line. The -v option to git-format-patch helps.
Quoted 13 lines · Sunny Patel
The
__v4l2_subdev_state_get_interval()function has a duplicatelockdep_assert_held()call. Removed the redundant assertion.Signed-off-by Sunny Patel <[email protected]>--- drivers/media/v4l2-core/v4l2-subdev.c | 2 -- 1 file changed, 2 deletions(-)drivers/media/v4l2-core/v4l2-subdev.c +0
-0
drivers/media/v4l2-core/v4l2-subdev.c __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state, · line 1847
Quoted 5 lines
drivers/media/v4l2-core/v4l2-subdev.c +0
-2@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,if (WARN_ON (!state))return NULL ; -lockdep_assert_held (state->lock); -
Why do you remove this assertion and not the next one ?
Quoted 3 lines
drivers/media/v4l2-core/v4l2-subdev.c +0
-0if (state->pads) {if (stream)return NULL ;
Signature · 3 lines
Regards, Laurent Pinchart
PATCH v2 1/1 media: v4l2-core: Removed duplicate lockdep assertion
The __v4l2_subdev_state_get_interval() function has a duplicate lockdep_assert_held() call. Removed the redundant assertion.
--- drivers/media/v4l2-core/v4l2-subdev.c | 2 -- 1 file changed, 2 deletions(-)
drivers/media/v4l2-core/v4l2-subdev.c +0 -2
@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,if (WARN_ON (!state))return NULL ; -lockdep_assert_held (state->lock); -if (state->pads) {if (stream)return NULL ;
Signature · 1 line
2.43.0
Re: [PATCH v2] media: v4l2-core: Removed duplicate lockdep assertion
There was a review comment in the previous version of this patch and you didn't take it into account. Please reply to it and explain why.
Quoted 21 lines · Sunny Patel
The
__v4l2_subdev_state_get_interval()function has a duplicatelockdep_assert_held()call. Removed the redundant assertion.Signed-off-by Sunny Patel <[email protected]>--- drivers/media/v4l2-core/v4l2-subdev.c | 2 -- 1 file changed, 2 deletions(-)drivers/media/v4l2-core/v4l2-subdev.c +0
-2@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,if (WARN_ON (!state))return NULL ; -lockdep_assert_held (state->lock); -if (state->pads) {if (stream)return NULL ;
Signature · 3 lines
Regards, Laurent Pinchart
PATCH 1/1 media: v4l2-core: v4l2-subdev: Removed duplicate lockdep assertion
In reply to Laurent PinchartRemoval is only required afte state->pads for stream_configs since state->pads only represents the static array so not required locking for it.
The __v4l2_subdev_state_get_interval() function has a duplicate lockdep_assert_held() call. Removed the redundant assertion.
--- drivers/media/v4l2-core/v4l2-subdev.c | 2 -- 1 file changed, 2 deletions(-)
drivers/media/v4l2-core/v4l2-subdev.c +0 -2
@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,if (WARN_ON (!state))return NULL ; -lockdep_assert_held (state->lock); -if (state->pads) {if (stream)return NULL ;
Signature · 1 line
2.43.0
Hi Sunny,
Thanks for the update.
Please always set the version of the patch if not the first.
Quoted 5 lines · Sunny Patel
Removal is only required afte
state->padsforstream_configssincestate->padsonly represents the static array so not required locking for it.
Extra newline.
Quoted 2 lines
The
__v4l2_subdev_state_get_interval()function has a duplicatelockdep_assert_held()call. Removed the redundant assertion.
Please use imperative when describing what the patch does.
Quoted 3 lines
Signed-off-by Sunny Patel <[email protected]>---
Please describe changes across versions, at least from the previous one.
Quoted 16 lines
drivers/media/v4l2-core/v4l2-subdev.c | 2 -- 1 file changed, 2 deletions(-)drivers/media/v4l2-core/v4l2-subdev.c +0
-2@@ -1843,8 +1843,6 @@ __v4l2_subdev_state_get_interval(struct v4l2_subdev_state *state,if (WARN_ON (!state))return NULL ; -lockdep_assert_held (state->lock); -if (state->pads) {if (stream)return NULL ;
Signature · 3 lines
Kind regards, Sakari Ailus