Skip to contentSkip to conversation

ice: fix VF queue configuration with low MTU values

PATCH In review Jose Ignacio Tornos Martinez 5 participants 5 messages Apr 6 – Apr 16

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ice: fix VF queue configuration with low MTU values

The ice driver's VF queue configuration validation rejects databuffer_size values below 1024 bytes, which prevents VFs from using MTU values below 871 bytes.

The iavf driver calculates databuffer_size based on the MTU using:
databuffer_size = ALIGN(MTU + LIBETH_RX_LL_LEN, 128)

where LIBETH_RX_LL_LEN = 26 (ETH_HLEN + 2*VLAN_HLEN + ETH_FCS_LEN).

For MTU values below 871:
MTU 870: 870 + 26 = 896, aligned to 128 = 896 (< 1024, rejected) MTU 871: 871 + 26 = 897, aligned to 128 = 1024 (>= 1024, accepted)

The 1024-byte minimum seems unnecessarily restrictive, because the hardware supports databuffer_size as low as 128 bytes (the alignment boundary), which should allow MTU values down to the standard minimum of 68 bytes.

I haven't found the reason why the limit was configured in the commit 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message"), so with no more information and since it is working, change the minimum databuffer_size validation from 1024 to 128 bytes to allow standard low MTU values while still preventing invalid configurations.

Fixes 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message")
---
 drivers/net/ethernet/intel/ice/virt/queues.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/virt/queues.c +1 -1
index f73d5a3e83d4..31be2f76181c 100644
@@ -840,7 +840,7 @@ int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg)
 
 			if (qpi->rxq.databuffer_size != 0 &&
 			    (qpi->rxq.databuffer_size > ((16 * 1024) - 128) ||
-			     qpi->rxq.databuffer_size < 1024))
+			     qpi->rxq.databuffer_size < 128))
 				goto error_param;
 
 			ring->rx_buf_len = qpi->rxq.databuffer_size;
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · Jose Ignacio Tornos Martinez

The ice driver's VF queue configuration validation rejects databuffer_size values below 1024 bytes, which prevents VFs from using MTU values below 871 bytes.

The iavf driver calculates databuffer_size based on the MTU using:
databuffer_size = ALIGN(MTU + LIBETH_RX_LL_LEN, 128)

where LIBETH_RX_LL_LEN = 26 (ETH_HLEN + 2*VLAN_HLEN + ETH_FCS_LEN).

For MTU values below 871:
MTU 870: 870 + 26 = 896, aligned to 128 = 896 (< 1024, rejected) MTU 871: 871 + 26 = 897, aligned to 128 = 1024 (>= 1024, accepted)

The 1024-byte minimum seems unnecessarily restrictive, because the hardware supports databuffer_size as low as 128 bytes (the alignment boundary), which should allow MTU values down to the standard minimum of 68 bytes.

Quoted 6 lines

I haven't found the reason why the limit was configured in the commit 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message"), so with no more information and since it is working, change the minimum databuffer_size validation from 1024 to 128 bytes to allow standard low MTU values while still preventing invalid configurations.

I dug through some of our internal history and found that there was no justification on why 1024 was chosen.

I agree with your assessment that the value of 128 makes the most sense as it is the actual hardware minimum. I wonder if we used to always use data buffer sizes of 1024 before the conversion to libeth. Either way, I think it makes sense to allow smaller buffers since the modern iAVF will request them.

Quoted 20 lines
Fixes 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message")
---
 drivers/net/ethernet/intel/ice/virt/queues.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/virt/queues.c +1 -1
index f73d5a3e83d4..31be2f76181c 100644
@@ -840,7 +840,7 @@ int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg)
 
 			if (qpi->rxq.databuffer_size != 0 &&
 			    (qpi->rxq.databuffer_size > ((16 * 1024) - 128) ||
-			     qpi->rxq.databuffer_size < 1024))
+			     qpi->rxq.databuffer_size < 128))
 				goto error_param;
 
 			ring->rx_buf_len = qpi->rxq.databuffer_size;
Reviewed-by
#2 lore raw
Quoted 25 lines · Jacob Keller
Quoted 17 lines · Jose Ignacio Tornos Martinez

The ice driver's VF queue configuration validation rejects databuffer_size values below 1024 bytes, which prevents VFs from using MTU values below 871 bytes.

The iavf driver calculates databuffer_size based on the MTU using:
databuffer_size = ALIGN(MTU + LIBETH_RX_LL_LEN, 128)

where LIBETH_RX_LL_LEN = 26 (ETH_HLEN + 2*VLAN_HLEN + ETH_FCS_LEN).

For MTU values below 871:
MTU 870: 870 + 26 = 896, aligned to 128 = 896 (< 1024, rejected) MTU 871: 871 + 26 = 897, aligned to 128 = 1024 (>= 1024, accepted)

The 1024-byte minimum seems unnecessarily restrictive, because the hardware supports databuffer_size as low as 128 bytes (the alignment boundary), which should allow MTU values down to the standard minimum of 68 bytes.

Quoted 6 lines

I haven't found the reason why the limit was configured in the commit 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message"), so with no more information and since it is working, change the minimum databuffer_size validation from 1024 to 128 bytes to allow standard low MTU values while still preventing invalid configurations.

Quoted 2 lines

I dug through some of our internal history and found that there was no justification on why 1024 was chosen.

I can't remember why I choose 1024 and didn't mention it in commit message. I agree that it is unnecessarily restrictive.

Quoted 29 lines

I agree with your assessment that the value of 128 makes the most sense as it is the actual hardware minimum. I wonder if we used to always use data buffer sizes of 1024 before the conversion to libeth. Either way, I think it makes sense to allow smaller buffers since the modern iAVF will request them.

Quoted 20 lines
Fixes 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message")
---
 drivers/net/ethernet/intel/ice/virt/queues.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/virt/queues.c +1 -1
index f73d5a3e83d4..31be2f76181c 100644
@@ -840,7 +840,7 @@ int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg)
 
 			if (qpi->rxq.databuffer_size != 0 &&
 			    (qpi->rxq.databuffer_size > ((16 * 1024) - 128) ||
-			     qpi->rxq.databuffer_size < 1024))
+			     qpi->rxq.databuffer_size < 128))
 				goto error_param;
 
 			ring->rx_buf_len = qpi->rxq.databuffer_size;
Reviewed-by on v1 1/1
#3 lore raw
In reply to Jose Ignacio Tornos Martinez

Dear Jose,

Thank you for the patch.

Am 06.04.26 um 16:56 schrieb Jose Ignacio Tornos Martinez:

Quoted 17 lines

The ice driver's VF queue configuration validation rejects databuffer_size values below 1024 bytes, which prevents VFs from using MTU values below 871 bytes.

The iavf driver calculates databuffer_size based on the MTU using:
databuffer_size = ALIGN(MTU + LIBETH_RX_LL_LEN, 128)

where LIBETH_RX_LL_LEN = 26 (ETH_HLEN + 2*VLAN_HLEN + ETH_FCS_LEN).

For MTU values below 871:

   MTU 870: 870 + 26 = 896, aligned to 128 = 896 (< 1024, rejected)
   MTU 871: 871 + 26 = 897, aligned to 128 = 1024 (>= 1024, accepted)

The 1024-byte minimum seems unnecessarily restrictive, because the hardware supports databuffer_size as low as 128 bytes (the alignment boundary), which should allow MTU values down to the standard minimum of 68 bytes.

Quoted 5 lines

I haven't found the reason why the limit was configured in the commit 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message"), so with no more information and since it is working, change the minimum databuffer_size validation from 1024 to 128 bytes to allow standard low MTU values while still preventing invalid configurations.

Should you resend, having the reproducer script would be nice to have.

Quoted 12 lines
Fixes 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message")
---
  drivers/net/ethernet/intel/ice/virt/queues.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/virt/queues.c +0 -0
index f73d5a3e83d4..31be2f76181c 100644

drivers/net/ethernet/intel/ice/virt/queues.c int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg) · line 846

Quoted 8 lines
drivers/net/ethernet/intel/ice/virt/queues.c +1 -1
@@ -840,7 +840,7 @@ int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg)
 
  			if (qpi->rxq.databuffer_size != 0 &&
  			    (qpi->rxq.databuffer_size > ((16 * 1024) - 128) ||
-			     qpi->rxq.databuffer_size < 1024))
+			     qpi->rxq.databuffer_size < 128))
  				goto error_param;
 
  			ring->rx_buf_len = qpi->rxq.databuffer_size;

Either way:

Kind regards,

Paul

#4 lore raw
Quoted 75 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Paul Menzel
Sent: Wednesday, April 8, 2026 8:25 AM
To: Jose Ignacio Tornos Martinez <[email protected]>
Cc: [email protected]; [email protected]; Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw <[email protected]>; Andrew Lunn <[email protected]>; David S . Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Keller, Jacob E <[email protected]>; Loktionov, Aleksandr <[email protected]>; Michal Swiatkowski <[email protected]>; Ertman, David M <[email protected]>; Michal Kubiak <[email protected]>; [email protected]
Subject: Re: [Intel-wired-lan] [PATCH net] ice: fix VF queue configuration with low MTU values

Dear Jose,

Thank you for the patch.

Am 06.04.26 um 16:56 schrieb Jose Ignacio Tornos Martinez:

Quoted 9 lines

The ice driver's VF queue configuration validation rejects databuffer_size values below 1024 bytes, which prevents VFs from using MTU values below 871 bytes.

The iavf driver calculates databuffer_size based on the MTU using:
databuffer_size = ALIGN(MTU + LIBETH_RX_LL_LEN, 128)

where LIBETH_RX_LL_LEN = 26 (ETH_HLEN + 2*VLAN_HLEN + ETH_FCS_LEN).

Quoted 7 lines

For MTU values below 871:

   MTU 870: 870 + 26 = 896, aligned to 128 = 896 (< 1024, rejected)
   MTU 871: 871 + 26 = 897, aligned to 128 = 1024 (>= 1024, accepted)

The 1024-byte minimum seems unnecessarily restrictive, because the hardware supports databuffer_size as low as 128 bytes (the alignment boundary), which should allow MTU values down to the standard minimum of

68 bytes.

Quoted 6 lines

I haven't found the reason why the limit was configured in the commit 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF message"), so with no more information and since it is working, change the minimum databuffer_size validation from 1024 to 128 bytes to allow standard low MTU values while still preventing invalid configurations.

Should you resend, having the reproducer script would be nice to have.

Quoted 14 lines
Fixes 9c7dd7566d18 ("ice: add validation in OP_CONFIG_VSI_QUEUES VF

message")

---
  drivers/net/ethernet/intel/ice/virt/queues.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/virt/queues.c +0 -0
index f73d5a3e83d4..31be2f76181c 100644

drivers/net/ethernet/intel/ice/virt/queues.c int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg) · line 846

Quoted 8 lines
drivers/net/ethernet/intel/ice/virt/queues.c +1 -1
@@ -840,7 +840,7 @@ int ice_vc_cfg_qs_msg(struct ice_vf *vf, u8 *msg)
 
  			if (qpi->rxq.databuffer_size != 0 &&
  			    (qpi->rxq.databuffer_size > ((16 * 1024) - 128) ||
-			     qpi->rxq.databuffer_size < 1024))
+			     qpi->rxq.databuffer_size < 128))
  				goto error_param;
 
  			ring->rx_buf_len = qpi->rxq.databuffer_size;

Either way:

Quoted 6 lines

Kind regards,

Paul