net: dropreason: add SKB_DROP_REASON_{BROAD,MULTI}CAST_BACKLOG
Subsystems (2)
PATCH 1/1 net: dropreason: add SKB_DROP_REASON_{BROAD,MULTI}CAST_BACKLOG
ipvlan and macvlan use queues to process broadcast or multicast packets from a work queue.
Under attack these queues can drop packets.
Add BROADCAST_BACKLOG drop_reason for macvlan broadcast queue.
Add MULTICAST_BACKLOG drop_reason for ipvlan multicast queue.
Also change ipvlan_rcv_frame() to use SKB_DROP_REASON_DEV_READY when the device is not UP.
--- drivers/net/ipvlan/ipvlan_core.c | 4 ++-- drivers/net/macvlan.c | 2 +- include/net/dropreason-core.h | 12 ++++++++++++ 3 files changed, 15 insertions(+), 3 deletions(-)
drivers/net/ipvlan/ipvlan_core.c +2 -2
@@ -337,7 +337,7 @@ static int ipvlan_rcv_frame(struct ipvl_addr *addr, struct sk_buff **pskb,*/ if (local) {if (unlikely (!(dev->flags &IFF_UP ))) { -kfree_skb (skb); +kfree_skb_reason (skb,SKB_DROP_REASON_DEV_READY ); goto out; }
@@ -596,7 +596,7 @@ static void ipvlan_multicast_enqueue(struct ipvl_port *port, }else {spin_unlock (&port->backlog.lock);dev_core_stats_rx_dropped_inc (skb->dev); -kfree_skb (skb); +kfree_skb_reason (skb,SKB_DROP_REASON_MULTICAST_BACKLOG ); } }
drivers/net/macvlan.c +1 -1
@@ -386,7 +386,7 @@ static void macvlan_broadcast_enqueue(struct macvlan_port *port,return ; free_nskb: -kfree_skb (nskb); +kfree_skb_reason (nskb,SKB_DROP_REASON_BROADCAST_BACKLOG ); err:dev_core_stats_rx_dropped_inc (skb->dev); }
include/net/dropreason-core.h +12 -0
@@ -69,6 +69,8 @@ FN(QDISC_DROP) \ FN(QDISC_BURST_DROP) \ FN(CPU_BACKLOG) \ + FN(BROADCAST_BACKLOG) \ + FN(MULTICAST_BACKLOG) \ FN(XDP) \ FN(TC_INGRESS) \ FN(UNHANDLED_PROTO) \
@@ -382,6 +384,16 @@ enum skb_drop_reason {* netdev_max_backlog in net.rst) or RPS flow limit */ SKB_DROP_REASON_CPU_BACKLOG , +/** +* @SKB_DROP_REASON_BROADCAST_BACKLOG: failed to enqueue the skb +* to macvlan broadcast queue. +*/ +SKB_DROP_REASON_BROADCAST_BACKLOG , +/** +* @SKB_DROP_REASON_MULTICAST_BACKLOG: failed to enqueue the skb +* to ipvlan multicast queue. +*/ +SKB_DROP_REASON_MULTICAST_BACKLOG ,/** @SKB_DROP_REASON_XDP: dropped by XDP in input path */ SKB_DROP_REASON_XDP,/** @SKB_DROP_REASON_TC_INGRESS: dropped in TC ingress HOOK */
Signature · 1 line
2.53.0.1213.gd9a14994de-goog
Quoted 5 lines · Eric Dumazet
ipvlan and macvlan use queues to process broadcast or multicast packets from a work queue.
Under attack these queues can drop packets.
Quoted 8 lines
Add
BROADCAST_BACKLOGdrop_reasonfor macvlan broadcast queue.Add
MULTICAST_BACKLOGdrop_reasonfor ipvlan multicast queue.Also change
ipvlan_rcv_frame()to useSKB_DROP_REASON_DEV_READYwhen the device is not UP.Signed-off-by Eric Dumazet <[email protected]>
Quoted 12 lines · Eric Dumazet
ipvlan and macvlan use queues to process broadcast or multicast packets from a work queue.
Under attack these queues can drop packets.
Add
BROADCAST_BACKLOGdrop_reasonfor macvlan broadcast queue.Add
MULTICAST_BACKLOGdrop_reasonfor ipvlan multicast queue.Also change
ipvlan_rcv_frame()to useSKB_DROP_REASON_DEV_READYwhen the device is not UP.
Quoted 6 lines
Signed-off-by Eric Dumazet <[email protected]>--- drivers/net/ipvlan/ipvlan_core.c | 4 ++-- drivers/net/macvlan.c | 2 +- include/net/dropreason-core.h | 12 ++++++++++++ 3 files changed, 15 insertions(+), 3 deletions(-)
Jakub Kicinski
maintainerQuoted 8 lines · On Fri, 3 Apr 2026 02:24:43 +0000 Eric Dumazet wrote:
ipvlan and macvlan use queues to process broadcast or multicast packets from a work queue.
Under attack these queues can drop packets.
Add
BROADCAST_BACKLOGdrop_reasonfor macvlan broadcast queue.Add
MULTICAST_BACKLOGdrop_reasonfor ipvlan multicast queue.
What distinction are you trying to communicate by using BROADCAST vs MULTICAST? Funny naming of the functions aside I believe that in both cases we're basically dealing with multicast traffic. Reading the code it seems like macvlan has some optimization where it delivers the frame inline if the multicast group is not very popular. And if it is popular it schedules a work (and calls that broadcast). ipvlan doesn't have the inline filter and calls the deliver via work multicast.
tl;dr I think the drivers do the same thing just call their functions broadcast vs multicast. Having two drop reasons here is actively misleading?
Signature · 1 line
pw-bot: cr
Quoted 20 lines · Jakub Kicinski
Quoted 8 lines · On Fri, 3 Apr 2026 02:24:43 +0000 Eric Dumazet wrote:
ipvlan and macvlan use queues to process broadcast or multicast packets from a work queue.
Under attack these queues can drop packets.
Add
BROADCAST_BACKLOGdrop_reasonfor macvlan broadcast queue.Add
MULTICAST_BACKLOGdrop_reasonfor ipvlan multicast queue.What distinction are you trying to communicate by using BROADCAST vs MULTICAST? Funny naming of the functions aside I believe that in both cases we're basically dealing with multicast traffic. Reading the code it seems like macvlan has some optimization where it delivers the frame inline if the multicast group is not very popular. And if it is popular it schedules a work (and calls that broadcast). ipvlan doesn't have the inline filter and calls the deliver via work multicast.
Quoted 3 lines
tl;dr I think the drivers do the same thing just call their functions broadcast vs multicast. Having two drop reasons here is actively misleading?
My intent was to differentiate ipvlan and macvlan reasons, some deployments use both.
I can rename the reasons if you think this is better.
IPVLAN_MULTICAST_BACKLOG
MACVLAN_BROADCAST_BACKLOG
Jakub Kicinski
maintainerQuoted 24 lines · On Tue, 7 Apr 2026 03:09:41 -0700 Eric Dumazet wrote:
Quoted 19 lines · Jakub Kicinski
Quoted 8 lines · On Fri, 3 Apr 2026 02:24:43 +0000 Eric Dumazet wrote:
ipvlan and macvlan use queues to process broadcast or multicast packets from a work queue.
Under attack these queues can drop packets.
Add
BROADCAST_BACKLOGdrop_reasonfor macvlan broadcast queue.Add
MULTICAST_BACKLOGdrop_reasonfor ipvlan multicast queue.What distinction are you trying to communicate by using BROADCAST vs MULTICAST? Funny naming of the functions aside I believe that in both cases we're basically dealing with multicast traffic. Reading the code it seems like macvlan has some optimization where it delivers the frame inline if the multicast group is not very popular. And if it is popular it schedules a work (and calls that broadcast). ipvlan doesn't have the inline filter and calls the deliver via work multicast.
Quoted 3 lines
tl;dr I think the drivers do the same thing just call their functions broadcast vs multicast. Having two drop reasons here is actively misleading?
Quoted 8 lines
My intent was to differentiate ipvlan and macvlan reasons, some deployments use both.
I can rename the reasons if you think this is better.
IPVLAN_MULTICAST_BACKLOG
MACVLAN_BROADCAST_BACKLOG
Sounds better, thanks