Skip to contentSkip to conversation

drm/xe/guc: Add support for NPK as a GuC log target

PATCH In review Stuart Summers 4 participants 10 messages Apr 6 – Apr 8

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/xe/guc: Add support for NPK as a GuC log target

From: John Harrison <[email protected]>

GuC provides the ability to gather logs through a hardware interface called NPK. For certain debugging scenarios this can be advantageous over getting logs from memory (or in addition to).

Add a hook for this alternate debugging mode via a configfs. This translates into a parameter passed to GuC during load time.

v2: Convert to configfs from modparam (Matt)
v3: Configfs documentation formatting (Shuicheng)
Kerneldoc/comment add + configfs entry ordering Only set the guc_log_target when GuC log is enabled (Daniele)

---
 drivers/gpu/drm/xe/xe_configfs.c | 70 ++++++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_configfs.h |  5 +++
 drivers/gpu/drm/xe/xe_defaults.h |  1 +
 drivers/gpu/drm/xe/xe_guc.c      | 11 +++--
 4 files changed, 84 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_configfs.c +70 -0
index 32102600a148..e4511ee4e135 100644
@@ -83,6 +83,16 @@
  *
  * This attribute can only be set before binding to the device.
  *
+ * GuC log target:
+ * ---------------
+ *
+ * Set the destination for the GuC log. 0 - memory only (default),
+ * 1 - NPK only, 2 - memory + NPK. Example::
+ *
+ *	# echo 2 > /sys/kernel/config/xe/0000:03:00.0/guc_log_target
+ *
+ * This attribute can only be set before binding to the device.
+ *
  * Allowed GT types:
  * -----------------
  *
@@ -256,6 +266,7 @@ struct xe_config_group_device {
 	struct config_group sriov;
 
 	struct xe_config_device {
+		u8 guc_log_target;
 		u64 gt_types_allowed;
 		u64 engines_allowed;
 		struct wa_bb ctx_restore_post_bb[XE_ENGINE_CLASS_MAX];
@@ -277,6 +288,7 @@ struct xe_config_group_device {
 };
 
 static const struct xe_config_device device_defaults = {
+	.guc_log_target = XE_DEFAULT_GUC_LOG_TARGET,
 	.gt_types_allowed = U64_MAX,
 	.engines_allowed = U64_MAX,
 	.survivability_mode = false,
@@ -357,6 +369,41 @@ static bool is_bound(struct xe_config_group_device *dev)
 	return ret;
 }
 
+static ssize_t guc_log_target_show(struct config_item *item, char *page)
+{
+	struct xe_config_device *dev = to_xe_config_device(item);
+
+	return sprintf(page, "%d\n", dev->guc_log_target);
+}
+
+static ssize_t guc_log_target_store(struct config_item *item, const char *page, size_t len)
+{
+	struct xe_config_group_device *dev = to_xe_config_group_device(item);
+	u8 guc_log_target;
+	int ret;
+
+	ret = kstrtou8(page, 0, &guc_log_target);
+	if (ret)
+		return ret;
+
+	/*
+	 * No need to define full enumeration set since this is directly
+	 * applied from the user here to GuC.
+	 */
+#define GUC_LOG_TARGET_MAX	2
+	if (guc_log_target > GUC_LOG_TARGET_MAX)
+		return -EINVAL;
+#undef GUC_LOG_TARGET_MAX
+
+	guard(mutex)(&dev->lock);
+	if (is_bound(dev))
+		return -EBUSY;
+
+	dev->config.guc_log_target = guc_log_target;
+
+	return len;
+}
+
 static ssize_t survivability_mode_show(struct config_item *item, char *page)
 {
 	struct xe_config_device *dev = to_xe_config_device(item);
@@ -815,6 +862,7 @@ CONFIGFS_ATTR(, ctx_restore_post_bb);
 CONFIGFS_ATTR(, enable_psmi);
 CONFIGFS_ATTR(, engines_allowed);
 CONFIGFS_ATTR(, gt_types_allowed);
+CONFIGFS_ATTR(, guc_log_target);
 CONFIGFS_ATTR(, survivability_mode);
 
 static struct configfs_attribute *xe_config_device_attrs[] = {
@@ -823,6 +871,7 @@ static struct configfs_attribute *xe_config_device_attrs[] = {
 	&attr_enable_psmi,
 	&attr_engines_allowed,
 	&attr_gt_types_allowed,
+	&attr_guc_log_target,
 	&attr_survivability_mode,
 	NULL,
 };
@@ -1095,6 +1144,7 @@ static void dump_custom_dev_config(struct pci_dev *pdev,
 				 dev->config.attr_); \
 	} while (0)
 
+	PRI_CUSTOM_ATTR("%d", guc_log_target);
 	PRI_CUSTOM_ATTR("%llx", gt_types_allowed);
 	PRI_CUSTOM_ATTR("%llx", engines_allowed);
 	PRI_CUSTOM_ATTR("%d", enable_psmi);
@@ -1147,6 +1197,26 @@ bool xe_configfs_get_survivability_mode(struct pci_dev *pdev)
 	return mode;
 }
 
+/**
+ * xe_configfs_get_guc_log_target - get configfs GuC log target attribute
+ * @pdev: pci device
+ *
+ * Return: guc_log_target attribute in configfs
+ */
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)
+{
+	struct xe_config_group_device *dev = find_xe_config_group_device(pdev);
+	u8 target;
+
+	if (!dev)
+		return device_defaults.guc_log_target;
+
+	target = dev->config.guc_log_target;
+	config_group_put(&dev->group);
+
+	return target;
+}
+
 static u64 get_gt_types_allowed(struct pci_dev *pdev)
 {
 	struct xe_config_group_device *dev = find_xe_config_group_device(pdev);
drivers/gpu/drm/xe/xe_configfs.h +5 -0
index 07d62bf0c152..fb5cb7c57e75 100644
@@ -19,6 +19,7 @@ int xe_configfs_init(void);
 void xe_configfs_exit(void);
 void xe_configfs_check_device(struct pci_dev *pdev);
 bool xe_configfs_get_survivability_mode(struct pci_dev *pdev);
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev);
 bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev);
 bool xe_configfs_media_gt_allowed(struct pci_dev *pdev);
 u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev);
@@ -38,6 +39,10 @@ static inline int xe_configfs_init(void) { return 0; }
 static inline void xe_configfs_exit(void) { }
 static inline void xe_configfs_check_device(struct pci_dev *pdev) { }
 static inline bool xe_configfs_get_survivability_mode(struct pci_dev *pdev) { return false; }
+static inline u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)
+{
+	return XE_DEFAULT_GUC_LOG_TARGET;
+}
 static inline bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev) { return true; }
 static inline bool xe_configfs_media_gt_allowed(struct pci_dev *pdev) { return true; }
 static inline u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) { return U64_MAX; }
drivers/gpu/drm/xe/xe_defaults.h +1 -0
index c8ae1d5f3d60..fbe670668a04 100644
@@ -12,6 +12,7 @@
 #else
 #define XE_DEFAULT_GUC_LOG_LEVEL		1
 #endif
+#define XE_DEFAULT_GUC_LOG_TARGET		0
 
 #define XE_DEFAULT_PROBE_DISPLAY		IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
 #define XE_DEFAULT_VRAM_BAR_SIZE		0
drivers/gpu/drm/xe/xe_guc.c +8 -3
index e762eada21db..c40bd4aec2ce 100644
@@ -73,13 +73,18 @@ static u32 guc_bo_ggtt_addr(struct xe_guc *guc,
 
 static u32 guc_ctl_debug_flags(struct xe_guc *guc)
 {
+	struct pci_dev *pdev = to_pci_dev(guc_to_xe(guc)->drm.dev);
 	u32 level = xe_guc_log_get_level(&guc->log);
 	u32 flags = 0;
 
-	if (!GUC_LOG_LEVEL_IS_VERBOSE(level))
+	if (!GUC_LOG_LEVEL_IS_VERBOSE(level)) {
 		flags |= GUC_LOG_DISABLED;
-	else
-		flags |= FIELD_PREP(GUC_LOG_VERBOSITY, GUC_LOG_LEVEL_TO_VERBOSITY(level));
+	} else {
+		flags |= FIELD_PREP(GUC_LOG_VERBOSITY,
+				    GUC_LOG_LEVEL_TO_VERBOSITY(level));
+		flags |= FIELD_PREP(GUC_LOG_DESTINATION,
+				    xe_configfs_get_guc_log_target(pdev));
+	}
 
 	return flags;
 }
Signature · 1 line
2.43.0
#1 lore raw

✓ CI.KUnit: success for drm/xe/guc: Add support for NPK as a GuC log target (rev3)

== Series Details ==

== Series Details ==

Series: drm/xe/guc: Add support for NPK as a GuC log target (rev3)
URL : https://patchwork.freedesktop.org/series/162087/
State : success

== Summary ==

+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [22:59:03] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[22:59:07] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[22:59:38] Starting KUnit Kernel (1/1)...
[22:59:38] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[22:59:39] ================== guc_buf (11 subtests) ===================
[22:59:39] [PASSED] test_smallest
[22:59:39] [PASSED] test_largest
[22:59:39] [PASSED] test_granular
[22:59:39] [PASSED] test_unique
[22:59:39] [PASSED] test_overlap
[22:59:39] [PASSED] test_reusable
[22:59:39] [PASSED] test_too_big
[22:59:39] [PASSED] test_flush
[22:59:39] [PASSED] test_lookup
[22:59:39] [PASSED] test_data
[22:59:39] [PASSED] test_class
[22:59:39] ===================== [PASSED] guc_buf =====================
[22:59:39] =================== guc_dbm (7 subtests) ===================
[22:59:39] [PASSED] test_empty
[22:59:39] [PASSED] test_default
[22:59:39] ======================== test_size  ========================
[22:59:39] [PASSED] 4
[22:59:39] [PASSED] 8
[22:59:39] [PASSED] 32
[22:59:39] [PASSED] 256
[22:59:39] ==================== [PASSED] test_size ====================
[22:59:39] ======================= test_reuse  ========================
[22:59:39] [PASSED] 4
[22:59:39] [PASSED] 8
[22:59:39] [PASSED] 32
[22:59:39] [PASSED] 256
[22:59:39] =================== [PASSED] test_reuse ====================
[22:59:39] =================== test_range_overlap  ====================
[22:59:39] [PASSED] 4
[22:59:39] [PASSED] 8
[22:59:39] [PASSED] 32
[22:59:39] [PASSED] 256
[22:59:39] =============== [PASSED] test_range_overlap ================
[22:59:39] =================== test_range_compact  ====================
[22:59:39] [PASSED] 4
[22:59:39] [PASSED] 8
[22:59:39] [PASSED] 32
[22:59:39] [PASSED] 256
[22:59:39] =============== [PASSED] test_range_compact ================
[22:59:39] ==================== test_range_spare  =====================
[22:59:39] [PASSED] 4
[22:59:39] [PASSED] 8
[22:59:39] [PASSED] 32
[22:59:39] [PASSED] 256
[22:59:39] ================ [PASSED] test_range_spare =================
[22:59:39] ===================== [PASSED] guc_dbm =====================
[22:59:39] =================== guc_idm (6 subtests) ===================
[22:59:39] [PASSED] bad_init
[22:59:39] [PASSED] no_init
[22:59:39] [PASSED] init_fini
[22:59:39] [PASSED] check_used
[22:59:39] [PASSED] check_quota
[22:59:39] [PASSED] check_all
[22:59:39] ===================== [PASSED] guc_idm =====================
[22:59:39] ================== no_relay (3 subtests) ===================
[22:59:39] [PASSED] xe_drops_guc2pf_if_not_ready
[22:59:39] [PASSED] xe_drops_guc2vf_if_not_ready
[22:59:39] [PASSED] xe_rejects_send_if_not_ready
[22:59:39] ==================== [PASSED] no_relay =====================
[22:59:39] ================== pf_relay (14 subtests) ==================
[22:59:39] [PASSED] pf_rejects_guc2pf_too_short
[22:59:39] [PASSED] pf_rejects_guc2pf_too_long
[22:59:39] [PASSED] pf_rejects_guc2pf_no_payload
[22:59:39] [PASSED] pf_fails_no_payload
[22:59:39] [PASSED] pf_fails_bad_origin
[22:59:39] [PASSED] pf_fails_bad_type
[22:59:39] [PASSED] pf_txn_reports_error
[22:59:39] [PASSED] pf_txn_sends_pf2guc
[22:59:39] [PASSED] pf_sends_pf2guc
[22:59:39] [SKIPPED] pf_loopback_nop
[22:59:39] [SKIPPED] pf_loopback_echo
[22:59:39] [SKIPPED] pf_loopback_fail
[22:59:39] [SKIPPED] pf_loopback_busy
[22:59:39] [SKIPPED] pf_loopback_retry
[22:59:39] ==================== [PASSED] pf_relay =====================
[22:59:39] ================== vf_relay (3 subtests) ===================
[22:59:39] [PASSED] vf_rejects_guc2vf_too_short
[22:59:39] [PASSED] vf_rejects_guc2vf_too_long
[22:59:39] [PASSED] vf_rejects_guc2vf_no_payload
[22:59:39] ==================== [PASSED] vf_relay =====================
[22:59:39] ================ pf_gt_config (9 subtests) =================
[22:59:39] [PASSED] fair_contexts_1vf
[22:59:39] [PASSED] fair_doorbells_1vf
[22:59:39] [PASSED] fair_ggtt_1vf
[22:59:39] ====================== fair_vram_1vf  ======================
[22:59:39] [PASSED] 3.50 GiB
[22:59:39] [PASSED] 11.5 GiB
[22:59:39] [PASSED] 15.5 GiB
[22:59:39] [PASSED] 31.5 GiB
[22:59:39] [PASSED] 63.5 GiB
[22:59:39] [PASSED] 1.91 GiB
[22:59:39] ================== [PASSED] fair_vram_1vf ==================
[22:59:39] ================ fair_vram_1vf_admin_only  =================
[22:59:39] [PASSED] 3.50 GiB
[22:59:39] [PASSED] 11.5 GiB
[22:59:39] [PASSED] 15.5 GiB
[22:59:39] [PASSED] 31.5 GiB
[22:59:39] [PASSED] 63.5 GiB
[22:59:39] [PASSED] 1.91 GiB
[22:59:39] ============ [PASSED] fair_vram_1vf_admin_only =============
[22:59:39] ====================== fair_contexts  ======================
[22:59:39] [PASSED] 1 VF
[22:59:39] [PASSED] 2 VFs
[22:59:39] [PASSED] 3 VFs
[22:59:39] [PASSED] 4 VFs
[22:59:39] [PASSED] 5 VFs
[22:59:39] [PASSED] 6 VFs
[22:59:39] [PASSED] 7 VFs
[22:59:39] [PASSED] 8 VFs
[22:59:39] [PASSED] 9 VFs
[22:59:39] [PASSED] 10 VFs
[22:59:39] [PASSED] 11 VFs
[22:59:39] [PASSED] 12 VFs
[22:59:39] [PASSED] 13 VFs
[22:59:39] [PASSED] 14 VFs
[22:59:39] [PASSED] 15 VFs
[22:59:39] [PASSED] 16 VFs
[22:59:39] [PASSED] 17 VFs
[22:59:39] [PASSED] 18 VFs
[22:59:39] [PASSED] 19 VFs
[22:59:39] [PASSED] 20 VFs
[22:59:39] [PASSED] 21 VFs
[22:59:39] [PASSED] 22 VFs
[22:59:39] [PASSED] 23 VFs
[22:59:39] [PASSED] 24 VFs
[22:59:39] [PASSED] 25 VFs
[22:59:39] [PASSED] 26 VFs
[22:59:39] [PASSED] 27 VFs
[22:59:39] [PASSED] 28 VFs
[22:59:39] [PASSED] 29 VFs
[22:59:39] [PASSED] 30 VFs
[22:59:39] [PASSED] 31 VFs
[22:59:39] [PASSED] 32 VFs
[22:59:39] [PASSED] 33 VFs
[22:59:39] [PASSED] 34 VFs
[22:59:39] [PASSED] 35 VFs
[22:59:39] [PASSED] 36 VFs
[22:59:39] [PASSED] 37 VFs
[22:59:39] [PASSED] 38 VFs
[22:59:39] [PASSED] 39 VFs
[22:59:39] [PASSED] 40 VFs
[22:59:39] [PASSED] 41 VFs
[22:59:39] [PASSED] 42 VFs
[22:59:39] [PASSED] 43 VFs
[22:59:39] [PASSED] 44 VFs
[22:59:39] [PASSED] 45 VFs
[22:59:39] [PASSED] 46 VFs
[22:59:39] [PASSED] 47 VFs
[22:59:39] [PASSED] 48 VFs
[22:59:39] [PASSED] 49 VFs
[22:59:39] [PASSED] 50 VFs
[22:59:39] [PASSED] 51 VFs
[22:59:39] [PASSED] 52 VFs
[22:59:39] [PASSED] 53 VFs
[22:59:39] [PASSED] 54 VFs
[22:59:39] [PASSED] 55 VFs
[22:59:39] [PASSED] 56 VFs
[22:59:39] [PASSED] 57 VFs
[22:59:39] [PASSED] 58 VFs
[22:59:39] [PASSED] 59 VFs
[22:59:39] [PASSED] 60 VFs
[22:59:39] [PASSED] 61 VFs
[22:59:39] [PASSED] 62 VFs
[22:59:39] [PASSED] 63 VFs
[22:59:39] ================== [PASSED] fair_contexts ==================
[22:59:39] ===================== fair_doorbells  ======================
[22:59:39] [PASSED] 1 VF
[22:59:39] [PASSED] 2 VFs
[22:59:39] [PASSED] 3 VFs
[22:59:39] [PASSED] 4 VFs
[22:59:39] [PASSED] 5 VFs
[22:59:39] [PASSED] 6 VFs
[22:59:39] [PASSED] 7 VFs
[22:59:39] [PASSED] 8 VFs
[22:59:39] [PASSED] 9 VFs
[22:59:39] [PASSED] 10 VFs
[22:59:39] [PASSED] 11 VFs
[22:59:39] [PASSED] 12 VFs
[22:59:39] [PASSED] 13 VFs
[22:59:39] [PASSED] 14 VFs
[22:59:39] [PASSED] 15 VFs
[22:59:39] [PASSED] 16 VFs
[22:59:39] [PASSED] 17 VFs
[22:59:39] [PASSED] 18 VFs
[22:59:39] [PASSED] 19 VFs
[22:59:39] [PASSED] 20 VFs
[22:59:39] [PASSED] 21 VFs
[22:59:39] [PASSED] 22 VFs
[22:59:39] [PASSED] 23 VFs
[22:59:39] [PASSED] 24 VFs
[22:59:39] [PASSED] 25 VFs
[22:59:39] [PASSED] 26 VFs
[22:59:39] [PASSED] 27 VFs
[22:59:39] [PASSED] 28 VFs
[22:59:39] [PASSED] 29 VFs
[22:59:39] [PASSED] 30 VFs
[22:59:39] [PASSED] 31 VFs
[22:59:39] [PASSED] 32 VFs
[22:59:39] [PASSED] 33 VFs
[22:59:39] [PASSED] 34 VFs
[22:59:39] [PASSED] 35 VFs
[22:59:39] [PASSED] 36 VFs
[22:59:39] [PASSED] 37 VFs
[22:59:39] [PASSED] 38 VFs
[22:59:39] [PASSED] 39 VFs
[22:59:39] [PASSED] 40 VFs
[22:59:39] [PASSED] 41 VFs
[22:59:39] [PASSED] 42 VFs
[22:59:39] [PASSED] 43 VFs
[22:59:39] [PASSED] 44 VFs
[22:59:39] [PASSED] 45 VFs
[22:59:39] [PASSED] 46 VFs
[22:59:39] [PASSED] 47 VFs
[22:59:39] [PASSED] 48 VFs
[22:59:39] [PASSED] 49 VFs
[22:59:39] [PASSED] 50 VFs
[22:59:39] [PASSED] 51 VFs
[22:59:39] [PASSED] 52 VFs
[22:59:39] [PASSED] 53 VFs
[22:59:39] [PASSED] 54 VFs
[22:59:39] [PASSED] 55 VFs
[22:59:39] [PASSED] 56 VFs
[22:59:39] [PASSED] 57 VFs
[22:59:39] [PASSED] 58 VFs
[22:59:39] [PASSED] 59 VFs
[22:59:39] [PASSED] 60 VFs
[22:59:39] [PASSED] 61 VFs
[22:59:39] [PASSED] 62 VFs
[22:59:39] [PASSED] 63 VFs
[22:59:39] ================= [PASSED] fair_doorbells ==================
[22:59:39] ======================== fair_ggtt  ========================
[22:59:39] [PASSED] 1 VF
[22:59:39] [PASSED] 2 VFs
[22:59:39] [PASSED] 3 VFs
[22:59:39] [PASSED] 4 VFs
[22:59:39] [PASSED] 5 VFs
[22:59:39] [PASSED] 6 VFs
[22:59:39] [PASSED] 7 VFs
[22:59:39] [PASSED] 8 VFs
[22:59:39] [PASSED] 9 VFs
[22:59:39] [PASSED] 10 VFs
[22:59:39] [PASSED] 11 VFs
[22:59:39] [PASSED] 12 VFs
[22:59:39] [PASSED] 13 VFs
[22:59:39] [PASSED] 14 VFs
[22:59:39] [PASSED] 15 VFs
[22:59:39] [PASSED] 16 VFs
[22:59:39] [PASSED] 17 VFs
[22:59:39] [PASSED] 18 VFs
[22:59:39] [PASSED] 19 VFs
[22:59:39] [PASSED] 20 VFs
[22:59:39] [PASSED] 21 VFs
[22:59:39] [PASSED] 22 VFs
[22:59:39] [PASSED] 23 VFs
[22:59:39] [PASSED] 24 VFs
[22:59:39] [PASSED] 25 VFs
[22:59:39] [PASSED] 26 VFs
[22:59:39] [PASSED] 27 VFs
[22:59:39] [PASSED] 28 VFs
[22:59:39] [PASSED] 29 VFs
[22:59:39] [PASSED] 30 VFs
[22:59:39] [PASSED] 31 VFs
[22:59:39] [PASSED] 32 VFs
[22:59:39] [PASSED] 33 VFs
[22:59:39] [PASSED] 34 VFs
[22:59:39] [PASSED] 35 VFs
[22:59:39] [PASSED] 36 VFs
[22:59:39] [PASSED] 37 VFs
[22:59:39] [PASSED] 38 VFs
[22:59:39] [PASSED] 39 VFs
[22:59:39] [PASSED] 40 VFs
[22:59:39] [PASSED] 41 VFs
[22:59:39] [PASSED] 42 VFs
[22:59:39] [PASSED] 43 VFs
[22:59:39] [PASSED] 44 VFs
[22:59:39] [PASSED] 45 VFs
[22:59:39] [PASSED] 46 VFs
[22:59:39] [PASSED] 47 VFs
[22:59:39] [PASSED] 48 VFs
[22:59:39] [PASSED] 49 VFs
[22:59:39] [PASSED] 50 VFs
[22:59:39] [PASSED] 51 VFs
[22:59:39] [PASSED] 52 VFs
[22:59:39] [PASSED] 53 VFs
[22:59:39] [PASSED] 54 VFs
[22:59:39] [PASSED] 55 VFs
[22:59:39] [PASSED] 56 VFs
[22:59:39] [PASSED] 57 VFs
[22:59:39] [PASSED] 58 VFs
[22:59:39] [PASSED] 59 VFs
[22:59:39] [PASSED] 60 VFs
[22:59:39] [PASSED] 61 VFs
[22:59:39] [PASSED] 62 VFs
[22:59:39] [PASSED] 63 VFs
[22:59:39] ==================== [PASSED] fair_ggtt ====================
[22:59:39] ======================== fair_vram  ========================
[22:59:39] [PASSED] 1 VF
[22:59:39] [PASSED] 2 VFs
[22:59:39] [PASSED] 3 VFs
[22:59:39] [PASSED] 4 VFs
[22:59:39] [PASSED] 5 VFs
[22:59:39] [PASSED] 6 VFs
[22:59:39] [PASSED] 7 VFs
[22:59:39] [PASSED] 8 VFs
[22:59:39] [PASSED] 9 VFs
[22:59:39] [PASSED] 10 VFs
[22:59:39] [PASSED] 11 VFs
[22:59:39] [PASSED] 12 VFs
[22:59:39] [PASSED] 13 VFs
[22:59:39] [PASSED] 14 VFs
[22:59:39] [PASSED] 15 VFs
[22:59:39] [PASSED] 16 VFs
[22:59:39] [PASSED] 17 VFs
[22:59:39] [PASSED] 18 VFs
[22:59:39] [PASSED] 19 VFs
[22:59:39] [PASSED] 20 VFs
[22:59:39] [PASSED] 21 VFs
[22:59:39] [PASSED] 22 VFs
[22:59:39] [PASSED] 23 VFs
[22:59:39] [PASSED] 24 VFs
[22:59:39] [PASSED] 25 VFs
[22:59:39] [PASSED] 26 VFs
[22:59:39] [PASSED] 27 VFs
[22:59:39] [PASSED] 28 VFs
[22:59:39] [PASSED] 29 VFs
[22:59:39] [PASSED] 30 VFs
[22:59:39] [PASSED] 31 VFs
[22:59:39] [PASSED] 32 VFs
[22:59:39] [PASSED] 33 VFs
[22:59:39] [PASSED] 34 VFs
[22:59:39] [PASSED] 35 VFs
[22:59:39] [PASSED] 36 VFs
[22:59:39] [PASSED] 37 VFs
[22:59:39] [PASSED] 38 VFs
[22:59:39] [PASSED] 39 VFs
[22:59:39] [PASSED] 40 VFs
[22:59:39] [PASSED] 41 VFs
[22:59:39] [PASSED] 42 VFs
[22:59:39] [PASSED] 43 VFs
[22:59:39] [PASSED] 44 VFs
[22:59:39] [PASSED] 45 VFs
[22:59:39] [PASSED] 46 VFs
[22:59:39] [PASSED] 47 VFs
[22:59:39] [PASSED] 48 VFs
[22:59:39] [PASSED] 49 VFs
[22:59:39] [PASSED] 50 VFs
[22:59:39] [PASSED] 51 VFs
[22:59:39] [PASSED] 52 VFs
[22:59:39] [PASSED] 53 VFs
[22:59:39] [PASSED] 54 VFs
[22:59:39] [PASSED] 55 VFs
[22:59:39] [PASSED] 56 VFs
[22:59:39] [PASSED] 57 VFs
[22:59:39] [PASSED] 58 VFs
[22:59:39] [PASSED] 59 VFs
[22:59:39] [PASSED] 60 VFs
[22:59:39] [PASSED] 61 VFs
[22:59:39] [PASSED] 62 VFs
[22:59:39] [PASSED] 63 VFs
[22:59:39] ==================== [PASSED] fair_vram ====================
[22:59:39] ================== [PASSED] pf_gt_config ===================
[22:59:39] ===================== lmtt (1 subtest) =====================
[22:59:39] ======================== test_ops  =========================
[22:59:39] [PASSED] 2-level
[22:59:39] [PASSED] multi-level
[22:59:39] ==================== [PASSED] test_ops =====================
[22:59:39] ====================== [PASSED] lmtt =======================
[22:59:39] ================= pf_service (11 subtests) =================
[22:59:39] [PASSED] pf_negotiate_any
[22:59:39] [PASSED] pf_negotiate_base_match
[22:59:39] [PASSED] pf_negotiate_base_newer
[22:59:39] [PASSED] pf_negotiate_base_next
[22:59:39] [SKIPPED] pf_negotiate_base_older
[22:59:39] [PASSED] pf_negotiate_base_prev
[22:59:39] [PASSED] pf_negotiate_latest_match
[22:59:39] [PASSED] pf_negotiate_latest_newer
[22:59:39] [PASSED] pf_negotiate_latest_next
[22:59:39] [SKIPPED] pf_negotiate_latest_older
[22:59:39] [SKIPPED] pf_negotiate_latest_prev
[22:59:39] =================== [PASSED] pf_service ====================
[22:59:39] ================= xe_guc_g2g (2 subtests) ==================
[22:59:39] ============== xe_live_guc_g2g_kunit_default  ==============
[22:59:39] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ==========
[22:59:39] ============== xe_live_guc_g2g_kunit_allmem  ===============
[22:59:39] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ==========
[22:59:39] =================== [SKIPPED] xe_guc_g2g ===================
[22:59:39] =================== xe_mocs (2 subtests) ===================
[22:59:39] ================ xe_live_mocs_kernel_kunit  ================
[22:59:39] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============
[22:59:39] ================ xe_live_mocs_reset_kunit  =================
[22:59:39] ============ [SKIPPED] xe_live_mocs_reset_kunit ============
[22:59:39] ==================== [SKIPPED] xe_mocs =====================
[22:59:39] ================= xe_migrate (2 subtests) ==================
[22:59:39] ================= xe_migrate_sanity_kunit  =================
[22:59:39] ============ [SKIPPED] xe_migrate_sanity_kunit =============
[22:59:39] ================== xe_validate_ccs_kunit  ==================
[22:59:39] ============= [SKIPPED] xe_validate_ccs_kunit ==============
[22:59:39] =================== [SKIPPED] xe_migrate ===================
[22:59:39] ================== xe_dma_buf (1 subtest) ==================
[22:59:39] ==================== xe_dma_buf_kunit  =====================
[22:59:39] ================ [SKIPPED] xe_dma_buf_kunit ================
[22:59:39] =================== [SKIPPED] xe_dma_buf ===================
[22:59:39] ================= xe_bo_shrink (1 subtest) =================
[22:59:39] =================== xe_bo_shrink_kunit  ====================
[22:59:39] =============== [SKIPPED] xe_bo_shrink_kunit ===============
[22:59:39] ================== [SKIPPED] xe_bo_shrink ==================
[22:59:39] ==================== xe_bo (2 subtests) ====================
[22:59:39] ================== xe_ccs_migrate_kunit  ===================
[22:59:39] ============== [SKIPPED] xe_ccs_migrate_kunit ==============
[22:59:39] ==================== xe_bo_evict_kunit  ====================
[22:59:39] =============== [SKIPPED] xe_bo_evict_kunit ================
[22:59:39] ===================== [SKIPPED] xe_bo ======================
[22:59:39] ==================== args (13 subtests) ====================
[22:59:39] [PASSED] count_args_test
[22:59:39] [PASSED] call_args_example
[22:59:39] [PASSED] call_args_test
[22:59:39] [PASSED] drop_first_arg_example
[22:59:39] [PASSED] drop_first_arg_test
[22:59:39] [PASSED] first_arg_example
[22:59:39] [PASSED] first_arg_test
[22:59:39] [PASSED] last_arg_example
[22:59:39] [PASSED] last_arg_test
[22:59:39] [PASSED] pick_arg_example
[22:59:39] [PASSED] if_args_example
[22:59:39] [PASSED] if_args_test
[22:59:39] [PASSED] sep_comma_example
[22:59:39] ====================== [PASSED] args =======================
[22:59:39] =================== xe_pci (3 subtests) ====================
[22:59:39] ==================== check_graphics_ip  ====================
[22:59:39] [PASSED] 12.00 Xe_LP
[22:59:39] [PASSED] 12.10 Xe_LP+
[22:59:39] [PASSED] 12.55 Xe_HPG
[22:59:39] [PASSED] 12.60 Xe_HPC
[22:59:39] [PASSED] 12.70 Xe_LPG
[22:59:39] [PASSED] 12.71 Xe_LPG
[22:59:39] [PASSED] 12.74 Xe_LPG+
[22:59:39] [PASSED] 20.01 Xe2_HPG
[22:59:39] [PASSED] 20.02 Xe2_HPG
[22:59:39] [PASSED] 20.04 Xe2_LPG
[22:59:39] [PASSED] 30.00 Xe3_LPG
[22:59:39] [PASSED] 30.01 Xe3_LPG
[22:59:39] [PASSED] 30.03 Xe3_LPG
[22:59:39] [PASSED] 30.04 Xe3_LPG
[22:59:39] [PASSED] 30.05 Xe3_LPG
[22:59:39] [PASSED] 35.10 Xe3p_LPG
[22:59:39] [PASSED] 35.11 Xe3p_XPC
[22:59:39] ================ [PASSED] check_graphics_ip ================
[22:59:39] ===================== check_media_ip  ======================
[22:59:39] [PASSED] 12.00 Xe_M
[22:59:39] [PASSED] 12.55 Xe_HPM
[22:59:39] [PASSED] 13.00 Xe_LPM+
[22:59:39] [PASSED] 13.01 Xe2_HPM
[22:59:39] [PASSED] 20.00 Xe2_LPM
[22:59:39] [PASSED] 30.00 Xe3_LPM
[22:59:39] [PASSED] 30.02 Xe3_LPM
[22:59:39] [PASSED] 35.00 Xe3p_LPM
[22:59:39] [PASSED] 35.03 Xe3p_HPM
[22:59:39] ================= [PASSED] check_media_ip ==================
[22:59:39] =================== check_platform_desc  ===================
[22:59:39] [PASSED] 0x9A60 (TIGERLAKE)
[22:59:39] [PASSED] 0x9A68 (TIGERLAKE)
[22:59:39] [PASSED] 0x9A70 (TIGERLAKE)
[22:59:39] [PASSED] 0x9A40 (TIGERLAKE)
[22:59:39] [PASSED] 0x9A49 (TIGERLAKE)
[22:59:39] [PASSED] 0x9A59 (TIGERLAKE)
[22:59:39] [PASSED] 0x9A78 (TIGERLAKE)
[22:59:39] [PASSED] 0x9AC0 (TIGERLAKE)
[22:59:39] [PASSED] 0x9AC9 (TIGERLAKE)
[22:59:39] [PASSED] 0x9AD9 (TIGERLAKE)
[22:59:39] [PASSED] 0x9AF8 (TIGERLAKE)
[22:59:39] [PASSED] 0x4C80 (ROCKETLAKE)
[22:59:39] [PASSED] 0x4C8A (ROCKETLAKE)
[22:59:39] [PASSED] 0x4C8B (ROCKETLAKE)
[22:59:39] [PASSED] 0x4C8C (ROCKETLAKE)
[22:59:39] [PASSED] 0x4C90 (ROCKETLAKE)
[22:59:39] [PASSED] 0x4C9A (ROCKETLAKE)
[22:59:39] [PASSED] 0x4680 (ALDERLAKE_S)
[22:59:39] [PASSED] 0x4682 (ALDERLAKE_S)
[22:59:39] [PASSED] 0x4688 (ALDERLAKE_S)
[22:59:39] [PASSED] 0x468A (ALDERLAKE_S)
[22:59:39] [PASSED] 0x468B (ALDERLAKE_S)
[22:59:39] [PASSED] 0x4690 (ALDERLAKE_S)
[22:59:39] [PASSED] 0x4692 (ALDERLAKE_S)
[22:59:39] [PASSED] 0x4693 (ALDERLAKE_S)
[22:59:39] [PASSED] 0x46A0 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46A1 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46A2 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46A3 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46A6 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46A8 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46AA (ALDERLAKE_P)
[22:59:39] [PASSED] 0x462A (ALDERLAKE_P)
[22:59:39] [PASSED] 0x4626 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x4628 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46B0 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46B1 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46B2 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46B3 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46C0 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46C1 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46C2 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46C3 (ALDERLAKE_P)
[22:59:39] [PASSED] 0x46D0 (ALDERLAKE_N)
[22:59:39] [PASSED] 0x46D1 (ALDERLAKE_N)
[22:59:39] [PASSED] 0x46D2 (ALDERLAKE_N)
[22:59:39] [PASSED] 0x46D3 (ALDERLAKE_N)
[22:59:39] [PASSED] 0x46D4 (ALDERLAKE_N)
[22:59:39] [PASSED] 0xA721 (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA7A1 (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA7A9 (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA7AC (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA7AD (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA720 (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA7A0 (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA7A8 (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA7AA (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA7AB (ALDERLAKE_P)
[22:59:39] [PASSED] 0xA780 (ALDERLAKE_S)
[22:59:39] [PASSED] 0xA781 (ALDERLAKE_S)
[22:59:39] [PASSED] 0xA782 (ALDERLAKE_S)
[22:59:39] [PASSED] 0xA783 (ALDERLAKE_S)
[22:59:39] [PASSED] 0xA788 (ALDERLAKE_S)
[22:59:39] [PASSED] 0xA789 (ALDERLAKE_S)
[22:59:39] [PASSED] 0xA78A (ALDERLAKE_S)
[22:59:39] [PASSED] 0xA78B (ALDERLAKE_S)
[22:59:39] [PASSED] 0x4905 (DG1)
[22:59:39] [PASSED] 0x4906 (DG1)
[22:59:39] [PASSED] 0x4907 (DG1)
[22:59:39] [PASSED] 0x4908 (DG1)
[22:59:39] [PASSED] 0x4909 (DG1)
[22:59:39] [PASSED] 0x56C0 (DG2)
[22:59:39] [PASSED] 0x56C2 (DG2)
[22:59:39] [PASSED] 0x56C1 (DG2)
[22:59:39] [PASSED] 0x7D51 (METEORLAKE)
[22:59:39] [PASSED] 0x7DD1 (METEORLAKE)
[22:59:39] [PASSED] 0x7D41 (METEORLAKE)
[22:59:39] [PASSED] 0x7D67 (METEORLAKE)
[22:59:39] [PASSED] 0xB640 (METEORLAKE)
[22:59:39] [PASSED] 0x56A0 (DG2)
[22:59:39] [PASSED] 0x56A1 (DG2)
[22:59:39] [PASSED] 0x56A2 (DG2)
[22:59:39] [PASSED] 0x56BE (DG2)
[22:59:39] [PASSED] 0x56BF (DG2)
[22:59:39] [PASSED] 0x5690 (DG2)
[22:59:39] [PASSED] 0x5691 (DG2)
[22:59:39] [PASSED] 0x5692 (DG2)
[22:59:39] [PASSED] 0x56A5 (DG2)
[22:59:39] [PASSED] 0x56A6 (DG2)
[22:59:39] [PASSED] 0x56B0 (DG2)
[22:59:39] [PASSED] 0x56B1 (DG2)
[22:59:39] [PASSED] 0x56BA (DG2)
[22:59:39] [PASSED] 0x56BB (DG2)
[22:59:39] [PASSED] 0x56BC (DG2)
[22:59:39] [PASSED] 0x56BD (DG2)
[22:59:39] [PASSED] 0x5693 (DG2)
[22:59:39] [PASSED] 0x5694 (DG2)
[22:59:39] [PASSED] 0x5695 (DG2)
[22:59:39] [PASSED] 0x56A3 (DG2)
[22:59:39] [PASSED] 0x56A4 (DG2)
[22:59:39] [PASSED] 0x56B2 (DG2)
[22:59:39] [PASSED] 0x56B3 (DG2)
[22:59:39] [PASSED] 0x5696 (DG2)
[22:59:39] [PASSED] 0x5697 (DG2)
[22:59:39] [PASSED] 0xB69 (PVC)
[22:59:39] [PASSED] 0xB6E (PVC)
[22:59:39] [PASSED] 0xBD4 (PVC)
[22:59:39] [PASSED] 0xBD5 (PVC)
[22:59:39] [PASSED] 0xBD6 (PVC)
[22:59:39] [PASSED] 0xBD7 (PVC)
[22:59:39] [PASSED] 0xBD8 (PVC)
[22:59:39] [PASSED] 0xBD9 (PVC)
[22:59:39] [PASSED] 0xBDA (PVC)
[22:59:39] [PASSED] 0xBDB (PVC)
[22:59:39] [PASSED] 0xBE0 (PVC)
[22:59:39] [PASSED] 0xBE1 (PVC)
[22:59:39] [PASSED] 0xBE5 (PVC)
[22:59:39] [PASSED] 0x7D40 (METEORLAKE)
[22:59:39] [PASSED] 0x7D45 (METEORLAKE)
[22:59:39] [PASSED] 0x7D55 (METEORLAKE)
[22:59:39] [PASSED] 0x7D60 (METEORLAKE)
[22:59:39] [PASSED] 0x7DD5 (METEORLAKE)
[22:59:39] [PASSED] 0x6420 (LUNARLAKE)
[22:59:39] [PASSED] 0x64A0 (LUNARLAKE)
[22:59:39] [PASSED] 0x64B0 (LUNARLAKE)
[22:59:39] [PASSED] 0xE202 (BATTLEMAGE)
[22:59:39] [PASSED] 0xE209 (BATTLEMAGE)
[22:59:39] [PASSED] 0xE20B (BATTLEMAGE)
[22:59:39] [PASSED] 0xE20C (BATTLEMAGE)
[22:59:39] [PASSED] 0xE20D (BATTLEMAGE)
[22:59:39] [PASSED] 0xE210 (BATTLEMAGE)
[22:59:39] [PASSED] 0xE211 (BATTLEMAGE)
[22:59:39] [PASSED] 0xE212 (BATTLEMAGE)
[22:59:39] [PASSED] 0xE216 (BATTLEMAGE)
[22:59:39] [PASSED] 0xE220 (BATTLEMAGE)
[22:59:39] [PASSED] 0xE221 (BATTLEMAGE)
[22:59:39] [PASSED] 0xE222 (BATTLEMAGE)
[22:59:39] [PASSED] 0xE223 (BATTLEMAGE)
[22:59:39] [PASSED] 0xB080 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB081 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB082 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB083 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB084 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB085 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB086 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB087 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB08F (PANTHERLAKE)
[22:59:39] [PASSED] 0xB090 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB0A0 (PANTHERLAKE)
[22:59:39] [PASSED] 0xB0B0 (PANTHERLAKE)
[22:59:39] [PASSED] 0xFD80 (PANTHERLAKE)
[22:59:39] [PASSED] 0xFD81 (PANTHERLAKE)
[22:59:39] [PASSED] 0xD740 (NOVALAKE_S)
[22:59:39] [PASSED] 0xD741 (NOVALAKE_S)
[22:59:39] [PASSED] 0xD742 (NOVALAKE_S)
[22:59:39] [PASSED] 0xD743 (NOVALAKE_S)
[22:59:39] [PASSED] 0xD744 (NOVALAKE_S)
[22:59:39] [PASSED] 0xD745 (NOVALAKE_S)
[22:59:39] [PASSED] 0x674C (CRESCENTISLAND)
[22:59:39] [PASSED] 0xD750 (NOVALAKE_P)
[22:59:39] [PASSED] 0xD751 (NOVALAKE_P)
[22:59:39] [PASSED] 0xD752 (NOVALAKE_P)
[22:59:39] [PASSED] 0xD753 (NOVALAKE_P)
[22:59:39] [PASSED] 0xD754 (NOVALAKE_P)
[22:59:39] [PASSED] 0xD755 (NOVALAKE_P)
[22:59:39] [PASSED] 0xD756 (NOVALAKE_P)
[22:59:39] [PASSED] 0xD757 (NOVALAKE_P)
[22:59:39] [PASSED] 0xD75F (NOVALAKE_P)
[22:59:39] =============== [PASSED] check_platform_desc ===============
[22:59:39] ===================== [PASSED] xe_pci ======================
[22:59:39] =================== xe_rtp (2 subtests) ====================
[22:59:39] =============== xe_rtp_process_to_sr_tests  ================
[22:59:39] [PASSED] coalesce-same-reg
[22:59:39] [PASSED] no-match-no-add
[22:59:39] [PASSED] match-or
[22:59:39] [PASSED] match-or-xfail
[22:59:39] [PASSED] no-match-no-add-multiple-rules
[22:59:39] [PASSED] two-regs-two-entries
[22:59:39] [PASSED] clr-one-set-other
[22:59:39] [PASSED] set-field
[22:59:39] [PASSED] conflict-duplicate
stty: 'standard input': Inappropriate ioctl for device
[22:59:39] [PASSED] conflict-not-disjoint
[22:59:39] [PASSED] conflict-reg-type
[22:59:39] =========== [PASSED] xe_rtp_process_to_sr_tests ============
[22:59:39] ================== xe_rtp_process_tests  ===================
[22:59:39] [PASSED] active1
[22:59:39] [PASSED] active2
[22:59:39] [PASSED] active-inactive
[22:59:39] [PASSED] inactive-active
[22:59:39] [PASSED] inactive-1st_or_active-inactive
[22:59:39] [PASSED] inactive-2nd_or_active-inactive
[22:59:39] [PASSED] inactive-last_or_active-inactive
[22:59:39] [PASSED] inactive-no_or_active-inactive
[22:59:39] ============== [PASSED] xe_rtp_process_tests ===============
[22:59:39] ===================== [PASSED] xe_rtp ======================
[22:59:39] ==================== xe_wa (1 subtest) =====================
[22:59:39] ======================== xe_wa_gt  =========================
[22:59:39] [PASSED] TIGERLAKE B0
[22:59:39] [PASSED] DG1 A0
[22:59:39] [PASSED] DG1 B0
[22:59:39] [PASSED] ALDERLAKE_S A0
[22:59:39] [PASSED] ALDERLAKE_S B0
[22:59:39] [PASSED] ALDERLAKE_S C0
[22:59:39] [PASSED] ALDERLAKE_S D0
[22:59:39] [PASSED] ALDERLAKE_P A0
[22:59:39] [PASSED] ALDERLAKE_P B0
[22:59:39] [PASSED] ALDERLAKE_P C0
[22:59:39] [PASSED] ALDERLAKE_S RPLS D0
[22:59:39] [PASSED] ALDERLAKE_P RPLU E0
[22:59:39] [PASSED] DG2 G10 C0
[22:59:39] [PASSED] DG2 G11 B1
[22:59:39] [PASSED] DG2 G12 A1
[22:59:39] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0
[22:59:39] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0
[22:59:39] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0
[22:59:39] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0
[22:59:39] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0
[22:59:39] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1
[22:59:39] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0
[22:59:39] ==================== [PASSED] xe_wa_gt =====================
[22:59:39] ====================== [PASSED] xe_wa ======================
[22:59:39] ============================================================
[22:59:39] Testing complete. Ran 597 tests: passed: 579, skipped: 18
[22:59:39] Elapsed time: 35.912s total, 4.174s configuring, 31.121s building, 0.593s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [22:59:39] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[22:59:41] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[23:00:05] Starting KUnit Kernel (1/1)...
[23:00:05] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[23:00:05] ============ drm_test_pick_cmdline (2 subtests) ============
[23:00:05] [PASSED] drm_test_pick_cmdline_res_1920_1080_60
[23:00:05] =============== drm_test_pick_cmdline_named  ===============
[23:00:05] [PASSED] NTSC
[23:00:05] [PASSED] NTSC-J
[23:00:05] [PASSED] PAL
[23:00:05] [PASSED] PAL-M
[23:00:05] =========== [PASSED] drm_test_pick_cmdline_named ===========
[23:00:05] ============== [PASSED] drm_test_pick_cmdline ==============
[23:00:05] == drm_test_atomic_get_connector_for_encoder (1 subtest) ===
[23:00:05] [PASSED] drm_test_drm_atomic_get_connector_for_encoder
[23:00:05] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ====
[23:00:05] =========== drm_validate_clone_mode (2 subtests) ===========
[23:00:05] ============== drm_test_check_in_clone_mode  ===============
[23:00:05] [PASSED] in_clone_mode
[23:00:05] [PASSED] not_in_clone_mode
[23:00:05] ========== [PASSED] drm_test_check_in_clone_mode ===========
[23:00:05] =============== drm_test_check_valid_clones  ===============
[23:00:05] [PASSED] not_in_clone_mode
[23:00:05] [PASSED] valid_clone
[23:00:05] [PASSED] invalid_clone
[23:00:05] =========== [PASSED] drm_test_check_valid_clones ===========
[23:00:05] ============= [PASSED] drm_validate_clone_mode =============
[23:00:05] ============= drm_validate_modeset (1 subtest) =============
[23:00:05] [PASSED] drm_test_check_connector_changed_modeset
[23:00:05] ============== [PASSED] drm_validate_modeset ===============
[23:00:05] ====== drm_test_bridge_get_current_state (2 subtests) ======
[23:00:05] [PASSED] drm_test_drm_bridge_get_current_state_atomic
[23:00:05] [PASSED] drm_test_drm_bridge_get_current_state_legacy
[23:00:05] ======== [PASSED] drm_test_bridge_get_current_state ========
[23:00:05] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ======
[23:00:05] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic
[23:00:05] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled
[23:00:05] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy
[23:00:05] ======== [PASSED] drm_test_bridge_helper_reset_crtc ========
[23:00:05] ============== drm_bridge_alloc (2 subtests) ===============
[23:00:05] [PASSED] drm_test_drm_bridge_alloc_basic
[23:00:05] [PASSED] drm_test_drm_bridge_alloc_get_put
[23:00:05] ================ [PASSED] drm_bridge_alloc =================
[23:00:05] ============= drm_cmdline_parser (40 subtests) =============
[23:00:05] [PASSED] drm_test_cmdline_force_d_only
[23:00:05] [PASSED] drm_test_cmdline_force_D_only_dvi
[23:00:05] [PASSED] drm_test_cmdline_force_D_only_hdmi
[23:00:05] [PASSED] drm_test_cmdline_force_D_only_not_digital
[23:00:05] [PASSED] drm_test_cmdline_force_e_only
[23:00:05] [PASSED] drm_test_cmdline_res
[23:00:05] [PASSED] drm_test_cmdline_res_vesa
[23:00:05] [PASSED] drm_test_cmdline_res_vesa_rblank
[23:00:05] [PASSED] drm_test_cmdline_res_rblank
[23:00:05] [PASSED] drm_test_cmdline_res_bpp
[23:00:05] [PASSED] drm_test_cmdline_res_refresh
[23:00:05] [PASSED] drm_test_cmdline_res_bpp_refresh
[23:00:05] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced
[23:00:05] [PASSED] drm_test_cmdline_res_bpp_refresh_margins
[23:00:05] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off
[23:00:05] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on
[23:00:05] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog
[23:00:05] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital
[23:00:05] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on
[23:00:05] [PASSED] drm_test_cmdline_res_margins_force_on
[23:00:05] [PASSED] drm_test_cmdline_res_vesa_margins
[23:00:05] [PASSED] drm_test_cmdline_name
[23:00:05] [PASSED] drm_test_cmdline_name_bpp
[23:00:05] [PASSED] drm_test_cmdline_name_option
[23:00:05] [PASSED] drm_test_cmdline_name_bpp_option
[23:00:05] [PASSED] drm_test_cmdline_rotate_0
[23:00:05] [PASSED] drm_test_cmdline_rotate_90
[23:00:05] [PASSED] drm_test_cmdline_rotate_180
[23:00:05] [PASSED] drm_test_cmdline_rotate_270
[23:00:05] [PASSED] drm_test_cmdline_hmirror
[23:00:05] [PASSED] drm_test_cmdline_vmirror
[23:00:05] [PASSED] drm_test_cmdline_margin_options
[23:00:05] [PASSED] drm_test_cmdline_multiple_options
[23:00:05] [PASSED] drm_test_cmdline_bpp_extra_and_option
[23:00:05] [PASSED] drm_test_cmdline_extra_and_option
[23:00:05] [PASSED] drm_test_cmdline_freestanding_options
[23:00:05] [PASSED] drm_test_cmdline_freestanding_force_e_and_options
[23:00:05] [PASSED] drm_test_cmdline_panel_orientation
[23:00:05] ================ drm_test_cmdline_invalid  =================
[23:00:05] [PASSED] margin_only
[23:00:05] [PASSED] interlace_only
[23:00:05] [PASSED] res_missing_x
[23:00:05] [PASSED] res_missing_y
[23:00:05] [PASSED] res_bad_y
[23:00:05] [PASSED] res_missing_y_bpp
[23:00:05] [PASSED] res_bad_bpp
[23:00:05] [PASSED] res_bad_refresh
[23:00:05] [PASSED] res_bpp_refresh_force_on_off
[23:00:05] [PASSED] res_invalid_mode
[23:00:05] [PASSED] res_bpp_wrong_place_mode
[23:00:05] [PASSED] name_bpp_refresh
[23:00:05] [PASSED] name_refresh
[23:00:05] [PASSED] name_refresh_wrong_mode
[23:00:05] [PASSED] name_refresh_invalid_mode
[23:00:05] [PASSED] rotate_multiple
[23:00:05] [PASSED] rotate_invalid_val
[23:00:05] [PASSED] rotate_truncated
[23:00:05] [PASSED] invalid_option
[23:00:05] [PASSED] invalid_tv_option
[23:00:05] [PASSED] truncated_tv_option
[23:00:05] ============ [PASSED] drm_test_cmdline_invalid =============
[23:00:05] =============== drm_test_cmdline_tv_options  ===============
[23:00:05] [PASSED] NTSC
[23:00:05] [PASSED] NTSC_443
[23:00:05] [PASSED] NTSC_J
[23:00:05] [PASSED] PAL
[23:00:05] [PASSED] PAL_M
[23:00:05] [PASSED] PAL_N
[23:00:05] [PASSED] SECAM
[23:00:05] [PASSED] MONO_525
[23:00:05] [PASSED] MONO_625
[23:00:05] =========== [PASSED] drm_test_cmdline_tv_options ===========
[23:00:05] =============== [PASSED] drm_cmdline_parser ================
[23:00:05] ========== drmm_connector_hdmi_init (20 subtests) ==========
[23:00:05] [PASSED] drm_test_connector_hdmi_init_valid
[23:00:05] [PASSED] drm_test_connector_hdmi_init_bpc_8
[23:00:05] [PASSED] drm_test_connector_hdmi_init_bpc_10
[23:00:05] [PASSED] drm_test_connector_hdmi_init_bpc_12
[23:00:05] [PASSED] drm_test_connector_hdmi_init_bpc_invalid
[23:00:05] [PASSED] drm_test_connector_hdmi_init_bpc_null
[23:00:05] [PASSED] drm_test_connector_hdmi_init_formats_empty
[23:00:05] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb
[23:00:05] === drm_test_connector_hdmi_init_formats_yuv420_allowed  ===
[23:00:05] [PASSED] supported_formats=0x9 yuv420_allowed=1
[23:00:05] [PASSED] supported_formats=0x9 yuv420_allowed=0
[23:00:05] [PASSED] supported_formats=0x5 yuv420_allowed=1
[23:00:05] [PASSED] supported_formats=0x5 yuv420_allowed=0
[23:00:05] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed ===
[23:00:05] [PASSED] drm_test_connector_hdmi_init_null_ddc
[23:00:05] [PASSED] drm_test_connector_hdmi_init_null_product
[23:00:05] [PASSED] drm_test_connector_hdmi_init_null_vendor
[23:00:05] [PASSED] drm_test_connector_hdmi_init_product_length_exact
[23:00:05] [PASSED] drm_test_connector_hdmi_init_product_length_too_long
[23:00:05] [PASSED] drm_test_connector_hdmi_init_product_valid
[23:00:05] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact
[23:00:05] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long
[23:00:05] [PASSED] drm_test_connector_hdmi_init_vendor_valid
[23:00:05] ========= drm_test_connector_hdmi_init_type_valid  =========
[23:00:05] [PASSED] HDMI-A
[23:00:05] [PASSED] HDMI-B
[23:00:05] ===== [PASSED] drm_test_connector_hdmi_init_type_valid =====
[23:00:05] ======== drm_test_connector_hdmi_init_type_invalid  ========
[23:00:05] [PASSED] Unknown
[23:00:05] [PASSED] VGA
[23:00:05] [PASSED] DVI-I
[23:00:05] [PASSED] DVI-D
[23:00:05] [PASSED] DVI-A
[23:00:05] [PASSED] Composite
[23:00:05] [PASSED] SVIDEO
[23:00:05] [PASSED] LVDS
[23:00:05] [PASSED] Component
[23:00:05] [PASSED] DIN
[23:00:05] [PASSED] DP
[23:00:05] [PASSED] TV
[23:00:05] [PASSED] eDP
[23:00:05] [PASSED] Virtual
[23:00:05] [PASSED] DSI
[23:00:05] [PASSED] DPI
[23:00:05] [PASSED] Writeback
[23:00:05] [PASSED] SPI
[23:00:05] [PASSED] USB
[23:00:05] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ====
[23:00:05] ============ [PASSED] drmm_connector_hdmi_init =============
[23:00:05] ============= drmm_connector_init (3 subtests) =============
[23:00:05] [PASSED] drm_test_drmm_connector_init
[23:00:05] [PASSED] drm_test_drmm_connector_init_null_ddc
[23:00:05] ========= drm_test_drmm_connector_init_type_valid  =========
[23:00:05] [PASSED] Unknown
[23:00:05] [PASSED] VGA
[23:00:05] [PASSED] DVI-I
[23:00:05] [PASSED] DVI-D
[23:00:05] [PASSED] DVI-A
[23:00:05] [PASSED] Composite
[23:00:05] [PASSED] SVIDEO
[23:00:05] [PASSED] LVDS
[23:00:05] [PASSED] Component
[23:00:05] [PASSED] DIN
[23:00:05] [PASSED] DP
[23:00:05] [PASSED] HDMI-A
[23:00:05] [PASSED] HDMI-B
[23:00:05] [PASSED] TV
[23:00:05] [PASSED] eDP
[23:00:05] [PASSED] Virtual
[23:00:05] [PASSED] DSI
[23:00:05] [PASSED] DPI
[23:00:05] [PASSED] Writeback
[23:00:05] [PASSED] SPI
[23:00:05] [PASSED] USB
[23:00:05] ===== [PASSED] drm_test_drmm_connector_init_type_valid =====
[23:00:05] =============== [PASSED] drmm_connector_init ===============
[23:00:05] ========= drm_connector_dynamic_init (6 subtests) ==========
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_init
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_init_not_added
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_init_properties
[23:00:05] ===== drm_test_drm_connector_dynamic_init_type_valid  ======
[23:00:05] [PASSED] Unknown
[23:00:05] [PASSED] VGA
[23:00:05] [PASSED] DVI-I
[23:00:05] [PASSED] DVI-D
[23:00:05] [PASSED] DVI-A
[23:00:05] [PASSED] Composite
[23:00:05] [PASSED] SVIDEO
[23:00:05] [PASSED] LVDS
[23:00:05] [PASSED] Component
[23:00:05] [PASSED] DIN
[23:00:05] [PASSED] DP
[23:00:05] [PASSED] HDMI-A
[23:00:05] [PASSED] HDMI-B
[23:00:05] [PASSED] TV
[23:00:05] [PASSED] eDP
[23:00:05] [PASSED] Virtual
[23:00:05] [PASSED] DSI
[23:00:05] [PASSED] DPI
[23:00:05] [PASSED] Writeback
[23:00:05] [PASSED] SPI
[23:00:05] [PASSED] USB
[23:00:05] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid ==
[23:00:05] ======== drm_test_drm_connector_dynamic_init_name  =========
[23:00:05] [PASSED] Unknown
[23:00:05] [PASSED] VGA
[23:00:05] [PASSED] DVI-I
[23:00:05] [PASSED] DVI-D
[23:00:05] [PASSED] DVI-A
[23:00:05] [PASSED] Composite
[23:00:05] [PASSED] SVIDEO
[23:00:05] [PASSED] LVDS
[23:00:05] [PASSED] Component
[23:00:05] [PASSED] DIN
[23:00:05] [PASSED] DP
[23:00:05] [PASSED] HDMI-A
[23:00:05] [PASSED] HDMI-B
[23:00:05] [PASSED] TV
[23:00:05] [PASSED] eDP
[23:00:05] [PASSED] Virtual
[23:00:05] [PASSED] DSI
[23:00:05] [PASSED] DPI
[23:00:05] [PASSED] Writeback
[23:00:05] [PASSED] SPI
[23:00:05] [PASSED] USB
[23:00:05] ==== [PASSED] drm_test_drm_connector_dynamic_init_name =====
[23:00:05] =========== [PASSED] drm_connector_dynamic_init ============
[23:00:05] ==== drm_connector_dynamic_register_early (4 subtests) =====
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_early_defer
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object
[23:00:05] ====== [PASSED] drm_connector_dynamic_register_early =======
[23:00:05] ======= drm_connector_dynamic_register (7 subtests) ========
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_on_list
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_no_defer
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_no_init
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_mode_object
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_sysfs
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name
[23:00:05] [PASSED] drm_test_drm_connector_dynamic_register_debugfs
[23:00:05] ========= [PASSED] drm_connector_dynamic_register ==========
[23:00:05] = drm_connector_attach_broadcast_rgb_property (2 subtests) =
[23:00:05] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property
[23:00:05] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector
[23:00:05] === [PASSED] drm_connector_attach_broadcast_rgb_property ===
[23:00:05] ========== drm_get_tv_mode_from_name (2 subtests) ==========
[23:00:05] ========== drm_test_get_tv_mode_from_name_valid  ===========
[23:00:05] [PASSED] NTSC
[23:00:05] [PASSED] NTSC-443
[23:00:05] [PASSED] NTSC-J
[23:00:05] [PASSED] PAL
[23:00:05] [PASSED] PAL-M
[23:00:05] [PASSED] PAL-N
[23:00:05] [PASSED] SECAM
[23:00:05] [PASSED] Mono
[23:00:05] ====== [PASSED] drm_test_get_tv_mode_from_name_valid =======
[23:00:05] [PASSED] drm_test_get_tv_mode_from_name_truncated
[23:00:05] ============ [PASSED] drm_get_tv_mode_from_name ============
[23:00:05] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) =
[23:00:05] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb
[23:00:05] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc
[23:00:05] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1
[23:00:05] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc
[23:00:05] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1
[23:00:05] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double
[23:00:05] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid  =
[23:00:05] [PASSED] VIC 96
[23:00:05] [PASSED] VIC 97
[23:00:05] [PASSED] VIC 101
[23:00:05] [PASSED] VIC 102
[23:00:05] [PASSED] VIC 106
[23:00:05] [PASSED] VIC 107
[23:00:05] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid ===
[23:00:05] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc
[23:00:05] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc
[23:00:05] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc
[23:00:05] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc
[23:00:05] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc
[23:00:05] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ====
[23:00:05] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) ==
[23:00:05] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name  ====
[23:00:05] [PASSED] Automatic
[23:00:05] [PASSED] Full
[23:00:05] [PASSED] Limited 16:235
[23:00:05] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name ===
[23:00:05] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid
[23:00:05] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ====
[23:00:05] == drm_hdmi_connector_get_output_format_name (2 subtests) ==
[23:00:05] === drm_test_drm_hdmi_connector_get_output_format_name  ====
[23:00:05] [PASSED] RGB
[23:00:05] [PASSED] YUV 4:2:0
[23:00:05] [PASSED] YUV 4:2:2
[23:00:05] [PASSED] YUV 4:4:4
[23:00:05] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name ===
[23:00:05] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid
[23:00:05] ==== [PASSED] drm_hdmi_connector_get_output_format_name ====
[23:00:05] ============= drm_damage_helper (21 subtests) ==============
[23:00:05] [PASSED] drm_test_damage_iter_no_damage
[23:00:05] [PASSED] drm_test_damage_iter_no_damage_fractional_src
[23:00:05] [PASSED] drm_test_damage_iter_no_damage_src_moved
[23:00:05] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved
[23:00:05] [PASSED] drm_test_damage_iter_no_damage_not_visible
[23:00:05] [PASSED] drm_test_damage_iter_no_damage_no_crtc
[23:00:05] [PASSED] drm_test_damage_iter_no_damage_no_fb
[23:00:05] [PASSED] drm_test_damage_iter_simple_damage
[23:00:05] [PASSED] drm_test_damage_iter_single_damage
[23:00:05] [PASSED] drm_test_damage_iter_single_damage_intersect_src
[23:00:05] [PASSED] drm_test_damage_iter_single_damage_outside_src
[23:00:05] [PASSED] drm_test_damage_iter_single_damage_fractional_src
[23:00:05] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src
[23:00:05] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src
[23:00:05] [PASSED] drm_test_damage_iter_single_damage_src_moved
[23:00:05] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved
[23:00:05] [PASSED] drm_test_damage_iter_damage
[23:00:05] [PASSED] drm_test_damage_iter_damage_one_intersect
[23:00:05] [PASSED] drm_test_damage_iter_damage_one_outside
[23:00:05] [PASSED] drm_test_damage_iter_damage_src_moved
[23:00:05] [PASSED] drm_test_damage_iter_damage_not_visible
[23:00:05] ================ [PASSED] drm_damage_helper ================
[23:00:05] ============== drm_dp_mst_helper (3 subtests) ==============
[23:00:05] ============== drm_test_dp_mst_calc_pbn_mode  ==============
[23:00:05] [PASSED] Clock 154000 BPP 30 DSC disabled
[23:00:05] [PASSED] Clock 234000 BPP 30 DSC disabled
[23:00:05] [PASSED] Clock 297000 BPP 24 DSC disabled
[23:00:05] [PASSED] Clock 332880 BPP 24 DSC enabled
[23:00:05] [PASSED] Clock 324540 BPP 24 DSC enabled
[23:00:05] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ==========
[23:00:05] ============== drm_test_dp_mst_calc_pbn_div  ===============
[23:00:05] [PASSED] Link rate 2000000 lane count 4
[23:00:05] [PASSED] Link rate 2000000 lane count 2
[23:00:05] [PASSED] Link rate 2000000 lane count 1
[23:00:05] [PASSED] Link rate 1350000 lane count 4
[23:00:05] [PASSED] Link rate 1350000 lane count 2
[23:00:05] [PASSED] Link rate 1350000 lane count 1
[23:00:05] [PASSED] Link rate 1000000 lane count 4
[23:00:05] [PASSED] Link rate 1000000 lane count 2
[23:00:05] [PASSED] Link rate 1000000 lane count 1
[23:00:05] [PASSED] Link rate 810000 lane count 4
[23:00:05] [PASSED] Link rate 810000 lane count 2
[23:00:05] [PASSED] Link rate 810000 lane count 1
[23:00:05] [PASSED] Link rate 540000 lane count 4
[23:00:05] [PASSED] Link rate 540000 lane count 2
[23:00:05] [PASSED] Link rate 540000 lane count 1
[23:00:05] [PASSED] Link rate 270000 lane count 4
[23:00:05] [PASSED] Link rate 270000 lane count 2
[23:00:05] [PASSED] Link rate 270000 lane count 1
[23:00:05] [PASSED] Link rate 162000 lane count 4
[23:00:05] [PASSED] Link rate 162000 lane count 2
[23:00:05] [PASSED] Link rate 162000 lane count 1
[23:00:05] ========== [PASSED] drm_test_dp_mst_calc_pbn_div ===========
[23:00:05] ========= drm_test_dp_mst_sideband_msg_req_decode  =========
[23:00:05] [PASSED] DP_ENUM_PATH_RESOURCES with port number
[23:00:05] [PASSED] DP_POWER_UP_PHY with port number
[23:00:05] [PASSED] DP_POWER_DOWN_PHY with port number
[23:00:05] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks
[23:00:05] [PASSED] DP_ALLOCATE_PAYLOAD with port number
[23:00:05] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI
[23:00:05] [PASSED] DP_ALLOCATE_PAYLOAD with PBN
[23:00:05] [PASSED] DP_QUERY_PAYLOAD with port number
[23:00:05] [PASSED] DP_QUERY_PAYLOAD with VCPI
[23:00:05] [PASSED] DP_REMOTE_DPCD_READ with port number
[23:00:05] [PASSED] DP_REMOTE_DPCD_READ with DPCD address
[23:00:05] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes
[23:00:05] [PASSED] DP_REMOTE_DPCD_WRITE with port number
[23:00:05] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address
[23:00:05] [PASSED] DP_REMOTE_DPCD_WRITE with data array
[23:00:05] [PASSED] DP_REMOTE_I2C_READ with port number
[23:00:05] [PASSED] DP_REMOTE_I2C_READ with I2C device ID
[23:00:05] [PASSED] DP_REMOTE_I2C_READ with transactions array
[23:00:05] [PASSED] DP_REMOTE_I2C_WRITE with port number
[23:00:05] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID
[23:00:05] [PASSED] DP_REMOTE_I2C_WRITE with data array
[23:00:05] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID
[23:00:05] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID
[23:00:05] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event
[23:00:05] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event
[23:00:05] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior
[23:00:05] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior
[23:00:05] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode =====
[23:00:05] ================ [PASSED] drm_dp_mst_helper ================
[23:00:05] ================== drm_exec (7 subtests) ===================
[23:00:05] [PASSED] sanitycheck
[23:00:05] [PASSED] test_lock
[23:00:05] [PASSED] test_lock_unlock
[23:00:05] [PASSED] test_duplicates
[23:00:05] [PASSED] test_prepare
[23:00:05] [PASSED] test_prepare_array
[23:00:05] [PASSED] test_multiple_loops
[23:00:05] ==================== [PASSED] drm_exec =====================
[23:00:05] =========== drm_format_helper_test (17 subtests) ===========
[23:00:05] ============== drm_test_fb_xrgb8888_to_gray8  ==============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ==========
[23:00:05] ============= drm_test_fb_xrgb8888_to_rgb332  ==============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ==========
[23:00:05] ============= drm_test_fb_xrgb8888_to_rgb565  ==============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ==========
[23:00:05] ============ drm_test_fb_xrgb8888_to_xrgb1555  =============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 =========
[23:00:05] ============ drm_test_fb_xrgb8888_to_argb1555  =============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 =========
[23:00:05] ============ drm_test_fb_xrgb8888_to_rgba5551  =============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 =========
[23:00:05] ============= drm_test_fb_xrgb8888_to_rgb888  ==============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ==========
[23:00:05] ============= drm_test_fb_xrgb8888_to_bgr888  ==============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ==========
[23:00:05] ============ drm_test_fb_xrgb8888_to_argb8888  =============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 =========
[23:00:05] =========== drm_test_fb_xrgb8888_to_xrgb2101010  ===========
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 =======
[23:00:05] =========== drm_test_fb_xrgb8888_to_argb2101010  ===========
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 =======
[23:00:05] ============== drm_test_fb_xrgb8888_to_mono  ===============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ========== [PASSED] drm_test_fb_xrgb8888_to_mono ===========
[23:00:05] ==================== drm_test_fb_swab  =====================
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ================ [PASSED] drm_test_fb_swab =================
[23:00:05] ============ drm_test_fb_xrgb8888_to_xbgr8888  =============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 =========
[23:00:05] ============ drm_test_fb_xrgb8888_to_abgr8888  =============
[23:00:05] [PASSED] single_pixel_source_buffer
[23:00:05] [PASSED] single_pixel_clip_rectangle
[23:00:05] [PASSED] well_known_colors
[23:00:05] [PASSED] destination_pitch
[23:00:05] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 =========
[23:00:05] ================= drm_test_fb_clip_offset  =================
[23:00:05] [PASSED] pass through
[23:00:05] [PASSED] horizontal offset
[23:00:05] [PASSED] vertical offset
[23:00:05] [PASSED] horizontal and vertical offset
[23:00:05] [PASSED] horizontal offset (custom pitch)
[23:00:05] [PASSED] vertical offset (custom pitch)
[23:00:05] [PASSED] horizontal and vertical offset (custom pitch)
[23:00:05] ============= [PASSED] drm_test_fb_clip_offset =============
[23:00:05] =================== drm_test_fb_memcpy  ====================
[23:00:05] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258)
[23:00:05] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258)
[23:00:05] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559)
[23:00:05] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258)
[23:00:05] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258)
[23:00:05] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559)
[23:00:05] [PASSED] well_known_colors: XB24 little-endian (0x34324258)
[23:00:05] [PASSED] well_known_colors: XRA8 little-endian (0x38415258)
[23:00:05] [PASSED] well_known_colors: YU24 little-endian (0x34325559)
[23:00:05] [PASSED] destination_pitch: XB24 little-endian (0x34324258)
[23:00:05] [PASSED] destination_pitch: XRA8 little-endian (0x38415258)
[23:00:05] [PASSED] destination_pitch: YU24 little-endian (0x34325559)
[23:00:05] =============== [PASSED] drm_test_fb_memcpy ================
[23:00:05] ============= [PASSED] drm_format_helper_test ==============
[23:00:05] ================= drm_format (18 subtests) =================
[23:00:05] [PASSED] drm_test_format_block_width_invalid
[23:00:05] [PASSED] drm_test_format_block_width_one_plane
[23:00:05] [PASSED] drm_test_format_block_width_two_plane
[23:00:05] [PASSED] drm_test_format_block_width_three_plane
[23:00:05] [PASSED] drm_test_format_block_width_tiled
[23:00:05] [PASSED] drm_test_format_block_height_invalid
[23:00:05] [PASSED] drm_test_format_block_height_one_plane
[23:00:05] [PASSED] drm_test_format_block_height_two_plane
[23:00:05] [PASSED] drm_test_format_block_height_three_plane
[23:00:05] [PASSED] drm_test_format_block_height_tiled
[23:00:05] [PASSED] drm_test_format_min_pitch_invalid
[23:00:05] [PASSED] drm_test_format_min_pitch_one_plane_8bpp
[23:00:05] [PASSED] drm_test_format_min_pitch_one_plane_16bpp
[23:00:05] [PASSED] drm_test_format_min_pitch_one_plane_24bpp
[23:00:05] [PASSED] drm_test_format_min_pitch_one_plane_32bpp
[23:00:05] [PASSED] drm_test_format_min_pitch_two_plane
[23:00:05] [PASSED] drm_test_format_min_pitch_three_plane_8bpp
[23:00:05] [PASSED] drm_test_format_min_pitch_tiled
[23:00:05] =================== [PASSED] drm_format ====================
[23:00:05] ============== drm_framebuffer (10 subtests) ===============
[23:00:05] ========== drm_test_framebuffer_check_src_coords  ==========
[23:00:05] [PASSED] Success: source fits into fb
[23:00:05] [PASSED] Fail: overflowing fb with x-axis coordinate
[23:00:05] [PASSED] Fail: overflowing fb with y-axis coordinate
[23:00:05] [PASSED] Fail: overflowing fb with source width
[23:00:05] [PASSED] Fail: overflowing fb with source height
[23:00:05] ====== [PASSED] drm_test_framebuffer_check_src_coords ======
[23:00:05] [PASSED] drm_test_framebuffer_cleanup
[23:00:05] =============== drm_test_framebuffer_create  ===============
[23:00:05] [PASSED] ABGR8888 normal sizes
[23:00:05] [PASSED] ABGR8888 max sizes
[23:00:05] [PASSED] ABGR8888 pitch greater than min required
[23:00:05] [PASSED] ABGR8888 pitch less than min required
[23:00:05] [PASSED] ABGR8888 Invalid width
[23:00:05] [PASSED] ABGR8888 Invalid buffer handle
[23:00:05] [PASSED] No pixel format
[23:00:05] [PASSED] ABGR8888 Width 0
[23:00:05] [PASSED] ABGR8888 Height 0
[23:00:05] [PASSED] ABGR8888 Out of bound height * pitch combination
[23:00:05] [PASSED] ABGR8888 Large buffer offset
[23:00:05] [PASSED] ABGR8888 Buffer offset for inexistent plane
[23:00:05] [PASSED] ABGR8888 Invalid flag
[23:00:05] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers
[23:00:05] [PASSED] ABGR8888 Valid buffer modifier
[23:00:05] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE)
[23:00:05] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS
[23:00:05] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS
[23:00:05] [PASSED] NV12 Normal sizes
[23:00:05] [PASSED] NV12 Max sizes
[23:00:05] [PASSED] NV12 Invalid pitch
[23:00:05] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag
[23:00:05] [PASSED] NV12 different  modifier per-plane
[23:00:05] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE
[23:00:05] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS
[23:00:05] [PASSED] NV12 Modifier for inexistent plane
[23:00:05] [PASSED] NV12 Handle for inexistent plane
[23:00:05] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS
[23:00:05] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier
[23:00:05] [PASSED] YVU420 Normal sizes
[23:00:05] [PASSED] YVU420 Max sizes
[23:00:05] [PASSED] YVU420 Invalid pitch
[23:00:05] [PASSED] YVU420 Different pitches
[23:00:05] [PASSED] YVU420 Different buffer offsets/pitches
[23:00:05] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS
[23:00:05] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS
[23:00:05] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS
[23:00:05] [PASSED] YVU420 Valid modifier
[23:00:05] [PASSED] YVU420 Different modifiers per plane
[23:00:05] [PASSED] YVU420 Modifier for inexistent plane
[23:00:05] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR)
[23:00:05] [PASSED] X0L2 Normal sizes
[23:00:05] [PASSED] X0L2 Max sizes
[23:00:05] [PASSED] X0L2 Invalid pitch
[23:00:05] [PASSED] X0L2 Pitch greater than minimum required
[23:00:05] [PASSED] X0L2 Handle for inexistent plane
[23:00:05] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set
[23:00:05] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set
[23:00:05] [PASSED] X0L2 Valid modifier
[23:00:05] [PASSED] X0L2 Modifier for inexistent plane
[23:00:05] =========== [PASSED] drm_test_framebuffer_create ===========
[23:00:05] [PASSED] drm_test_framebuffer_free
[23:00:05] [PASSED] drm_test_framebuffer_init
[23:00:05] [PASSED] drm_test_framebuffer_init_bad_format
[23:00:05] [PASSED] drm_test_framebuffer_init_dev_mismatch
[23:00:05] [PASSED] drm_test_framebuffer_lookup
[23:00:05] [PASSED] drm_test_framebuffer_lookup_inexistent
[23:00:05] [PASSED] drm_test_framebuffer_modifiers_not_supported
[23:00:05] ================= [PASSED] drm_framebuffer =================
[23:00:05] ================ drm_gem_shmem (8 subtests) ================
[23:00:05] [PASSED] drm_gem_shmem_test_obj_create
[23:00:05] [PASSED] drm_gem_shmem_test_obj_create_private
[23:00:05] [PASSED] drm_gem_shmem_test_pin_pages
[23:00:05] [PASSED] drm_gem_shmem_test_vmap
[23:00:05] [PASSED] drm_gem_shmem_test_get_sg_table
[23:00:05] [PASSED] drm_gem_shmem_test_get_pages_sgt
[23:00:05] [PASSED] drm_gem_shmem_test_madvise
[23:00:05] [PASSED] drm_gem_shmem_test_purge
[23:00:05] ================== [PASSED] drm_gem_shmem ==================
[23:00:05] === drm_atomic_helper_connector_hdmi_check (27 subtests) ===
[23:00:05] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode
[23:00:05] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1
[23:00:05] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode
[23:00:05] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1
[23:00:05] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode
[23:00:05] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1
[23:00:05] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420  =======
[23:00:05] [PASSED] Automatic
[23:00:05] [PASSED] Full
[23:00:05] [PASSED] Limited 16:235
[23:00:05] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 ===
[23:00:05] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed
[23:00:05] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed
[23:00:05] [PASSED] drm_test_check_disable_connector
[23:00:05] [PASSED] drm_test_check_hdmi_funcs_reject_rate
[23:00:05] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb
[23:00:05] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420
[23:00:05] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422
[23:00:05] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420
[23:00:05] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420
[23:00:05] [PASSED] drm_test_check_output_bpc_crtc_mode_changed
[23:00:05] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed
[23:00:05] [PASSED] drm_test_check_output_bpc_dvi
[23:00:05] [PASSED] drm_test_check_output_bpc_format_vic_1
[23:00:05] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only
[23:00:05] [PASSED] drm_test_check_output_bpc_format_display_rgb_only
[23:00:05] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only
[23:00:05] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only
[23:00:05] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc
[23:00:05] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc
[23:00:05] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc
[23:00:05] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ======
[23:00:05] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ====
[23:00:05] [PASSED] drm_test_check_broadcast_rgb_value
[23:00:05] [PASSED] drm_test_check_bpc_8_value
[23:00:05] [PASSED] drm_test_check_bpc_10_value
[23:00:05] [PASSED] drm_test_check_bpc_12_value
[23:00:05] [PASSED] drm_test_check_format_value
[23:00:05] [PASSED] drm_test_check_tmds_char_value
[23:00:05] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ======
[23:00:05] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) =
[23:00:05] [PASSED] drm_test_check_mode_valid
[23:00:05] [PASSED] drm_test_check_mode_valid_reject
[23:00:05] [PASSED] drm_test_check_mode_valid_reject_rate
[23:00:05] [PASSED] drm_test_check_mode_valid_reject_max_clock
[23:00:05] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid ===
[23:00:05] = drm_atomic_helper_connector_hdmi_infoframes (5 subtests) =
[23:00:05] [PASSED] drm_test_check_infoframes
[23:00:05] [PASSED] drm_test_check_reject_avi_infoframe
[23:00:05] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_8
[23:00:05] [PASSED] drm_test_check_reject_hdr_infoframe_bpc_10
[23:00:05] [PASSED] drm_test_check_reject_audio_infoframe
[23:00:05] === [PASSED] drm_atomic_helper_connector_hdmi_infoframes ===
[23:00:05] ================= drm_managed (2 subtests) =================
[23:00:05] [PASSED] drm_test_managed_release_action
[23:00:05] [PASSED] drm_test_managed_run_action
[23:00:05] =================== [PASSED] drm_managed ===================
[23:00:05] =================== drm_mm (6 subtests) ====================
[23:00:05] [PASSED] drm_test_mm_init
[23:00:05] [PASSED] drm_test_mm_debug
[23:00:05] [PASSED] drm_test_mm_align32
[23:00:05] [PASSED] drm_test_mm_align64
[23:00:05] [PASSED] drm_test_mm_lowest
[23:00:05] [PASSED] drm_test_mm_highest
[23:00:05] ===================== [PASSED] drm_mm ======================
[23:00:05] ============= drm_modes_analog_tv (5 subtests) =============
[23:00:05] [PASSED] drm_test_modes_analog_tv_mono_576i
[23:00:05] [PASSED] drm_test_modes_analog_tv_ntsc_480i
[23:00:05] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined
[23:00:05] [PASSED] drm_test_modes_analog_tv_pal_576i
[23:00:05] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined
[23:00:05] =============== [PASSED] drm_modes_analog_tv ===============
[23:00:05] ============== drm_plane_helper (2 subtests) ===============
[23:00:05] =============== drm_test_check_plane_state  ================
[23:00:05] [PASSED] clipping_simple
[23:00:05] [PASSED] clipping_rotate_reflect
[23:00:05] [PASSED] positioning_simple
[23:00:05] [PASSED] upscaling
[23:00:05] [PASSED] downscaling
[23:00:05] [PASSED] rounding1
[23:00:05] [PASSED] rounding2
[23:00:05] [PASSED] rounding3
[23:00:05] [PASSED] rounding4
[23:00:05] =========== [PASSED] drm_test_check_plane_state ============
[23:00:05] =========== drm_test_check_invalid_plane_state  ============
[23:00:05] [PASSED] positioning_invalid
[23:00:05] [PASSED] upscaling_invalid
[23:00:05] [PASSED] downscaling_invalid
[23:00:05] ======= [PASSED] drm_test_check_invalid_plane_state ========
[23:00:05] ================ [PASSED] drm_plane_helper =================
[23:00:05] ====== drm_connector_helper_tv_get_modes (1 subtest) =======
[23:00:05] ====== drm_test_connector_helper_tv_get_modes_check  =======
[23:00:05] [PASSED] None
[23:00:05] [PASSED] PAL
[23:00:05] [PASSED] NTSC
[23:00:05] [PASSED] Both, NTSC Default
[23:00:05] [PASSED] Both, PAL Default
[23:00:05] [PASSED] Both, NTSC Default, with PAL on command-line
[23:00:05] [PASSED] Both, PAL Default, with NTSC on command-line
[23:00:05] == [PASSED] drm_test_connector_helper_tv_get_modes_check ===
[23:00:05] ======== [PASSED] drm_connector_helper_tv_get_modes ========
[23:00:05] ================== drm_rect (9 subtests) ===================
[23:00:05] [PASSED] drm_test_rect_clip_scaled_div_by_zero
[23:00:05] [PASSED] drm_test_rect_clip_scaled_not_clipped
[23:00:05] [PASSED] drm_test_rect_clip_scaled_clipped
[23:00:05] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned
[23:00:05] ================= drm_test_rect_intersect  =================
[23:00:05] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0
[23:00:05] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1
[23:00:05] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0
[23:00:05] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1
[23:00:05] [PASSED] right x left: 2x1+0+0 x 3x1+1+0
[23:00:05] [PASSED] left x right: 3x1+1+0 x 2x1+0+0
[23:00:05] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1
[23:00:05] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0
[23:00:05] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1
[23:00:05] [PASSED] touching side: 1x1+0+0 x 1x1+1+0
[23:00:05] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0
[23:00:05] [PASSED] inside another: 2x2+0+0 x 1x1+1+1
[23:00:05] [PASSED] far away: 1x1+0+0 x 1x1+3+6
[23:00:05] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10
[23:00:05] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10
[23:00:05] ============= [PASSED] drm_test_rect_intersect =============
[23:00:05] ================ drm_test_rect_calc_hscale  ================
[23:00:05] [PASSED] normal use
[23:00:05] [PASSED] out of max range
[23:00:05] [PASSED] out of min range
[23:00:05] [PASSED] zero dst
[23:00:05] [PASSED] negative src
[23:00:05] [PASSED] negative dst
[23:00:05] ============ [PASSED] drm_test_rect_calc_hscale ============
[23:00:05] ================ drm_test_rect_calc_vscale  ================
[23:00:05] [PASSED] normal use
[23:00:05] [PASSED] out of max range
[23:00:05] [PASSED] out of min range
[23:00:05] [PASSED] zero dst
[23:00:05] [PASSED] negative src
[23:00:05] [PASSED] negative dst
stty: 'standard input': Inappropriate ioctl for device
[23:00:05] ============ [PASSED] drm_test_rect_calc_vscale ============
[23:00:05] ================== drm_test_rect_rotate  ===================
[23:00:05] [PASSED] reflect-x
[23:00:05] [PASSED] reflect-y
[23:00:05] [PASSED] rotate-0
[23:00:05] [PASSED] rotate-90
[23:00:05] [PASSED] rotate-180
[23:00:05] [PASSED] rotate-270
[23:00:05] ============== [PASSED] drm_test_rect_rotate ===============
[23:00:05] ================ drm_test_rect_rotate_inv  =================
[23:00:05] [PASSED] reflect-x
[23:00:05] [PASSED] reflect-y
[23:00:05] [PASSED] rotate-0
[23:00:05] [PASSED] rotate-90
[23:00:05] [PASSED] rotate-180
[23:00:05] [PASSED] rotate-270
[23:00:05] ============ [PASSED] drm_test_rect_rotate_inv =============
[23:00:05] ==================== [PASSED] drm_rect =====================
[23:00:05] ============ drm_sysfb_modeset_test (1 subtest) ============
[23:00:05] ============ drm_test_sysfb_build_fourcc_list  =============
[23:00:05] [PASSED] no native formats
[23:00:05] [PASSED] XRGB8888 as native format
[23:00:05] [PASSED] remove duplicates
[23:00:05] [PASSED] convert alpha formats
[23:00:05] [PASSED] random formats
[23:00:05] ======== [PASSED] drm_test_sysfb_build_fourcc_list =========
[23:00:05] ============= [PASSED] drm_sysfb_modeset_test ==============
[23:00:05] ================== drm_fixp (2 subtests) ===================
[23:00:05] [PASSED] drm_test_int2fixp
[23:00:05] [PASSED] drm_test_sm2fixp
[23:00:05] ==================== [PASSED] drm_fixp =====================
[23:00:05] ============================================================
[23:00:05] Testing complete. Ran 621 tests: passed: 621
[23:00:05] Elapsed time: 26.306s total, 1.703s configuring, 24.434s building, 0.135s running

+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [23:00:05] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:

$ make ARCH=um O=.kunit olddefconfig
[23:00:07] Building KUnit Kernel ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig
Building with:
$ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48
[23:00:16] Starting KUnit Kernel (1/1)...
[23:00:16] ============================================================
Running tests with:
$ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt
[23:00:17] ================= ttm_device (5 subtests) ==================
[23:00:17] [PASSED] ttm_device_init_basic
[23:00:17] [PASSED] ttm_device_init_multiple
[23:00:17] [PASSED] ttm_device_fini_basic
[23:00:17] [PASSED] ttm_device_init_no_vma_man
[23:00:17] ================== ttm_device_init_pools  ==================
[23:00:17] [PASSED] No DMA allocations, no DMA32 required
[23:00:17] [PASSED] DMA allocations, DMA32 required
[23:00:17] [PASSED] No DMA allocations, DMA32 required
[23:00:17] [PASSED] DMA allocations, no DMA32 required
[23:00:17] ============== [PASSED] ttm_device_init_pools ==============
[23:00:17] =================== [PASSED] ttm_device ====================
[23:00:17] ================== ttm_pool (8 subtests) ===================
[23:00:17] ================== ttm_pool_alloc_basic  ===================
[23:00:17] [PASSED] One page
[23:00:17] [PASSED] More than one page
[23:00:17] [PASSED] Above the allocation limit
[23:00:17] [PASSED] One page, with coherent DMA mappings enabled
[23:00:17] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[23:00:17] ============== [PASSED] ttm_pool_alloc_basic ===============
[23:00:17] ============== ttm_pool_alloc_basic_dma_addr  ==============
[23:00:17] [PASSED] One page
[23:00:17] [PASSED] More than one page
[23:00:17] [PASSED] Above the allocation limit
[23:00:17] [PASSED] One page, with coherent DMA mappings enabled
[23:00:17] [PASSED] Above the allocation limit, with coherent DMA mappings enabled
[23:00:17] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ==========
[23:00:17] [PASSED] ttm_pool_alloc_order_caching_match
[23:00:17] [PASSED] ttm_pool_alloc_caching_mismatch
[23:00:17] [PASSED] ttm_pool_alloc_order_mismatch
[23:00:17] [PASSED] ttm_pool_free_dma_alloc
[23:00:17] [PASSED] ttm_pool_free_no_dma_alloc
[23:00:17] [PASSED] ttm_pool_fini_basic
[23:00:17] ==================== [PASSED] ttm_pool =====================
[23:00:17] ================ ttm_resource (8 subtests) =================
[23:00:17] ================= ttm_resource_init_basic  =================
[23:00:17] [PASSED] Init resource in TTM_PL_SYSTEM
[23:00:17] [PASSED] Init resource in TTM_PL_VRAM
[23:00:17] [PASSED] Init resource in a private placement
[23:00:17] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags
[23:00:17] ============= [PASSED] ttm_resource_init_basic =============
[23:00:17] [PASSED] ttm_resource_init_pinned
[23:00:17] [PASSED] ttm_resource_fini_basic
[23:00:17] [PASSED] ttm_resource_manager_init_basic
[23:00:17] [PASSED] ttm_resource_manager_usage_basic
[23:00:17] [PASSED] ttm_resource_manager_set_used_basic
[23:00:17] [PASSED] ttm_sys_man_alloc_basic
[23:00:17] [PASSED] ttm_sys_man_free_basic
[23:00:17] ================== [PASSED] ttm_resource ===================
[23:00:17] =================== ttm_tt (15 subtests) ===================
[23:00:17] ==================== ttm_tt_init_basic  ====================
[23:00:17] [PASSED] Page-aligned size
[23:00:17] [PASSED] Extra pages requested
[23:00:17] ================ [PASSED] ttm_tt_init_basic ================
[23:00:17] [PASSED] ttm_tt_init_misaligned
[23:00:17] [PASSED] ttm_tt_fini_basic
[23:00:17] [PASSED] ttm_tt_fini_sg
[23:00:17] [PASSED] ttm_tt_fini_shmem
[23:00:17] [PASSED] ttm_tt_create_basic
[23:00:17] [PASSED] ttm_tt_create_invalid_bo_type
[23:00:17] [PASSED] ttm_tt_create_ttm_exists
[23:00:17] [PASSED] ttm_tt_create_failed
[23:00:17] [PASSED] ttm_tt_destroy_basic
[23:00:17] [PASSED] ttm_tt_populate_null_ttm
[23:00:17] [PASSED] ttm_tt_populate_populated_ttm
[23:00:17] [PASSED] ttm_tt_unpopulate_basic
[23:00:17] [PASSED] ttm_tt_unpopulate_empty_ttm
[23:00:17] [PASSED] ttm_tt_swapin_basic
[23:00:17] ===================== [PASSED] ttm_tt ======================
[23:00:17] =================== ttm_bo (14 subtests) ===================
[23:00:17] =========== ttm_bo_reserve_optimistic_no_ticket  ===========
[23:00:17] [PASSED] Cannot be interrupted and sleeps
[23:00:17] [PASSED] Cannot be interrupted, locks straight away
[23:00:17] [PASSED] Can be interrupted, sleeps
[23:00:17] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket =======
[23:00:17] [PASSED] ttm_bo_reserve_locked_no_sleep
[23:00:17] [PASSED] ttm_bo_reserve_no_wait_ticket
[23:00:17] [PASSED] ttm_bo_reserve_double_resv
[23:00:17] [PASSED] ttm_bo_reserve_interrupted
[23:00:17] [PASSED] ttm_bo_reserve_deadlock
[23:00:17] [PASSED] ttm_bo_unreserve_basic
[23:00:17] [PASSED] ttm_bo_unreserve_pinned
[23:00:17] [PASSED] ttm_bo_unreserve_bulk
[23:00:17] [PASSED] ttm_bo_fini_basic
[23:00:17] [PASSED] ttm_bo_fini_shared_resv
[23:00:17] [PASSED] ttm_bo_pin_basic
[23:00:17] [PASSED] ttm_bo_pin_unpin_resource
[23:00:17] [PASSED] ttm_bo_multiple_pin_one_unpin
[23:00:17] ===================== [PASSED] ttm_bo ======================
[23:00:17] ============== ttm_bo_validate (22 subtests) ===============
[23:00:17] ============== ttm_bo_init_reserved_sys_man  ===============
[23:00:17] [PASSED] Buffer object for userspace
[23:00:17] [PASSED] Kernel buffer object
[23:00:17] [PASSED] Shared buffer object
[23:00:17] ========== [PASSED] ttm_bo_init_reserved_sys_man ===========
[23:00:17] ============== ttm_bo_init_reserved_mock_man  ==============
[23:00:17] [PASSED] Buffer object for userspace
[23:00:17] [PASSED] Kernel buffer object
[23:00:17] [PASSED] Shared buffer object
[23:00:17] ========== [PASSED] ttm_bo_init_reserved_mock_man ==========
[23:00:17] [PASSED] ttm_bo_init_reserved_resv
[23:00:17] ================== ttm_bo_validate_basic  ==================
[23:00:17] [PASSED] Buffer object for userspace
[23:00:17] [PASSED] Kernel buffer object
[23:00:17] [PASSED] Shared buffer object
[23:00:17] ============== [PASSED] ttm_bo_validate_basic ==============
[23:00:17] [PASSED] ttm_bo_validate_invalid_placement
[23:00:17] ============= ttm_bo_validate_same_placement  ==============
[23:00:17] [PASSED] System manager
[23:00:17] [PASSED] VRAM manager
[23:00:17] ========= [PASSED] ttm_bo_validate_same_placement ==========
[23:00:17] [PASSED] ttm_bo_validate_failed_alloc
[23:00:17] [PASSED] ttm_bo_validate_pinned
[23:00:17] [PASSED] ttm_bo_validate_busy_placement
[23:00:17] ================ ttm_bo_validate_multihop  =================
[23:00:17] [PASSED] Buffer object for userspace
[23:00:17] [PASSED] Kernel buffer object
[23:00:17] [PASSED] Shared buffer object
[23:00:17] ============ [PASSED] ttm_bo_validate_multihop =============
[23:00:17] ========== ttm_bo_validate_no_placement_signaled  ==========
[23:00:17] [PASSED] Buffer object in system domain, no page vector
[23:00:17] [PASSED] Buffer object in system domain with an existing page vector
[23:00:17] ====== [PASSED] ttm_bo_validate_no_placement_signaled ======
[23:00:17] ======== ttm_bo_validate_no_placement_not_signaled  ========
[23:00:17] [PASSED] Buffer object for userspace
[23:00:17] [PASSED] Kernel buffer object
[23:00:17] [PASSED] Shared buffer object
[23:00:17] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ====
[23:00:17] [PASSED] ttm_bo_validate_move_fence_signaled
[23:00:17] ========= ttm_bo_validate_move_fence_not_signaled  =========
[23:00:17] [PASSED] Waits for GPU
[23:00:17] [PASSED] Tries to lock straight away
[23:00:17] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled =====
[23:00:17] [PASSED] ttm_bo_validate_swapout
[23:00:17] [PASSED] ttm_bo_validate_happy_evict
[23:00:17] [PASSED] ttm_bo_validate_all_pinned_evict
[23:00:17] [PASSED] ttm_bo_validate_allowed_only_evict
[23:00:17] [PASSED] ttm_bo_validate_deleted_evict
[23:00:17] [PASSED] ttm_bo_validate_busy_domain_evict
[23:00:17] [PASSED] ttm_bo_validate_evict_gutting
[23:00:17] [PASSED] ttm_bo_validate_recrusive_evict
stty: 'standard input': Inappropriate ioctl for device
[23:00:17] ================= [PASSED] ttm_bo_validate =================
[23:00:17] ============================================================
[23:00:17] Testing complete. Ran 102 tests: passed: 102
[23:00:17] Elapsed time: 11.257s total, 1.734s configuring, 9.307s building, 0.188s running

+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel

#2 lore raw

✓ Xe.CI.BAT: success for drm/xe/guc: Add support for NPK as a GuC log target (rev3)

In reply to Stuart Summers
== Series Details ==

== Series Details ==

Series: drm/xe/guc: Add support for NPK as a GuC log target (rev3)
URL : https://patchwork.freedesktop.org/series/162087/
State : success

== Summary ==

CI Bug Log - changes from xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688_BAT -> xe-pw-162087v3_BAT
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (13 -> 13)
------------------------------

No changes in participating hosts

Changes
-------

No changes found

Build changes
-------------

* Linux: xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688 -> xe-pw-162087v3

IGT_8849: 8849
xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688: 7b7217a9e27a82ef10be22ab3a55ad5bbc849688
xe-pw-162087v3: 162087v3

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/index.html

#3 lore raw

✓ Xe.CI.FULL: success for drm/xe/guc: Add support for NPK as a GuC log target (rev3)

In reply to Stuart Summers
== Series Details ==

== Series Details ==

Series: drm/xe/guc: Add support for NPK as a GuC log target (rev3)
URL : https://patchwork.freedesktop.org/series/162087/
State : success

== Summary ==

CI Bug Log - changes from xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688_FULL -> xe-pw-162087v3_FULL
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (2 -> 2)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in xe-pw-162087v3_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- shard-bmg: NOTRUN -> [SKIP][1] ([Intel XE#2233])
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@kms_big_fb@linear-max-hw-stride-32bpp-rotate-0-hflip:
- shard-bmg: NOTRUN -> [SKIP][2] ([Intel XE#7059] / [Intel XE#7085]) +1 other test skip
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-bmg: NOTRUN -> [SKIP][3] ([Intel XE#1124])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@kms_ccs@bad-aux-stride-yf-tiled-ccs:
- shard-bmg: NOTRUN -> [SKIP][4] ([Intel XE#2887]) +2 other tests skip
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-rc-ccs-cc:
- shard-bmg: NOTRUN -> [SKIP][5] ([Intel XE#3432]) +1 other test skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@kms_chamelium_audio@hdmi-audio-edid:
- shard-bmg: NOTRUN -> [SKIP][6] ([Intel XE#2252]) +2 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@kms_content_protection@dp-mst-type-0:
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#2390] / [Intel XE#6974])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@kms_content_protection@srm@pipe-a-dp-2:
- shard-bmg: NOTRUN -> [FAIL][8] ([Intel XE#1178] / [Intel XE#3304] / [Intel XE#7374]) +1 other test fail
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@kms_content_protection@[email protected]

* igt@kms_cursor_crc@cursor-sliding-128x42:
- shard-bmg: NOTRUN -> [SKIP][9] ([Intel XE#2320])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@kms_cursor_crc@cursor-sliding-512x512:
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#2321] / [Intel XE#7355])
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@[email protected]

* igt@kms_dirtyfb@drrs-dirtyfb-ioctl:
- shard-bmg: NOTRUN -> [SKIP][11] ([Intel XE#1508])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@kms_dsc@dsc-with-output-formats:
- shard-bmg: NOTRUN -> [SKIP][12] ([Intel XE#2244])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-lnl: [PASS][13] -> [FAIL][14] ([Intel XE#301]) +1 other test fail
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-lnl-1/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-lnl-3/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling:
- shard-bmg: NOTRUN -> [SKIP][15] ([Intel XE#7178] / [Intel XE#7349])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling.html

* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling:
- shard-bmg: NOTRUN -> [SKIP][16] ([Intel XE#7178] / [Intel XE#7351])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling.html

* igt@kms_flip_scaled_crc@flip-nv12-linear-to-nv12-linear-reflect-x:
- shard-bmg: NOTRUN -> [SKIP][17] ([Intel XE#7179]) +1 other test skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@kms_flip_scaled_crc@flip-nv12-linear-to-nv12-linear-reflect-x.html

* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-draw-render:
- shard-bmg: NOTRUN -> [SKIP][18] ([Intel XE#2311]) +6 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][19] ([Intel XE#4141]) +5 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-5/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-onoff:
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#2313]) +3 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-abgr161616f-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][21] ([Intel XE#7061] / [Intel XE#7356]) +2 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-5/igt@[email protected]

* igt@kms_hdr@invalid-hdr:
- shard-bmg: [PASS][22] -> [SKIP][23] ([Intel XE#1503])
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-bmg-7/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@[email protected]

* igt@kms_joiner@invalid-modeset-ultra-joiner:
- shard-bmg: NOTRUN -> [SKIP][24] ([Intel XE#6911] / [Intel XE#7378])
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@[email protected]

* igt@kms_plane@pixel-format-y-tiled-ccs-modifier:
- shard-bmg: NOTRUN -> [SKIP][25] ([Intel XE#7283])
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@[email protected]

* igt@kms_pm_backlight@fade-with-dpms:
- shard-bmg: NOTRUN -> [SKIP][26] ([Intel XE#7376] / [Intel XE#870])
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-bmg: NOTRUN -> [SKIP][27] ([Intel XE#1439] / [Intel XE#3141] / [Intel XE#7383] / [Intel XE#836])
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@kms_psr2_sf@fbc-pr-primary-plane-update-sf-dmg-area:
- shard-bmg: NOTRUN -> [SKIP][28] ([Intel XE#1489]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@kms_psr@fbc-psr2-basic:
- shard-bmg: NOTRUN -> [SKIP][29] ([Intel XE#2234] / [Intel XE#2850]) +4 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@[email protected]

* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-bmg: NOTRUN -> [SKIP][30] ([Intel XE#1406] / [Intel XE#2414])
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@kms_rotation_crc@bad-pixel-format:
- shard-bmg: NOTRUN -> [SKIP][31] ([Intel XE#3904] / [Intel XE#7342])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@kms_sharpness_filter@invalid-filter-with-plane:
- shard-bmg: NOTRUN -> [SKIP][32] ([Intel XE#6503])
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@kms_vrr@flip-suspend:
- shard-bmg: NOTRUN -> [SKIP][33] ([Intel XE#1499])
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

* igt@xe_eudebug@vma-ufence-faultable:
- shard-bmg: NOTRUN -> [SKIP][34] ([Intel XE#7636]) +1 other test skip
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@[email protected]

* igt@xe_eudebug_sriov@deny-sriov:
- shard-bmg: NOTRUN -> [SKIP][35] ([Intel XE#5793] / [Intel XE#7320] / [Intel XE#7464])
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@xe_evict@evict-mixed-many-threads-small:
- shard-bmg: [PASS][36] -> [INCOMPLETE][37] ([Intel XE#6321])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-bmg-5/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-5/igt@[email protected]

* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-userptr-invalidate:
- shard-bmg: NOTRUN -> [SKIP][38] ([Intel XE#2322] / [Intel XE#7372]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-userptr-invalidate.html

* igt@xe_exec_fault_mode@many-multi-queue-userptr-invalidate-race-prefetch:
- shard-bmg: NOTRUN -> [SKIP][39] ([Intel XE#7136]) +3 other tests skip
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@xe_exec_fault_mode@many-multi-queue-userptr-invalidate-race-prefetch.html

* igt@xe_exec_multi_queue@one-queue-preempt-mode-fault-userptr:
- shard-bmg: NOTRUN -> [SKIP][40] ([Intel XE#6874]) +6 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@[email protected]

* igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma:
- shard-lnl: ([PASS][41], [PASS][42]) -> [FAIL][43] ([Intel XE#5625])
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-lnl-6/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma.html
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-lnl-4/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma.html
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-lnl-2/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-multi-vma.html

* igt@xe_exec_threads@threads-multi-queue-mixed-fd-userptr:
- shard-bmg: NOTRUN -> [SKIP][44] ([Intel XE#7138]) +2 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@xe_pm@s2idle-d3cold-basic-exec:
- shard-bmg: NOTRUN -> [SKIP][45] ([Intel XE#2284] / [Intel XE#7370])
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-9/igt@[email protected]

#### Possible fixes ####

* igt@kms_async_flips@async-flip-dpms:
- shard-bmg: [INCOMPLETE][46] ([Intel XE#4912]) -> [PASS][47] +1 other test pass
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-bmg-5/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-5/igt@[email protected]

* igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs:
- shard-bmg: [INCOMPLETE][48] ([Intel XE#7084]) -> [PASS][49] +1 other test pass
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-bmg-10/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-7/igt@[email protected]

* igt@kms_flip@2x-dpms-vs-vblank-race:
- shard-bmg: [INCOMPLETE][50] -> [PASS][51] +1 other test pass
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-bmg-2/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-2/igt@[email protected]

* igt@kms_vrr@seamless-rr-switch-virtual@pipe-a-edp-1:
- shard-lnl: [FAIL][52] ([Intel XE#2142]) -> [PASS][53] +1 other test pass
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-lnl-6/igt@kms_vrr@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-lnl-7/igt@kms_vrr@[email protected]

* igt@xe_evict@evict-beng-mixed-many-threads-small:
- shard-bmg: ([INCOMPLETE][54], [INCOMPLETE][55]) ([Intel XE#6321]) -> [PASS][56]
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-bmg-5/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-bmg-1/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-bmg-6/igt@[email protected]

* igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma:
- shard-lnl: [FAIL][57] ([Intel XE#5625]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688/shard-lnl-2/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/shard-lnl-7/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html

[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1439]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1439
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1499
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#1508]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1508
[Intel XE#2142]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2142
[Intel XE#2233]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2233
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2244]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2244
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2284]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2284
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2321
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2390
[Intel XE#2414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2414
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#3141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3141
[Intel XE#3304]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3304
[Intel XE#3432]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3432
[Intel XE#3904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3904
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#4912]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4912
[Intel XE#5625]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5625
[Intel XE#5793]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5793
[Intel XE#6321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6321
[Intel XE#6503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6503
[Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
[Intel XE#6911]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6911
[Intel XE#6974]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6974
[Intel XE#7059]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7059
[Intel XE#7061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7061
[Intel XE#7084]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7084
[Intel XE#7085]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7085
[Intel XE#7136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7136
[Intel XE#7138]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7138
[Intel XE#7178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7178
[Intel XE#7179]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7179
[Intel XE#7283]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7283
[Intel XE#7320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7320
[Intel XE#7342]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7342
[Intel XE#7349]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7349
[Intel XE#7351]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7351
[Intel XE#7355]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7355
[Intel XE#7356]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7356
[Intel XE#7370]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7370
[Intel XE#7372]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7372
[Intel XE#7374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7374
[Intel XE#7376]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7376
[Intel XE#7378]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7378
[Intel XE#7383]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7383
[Intel XE#7464]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7464
[Intel XE#7636]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7636
[Intel XE#836]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/836
[Intel XE#870]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/870

Build changes
-------------

* Linux: xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688 -> xe-pw-162087v3

IGT_8849: 8849
xe-4853-7b7217a9e27a82ef10be22ab3a55ad5bbc849688: 7b7217a9e27a82ef10be22ab3a55ad5bbc849688
xe-pw-162087v3: 162087v3

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-162087v3/index.html

#4 lore raw
In reply to Stuart Summers
Quoted 6 lines · Stuart Summers

From: John Harrison <[email protected]>

GuC provides the ability to gather logs through a hardware interface called NPK. For certain debugging scenarios this can be advantageous over getting logs from memory (or in addition to).

Quoted 7 lines

Add a hook for this alternate debugging mode via a configfs. This translates into a parameter passed to GuC during load time.

v2: Convert to configfs from modparam (Matt)
v3: Configfs documentation formatting (Shuicheng)
Kerneldoc/comment add + configfs entry ordering Only set the guc_log_target when GuC log is enabled (Daniele)

nit: we may keep change log under --- so it stays on the ML only

and please not forget to use -v option while preparing new patch revisions

[1] https://git-scm.com/docs/git-format-patch#Documentation/git-format-patch.txt--vn

Quoted 49 lines
---
 drivers/gpu/drm/xe/xe_configfs.c | 70 ++++++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_configfs.h |  5 +++
 drivers/gpu/drm/xe/xe_defaults.h |  1 +
 drivers/gpu/drm/xe/xe_guc.c      | 11 +++--
 4 files changed, 84 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_configfs.c +12 -0
index 32102600a148..e4511ee4e135 100644
@@ -83,6 +83,16 @@
  *
  * This attribute can only be set before binding to the device.
  *
+ * GuC log target:
+ * ---------------
+ *
+ * Set the destination for the GuC log. 0 - memory only (default),
+ * 1 - NPK only, 2 - memory + NPK. Example::
+ *
+ *	# echo 2 > /sys/kernel/config/xe/0000:03:00.0/guc_log_target
+ *
+ * This attribute can only be set before binding to the device.
+ *
  * Allowed GT types:
  * -----------------
  *
@@ -256,6 +266,7 @@ struct xe_config_group_device {
 	struct config_group sriov;
 
 	struct xe_config_device {
+		u8 guc_log_target;
 		u64 gt_types_allowed;
 		u64 engines_allowed;
 		struct wa_bb ctx_restore_post_bb[XE_ENGINE_CLASS_MAX];
@@ -277,6 +288,7 @@ struct xe_config_group_device {
 };
 
 static const struct xe_config_device device_defaults = {
+	.guc_log_target = XE_DEFAULT_GUC_LOG_TARGET,
 	.gt_types_allowed = U64_MAX,
 	.engines_allowed = U64_MAX,
 	.survivability_mode = false,

drivers/gpu/drm/xe/xe_configfs.c static bool is_bound(struct xe_config_group_device *dev) · line 371

Quoted 3 lines
drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -357,6 +369,41 @@ static bool is_bound(struct xe_config_group_device *dev)
 	return ret;
 }
 

can we expose this new attribute only for XE_DEBUG_GUC config? we can easily use xe_config_device_is_visible for this

Quoted 12 lines
drivers/gpu/drm/xe/xe_configfs.c +12 -0
+static ssize_t guc_log_target_show(struct config_item *item, char *page)
+{
+	struct xe_config_device *dev = to_xe_config_device(item);
+
+	return sprintf(page, "%d\n", dev->guc_log_target);
+}
+
+static ssize_t guc_log_target_store(struct config_item *item, const char *page, size_t len)
+{
+	struct xe_config_group_device *dev = to_xe_config_group_device(item);
+	u8 guc_log_target;
+	int ret;

drivers/gpu/drm/xe/xe_configfs.c static bool is_bound(struct xe_config_group_device *dev) · line 393

Quoted 10 lines
drivers/gpu/drm/xe/xe_configfs.c +10 -0
+
+	ret = kstrtou8(page, 0, &guc_log_target);
+	if (ret)
+		return ret;
+
+	/*
+	 * No need to define full enumeration set since this is directly
+	 * applied from the user here to GuC.
+	 */
+#define GUC_LOG_TARGET_MAX	2

late to the party but agree with Daniele that this should be part of the GuC ABI file, and unlike Daniele I would prefer to enforce that as otherwise we will start again mixing local defines that we can change with GuC definitions that we don't own and can't change

(and yes, GUC_LOG_LEVEL min/max definitions should also follow that rule so they should be fixed too - someday ...)

for me it looks that this MAX could be based on existing define:

#define GUC_LOG_TARGET_MAX FIELD_MAX(GUC_LOG_DESTINATION)

but I'm wondering whether actually we should expose in stable configfs the low-level GuC ABI definitions

maybe more safe solution would be to add just higher-level attribute

bool guc_npk; /* use NPK? default: false */

and just convert that into GuC ABI bits in guc_ctl_debug_flags() ?

	flags |= FIELD_PREP(GUC_LOG_DESTINATION,
			xe_configfs_guc_npk(pdev) ?
			GUC_LOG_TARGET_MEM_AND_NPK :
			GUC_LOG_TARGET_MEM_ONLY);
Quoted 40 lines
drivers/gpu/drm/xe/xe_configfs.c +15 -0
+	if (guc_log_target > GUC_LOG_TARGET_MAX)
+		return -EINVAL;
+#undef GUC_LOG_TARGET_MAX
+> +	guard(mutex)(&dev->lock);
+	if (is_bound(dev))
+		return -EBUSY;
+
+	dev->config.guc_log_target = guc_log_target;
+
+	return len;
+}
+
 static ssize_t survivability_mode_show(struct config_item *item, char *page)
 {
 	struct xe_config_device *dev = to_xe_config_device(item);
@@ -815,6 +862,7 @@ CONFIGFS_ATTR(, ctx_restore_post_bb);
 CONFIGFS_ATTR(, enable_psmi);
 CONFIGFS_ATTR(, engines_allowed);
 CONFIGFS_ATTR(, gt_types_allowed);
+CONFIGFS_ATTR(, guc_log_target);
 CONFIGFS_ATTR(, survivability_mode);
 
 static struct configfs_attribute *xe_config_device_attrs[] = {
@@ -823,6 +871,7 @@ static struct configfs_attribute *xe_config_device_attrs[] = {
 	&attr_enable_psmi,
 	&attr_engines_allowed,
 	&attr_gt_types_allowed,
+	&attr_guc_log_target,
 	&attr_survivability_mode,
 	NULL,
 };
@@ -1095,6 +1144,7 @@ static void dump_custom_dev_config(struct pci_dev *pdev,
 				 dev->config.attr_); \
 	} while (0)
 
+	PRI_CUSTOM_ATTR("%d", guc_log_target);
 	PRI_CUSTOM_ATTR("%llx", gt_types_allowed);
 	PRI_CUSTOM_ATTR("%llx", engines_allowed);
 	PRI_CUSTOM_ATTR("%d", enable_psmi);

drivers/gpu/drm/xe/xe_configfs.c bool xe_configfs_get_survivability_mode(struct pci_dev *pdev) · line 1201

Quoted 5 lines
drivers/gpu/drm/xe/xe_configfs.c +2 -0
@@ -1147,6 +1197,26 @@ bool xe_configfs_get_survivability_mode(struct pci_dev *pdev)
 	return mode;
 }
 
+/**
+ * xe_configfs_get_guc_log_target - get configfs GuC log target attribute

nit: we try to append () to the function name in doc, like:

* xe_configfs_get_guc_log_target() - Get GuC log target attribute.

[2] https://docs.kernel.org/doc-guide/kernel-doc.html#function-documentation

Quoted 82 lines
drivers/gpu/drm/xe/xe_configfs.c +18 -0
+ * @pdev: pci device
+ *
+ * Return: guc_log_target attribute in configfs
+ */
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)
+{
+	struct xe_config_group_device *dev = find_xe_config_group_device(pdev);
+	u8 target;
+
+	if (!dev)
+		return device_defaults.guc_log_target;
+
+	target = dev->config.guc_log_target;
+	config_group_put(&dev->group);
+
+	return target;
+}
+
 static u64 get_gt_types_allowed(struct pci_dev *pdev)
 {
 	struct xe_config_group_device *dev = find_xe_config_group_device(pdev);
drivers/gpu/drm/xe/xe_configfs.h +5 -0
index 07d62bf0c152..fb5cb7c57e75 100644
@@ -19,6 +19,7 @@ int xe_configfs_init(void);
 void xe_configfs_exit(void);
 void xe_configfs_check_device(struct pci_dev *pdev);
 bool xe_configfs_get_survivability_mode(struct pci_dev *pdev);
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev);
 bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev);
 bool xe_configfs_media_gt_allowed(struct pci_dev *pdev);
 u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev);
@@ -38,6 +39,10 @@ static inline int xe_configfs_init(void) { return 0; }
 static inline void xe_configfs_exit(void) { }
 static inline void xe_configfs_check_device(struct pci_dev *pdev) { }
 static inline bool xe_configfs_get_survivability_mode(struct pci_dev *pdev) { return false; }
+static inline u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)
+{
+	return XE_DEFAULT_GUC_LOG_TARGET;
+}
 static inline bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev) { return true; }
 static inline bool xe_configfs_media_gt_allowed(struct pci_dev *pdev) { return true; }
 static inline u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) { return U64_MAX; }
drivers/gpu/drm/xe/xe_defaults.h +1 -0
index c8ae1d5f3d60..fbe670668a04 100644
@@ -12,6 +12,7 @@
 #else
 #define XE_DEFAULT_GUC_LOG_LEVEL		1
 #endif
+#define XE_DEFAULT_GUC_LOG_TARGET		0
 
 #define XE_DEFAULT_PROBE_DISPLAY		IS_ENABLED(CONFIG_DRM_XE_DISPLAY)
 #define XE_DEFAULT_VRAM_BAR_SIZE		0
drivers/gpu/drm/xe/xe_guc.c +8 -3
index e762eada21db..c40bd4aec2ce 100644
@@ -73,13 +73,18 @@ static u32 guc_bo_ggtt_addr(struct xe_guc *guc,
 
 static u32 guc_ctl_debug_flags(struct xe_guc *guc)
 {
+	struct pci_dev *pdev = to_pci_dev(guc_to_xe(guc)->drm.dev);
 	u32 level = xe_guc_log_get_level(&guc->log);
 	u32 flags = 0;
 
-	if (!GUC_LOG_LEVEL_IS_VERBOSE(level))
+	if (!GUC_LOG_LEVEL_IS_VERBOSE(level)) {
 		flags |= GUC_LOG_DISABLED;
-	else
-		flags |= FIELD_PREP(GUC_LOG_VERBOSITY, GUC_LOG_LEVEL_TO_VERBOSITY(level));
+	} else {
+		flags |= FIELD_PREP(GUC_LOG_VERBOSITY,
+				    GUC_LOG_LEVEL_TO_VERBOSITY(level));
+		flags |= FIELD_PREP(GUC_LOG_DESTINATION,
+				    xe_configfs_get_guc_log_target(pdev));
+	}
 
 	return flags;
 }
#5 lore raw
Quoted 13 lines · Michal Wajdeczko
Quoted 11 lines · Stuart Summers

From: John Harrison <[email protected]>

GuC provides the ability to gather logs through a hardware interface
called NPK. For certain debugging scenarios this can be advantageous
over getting logs from memory (or in addition to).

Add a hook for this alternate debugging mode via a configfs. This translates into a parameter passed to GuC during load time.

Quoted 6 lines
Quoted 4 lines

v2: Convert to configfs from modparam (Matt)
v3: Configfs documentation formatting (Shuicheng) Kerneldoc/comment add + configfs entry ordering Only set the guc_log_target when GuC log is enabled (Daniele)

nit: we may keep change log under --- so it stays on the ML only

Ok makes sense I'll do that on the next upload.

Quoted 3 lines

and please not forget to use -v option while preparing new patch revisions

Thanks Michal, I'll make sure to include this going forward.

Quoted 56 lines

[1]
https://git-scm.com/docs/git-format-patch#Documentation/git-format-patch.txt--vn

Quoted 52 lines

---
 drivers/gpu/drm/xe/xe_configfs.c | 70
++++++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_configfs.h |  5 +++
 drivers/gpu/drm/xe/xe_defaults.h |  1 +
 drivers/gpu/drm/xe/xe_guc.c      | 11 +++--

 4 files changed, 84 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_configfs.c +7 -0
index 32102600a148..e4511ee4e135 100644
@@ -83,6 +83,16 @@
   *
   * This attribute can only be set before binding to the device.
   *
+ * GuC log target:
+ * ---------------
+ *
+ * Set the destination for the GuC log. 0 - memory only (default),
+ * 1 - NPK only, 2 - memory + NPK. Example::
+ *
+ *     # echo 2 >

/sys/kernel/config/xe/0000:03:00.0/guc_log_target
+ *
+ * This attribute can only be set before binding to the device.
+ *
  * Allowed GT types:
  * -----------------
  *

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -256,6 +266,7 @@ struct xe_config_group_device {
         struct config_group sriov;


        struct xe_config_device {
+               u8 guc_log_target;
                u64 gt_types_allowed;
                u64 engines_allowed;
                struct wa_bb
ctx_restore_post_bb[XE_ENGINE_CLASS_MAX];

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -277,6 +288,7 @@ struct xe_config_group_device {
  };


 static const struct xe_config_device device_defaults = { +       .guc_log_target = XE_DEFAULT_GUC_LOG_TARGET, .gt_types_allowed = U64_MAX, .engines_allowed = U64_MAX, .survivability_mode = false,

Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -357,6 +369,41 @@ static bool is_bound(struct
 xe_config_group_device *dev)
         return ret;
  }

can we expose this new attribute only for XE_DEBUG_GUC config? we can easily use xe_config_device_is_visible for this

Makes sense to me. I'll make the change.

Quoted 35 lines
Quoted 23 lines

+static ssize_t guc_log_target_show(struct config_item *item, char *page)

drivers/gpu/drm/xe/xe_configfs.c +7 -0
+{
+       struct xe_config_device *dev = to_xe_config_device(item);
+
+       return sprintf(page, "%d\n", dev->guc_log_target);
+}
+
+static ssize_t guc_log_target_store(struct config_item *item,

const char *page, size_t len)
+{
+       struct xe_config_group_device *dev =
to_xe_config_group_device(item);
+       u8 guc_log_target;
+       int ret;

drivers/gpu/drm/xe/xe_configfs.c +7 -0
+
+       ret = kstrtou8(page, 0, &guc_log_target);
+       if (ret)
+               return ret;
+
+       /*
+        * No need to define full enumeration set since this is
Quoted 4 lines

directly
+        * applied from the user here to GuC.
+        */
+#define GUC_LOG_TARGET_MAX     2

late to the party but agree with Daniele that this should be part of the
GuC ABI file, and unlike Daniele I would prefer to enforce that as otherwise
we will start again mixing local defines that we can change with GuC definitions that we don't own and can't change

Quoted 3 lines

(and yes, GUC_LOG_LEVEL min/max definitions should also follow that rule
so they should be fixed too - someday ...)

Maybe I'll just include that in the next rev...

Quoted 11 lines

for me it looks that this MAX could be based on existing define:

#define GUC_LOG_TARGET_MAX      FIELD_MAX(GUC_LOG_DESTINATION)

but I'm wondering whether actually we should expose in stable configfs
the low-level GuC ABI definitions

maybe more safe solution would be to add just higher-level attribute

Quoted 8 lines

        bool guc_npk; /* use NPK? default: false */

and just convert that into GuC ABI bits in guc_ctl_debug_flags() ?

        flags |= FIELD_PREP(GUC_LOG_DESTINATION, xe_configfs_guc_npk(pdev) ? GUC_LOG_TARGET_MEM_AND_NPK :
                        GUC_LOG_TARGET_MEM_ONLY);

So I do like having the ability to pick and chose how we configure the logging here. I think in most cases sending to both lmem and npk is what we want, but there might be some corner case debugs where any regular access to lmem (or even smem) like this causes problems and we really do just want to send everything to npk. And we could of course default to send to npk and lmem, but I think for the general case we will never actually use this - it's a debug only function.

But your point about ABI is fair here. We don't have any use case beyond these two targets today, but that doesn't mean it always has to be the case... We could enforce these values for 0-2 and only add additional destinations on top of that.

Although given this is really a debug feature, would it make more sense to split this out as part of a debug only configfs? That's really the case for almost all of what we have in configfs today, minus maybe the max VF configuration - it isn't about performance tuning or anything, just about reducing scope of the driver in one way or another or enabling some debug capability otherwise. To me that isn't a true ABI.

What if I split this into xe_configfs.c and xe_configfs_debug.c, moved all of the debug specific entries to the latter with a little less restriction and kept the max VF one in xe_configfs.c for now? Then xe_configfs_debug.c can wrap in CONFIG_DRM_XE_DEBUG/CONFIG_DRM_XE_DEBUG_GUC?

I'll wait to hear back before making a change like that so we're on the same page.

Quoted 55 lines
Quoted 48 lines

+       if (guc_log_target > GUC_LOG_TARGET_MAX)
+               return -EINVAL;

drivers/gpu/drm/xe/xe_configfs.c +10 -0
+#undef GUC_LOG_TARGET_MAX
+> +    guard(mutex)(&dev->lock);
+       if (is_bound(dev))
+               return -EBUSY;
+
+       dev->config.guc_log_target = guc_log_target;
+
+       return len;
+}
+

 static ssize_t survivability_mode_show(struct config_item *item, char *page)
 {
        struct xe_config_device *dev = to_xe_config_device(item);

drivers/gpu/drm/xe/xe_configfs.c +1 -0
@@ -815,6 +862,7 @@ CONFIGFS_ATTR(, ctx_restore_post_bb);
  CONFIGFS_ATTR(, enable_psmi);
  CONFIGFS_ATTR(, engines_allowed);
  CONFIGFS_ATTR(, gt_types_allowed);
+CONFIGFS_ATTR(, guc_log_target);
  CONFIGFS_ATTR(, survivability_mode);


 static struct configfs_attribute *xe_config_device_attrs[] = {

drivers/gpu/drm/xe/xe_configfs.c +1 -0
@@ -823,6 +871,7 @@ static struct configfs_attribute
 *xe_config_device_attrs[] = {
         &attr_enable_psmi,
         &attr_engines_allowed,
         &attr_gt_types_allowed,
+       &attr_guc_log_target,
         &attr_survivability_mode,
         NULL,

 };

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -1095,6 +1144,7 @@ static void dump_custom_dev_config(struct
 pci_dev *pdev,
                                  dev->config.attr_); \
         } while (0)


+       PRI_CUSTOM_ATTR("%d", guc_log_target); PRI_CUSTOM_ATTR("%llx", gt_types_allowed); PRI_CUSTOM_ATTR("%llx", engines_allowed); PRI_CUSTOM_ATTR("%d", enable_psmi);

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -1147,6 +1197,26 @@ bool
 xe_configfs_get_survivability_mode(struct pci_dev *pdev)
         return mode;
  }
Quoted 4 lines


+/**
+ * xe_configfs_get_guc_log_target - get configfs GuC log target attribute

nit: we try to append () to the function name in doc, like:

Quoted 2 lines

    * xe_configfs_get_guc_log_target() - Get GuC log target attribute.

Ah makes sense thanks.

Thanks,
Stuart

Quoted 104 lines

[2]
https://docs.kernel.org/doc-guide/kernel-doc.html#function-documentation

Quoted 99 lines

+ * @pdev: pci device
+ *
+ * Return: guc_log_target attribute in configfs
+ */

drivers/gpu/drm/xe/xe_configfs.c +3 -0
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)
+{
+       struct xe_config_group_device *dev =

find_xe_config_group_device(pdev);
+       u8 target;

drivers/gpu/drm/xe/xe_configfs.c +10 -0
+
+       if (!dev)
+               return device_defaults.guc_log_target;
+
+       target = dev->config.guc_log_target;
+       config_group_put(&dev->group);
+
+       return target;
+}
+

 static u64 get_gt_types_allowed(struct pci_dev *pdev) {
        struct xe_config_group_device *dev = find_xe_config_group_device(pdev);

drivers/gpu/drm/xe/xe_configfs.h +1 -0
index 07d62bf0c152..fb5cb7c57e75 100644
@@ -19,6 +19,7 @@ int xe_configfs_init(void);
  void xe_configfs_exit(void);
  void xe_configfs_check_device(struct pci_dev *pdev);
  bool xe_configfs_get_survivability_mode(struct pci_dev *pdev);
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev);
  bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev);
  bool xe_configfs_media_gt_allowed(struct pci_dev *pdev);
  u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev);
@@ -38,6 +39,10 @@ static inline int xe_configfs_init(void) {
 return 0; }
  static inline void xe_configfs_exit(void) { }
  static inline void xe_configfs_check_device(struct pci_dev *pdev)
 { }

 static inline bool xe_configfs_get_survivability_mode(struct pci_dev *pdev) { return false; }
+static inline u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)

drivers/gpu/drm/xe/xe_configfs.h +3 -0
+{
+       return XE_DEFAULT_GUC_LOG_TARGET;
+}

 static inline bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev) { return true; }
 static inline bool xe_configfs_media_gt_allowed(struct pci_dev *pdev) { return true; }
 static inline u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) { return U64_MAX; }

drivers/gpu/drm/xe/xe_defaults.h +1 -0
index c8ae1d5f3d60..fbe670668a04 100644
@@ -12,6 +12,7 @@
  #else
  #define XE_DEFAULT_GUC_LOG_LEVEL               1
  #endif
+#define XE_DEFAULT_GUC_LOG_TARGET              0


 #define
XE_DEFAULT_PROBE_DISPLAY               IS_ENABLED(CONFIG_DRM_XE_DIS PLAY)
 #define XE_DEFAULT_VRAM_BAR_SIZE               0

drivers/gpu/drm/xe/xe_guc.c +0 -0
index e762eada21db..c40bd4aec2ce 100644
@@ -73,13 +73,18 @@ static u32 guc_bo_ggtt_addr(struct xe_guc *guc,


 static u32 guc_ctl_debug_flags(struct xe_guc *guc)
 {
+       struct pci_dev *pdev = to_pci_dev(guc_to_xe(guc)->drm.dev); u32 level = xe_guc_log_get_level(&guc->log);
        u32 flags = 0;

-       if (!GUC_LOG_LEVEL_IS_VERBOSE(level))
+       if (!GUC_LOG_LEVEL_IS_VERBOSE(level)) {
                flags |= GUC_LOG_DISABLED;
-       else
-               flags |= FIELD_PREP(GUC_LOG_VERBOSITY, GUC_LOG_LEVEL_TO_VERBOSITY(level));
+       } else {
+               flags |= FIELD_PREP(GUC_LOG_VERBOSITY,
+
GUC_LOG_LEVEL_TO_VERBOSITY(level));
+               flags |= FIELD_PREP(GUC_LOG_DESTINATION, +
xe_configfs_get_guc_log_target(pdev));
+       }

        return flags;
 }

#6 lore raw
Quoted 131 lines · Stuart
Quoted 13 lines · Michal Wajdeczko
Quoted 11 lines · Stuart Summers

From: John Harrison <[email protected]>

GuC provides the ability to gather logs through a hardware interface
called NPK. For certain debugging scenarios this can be advantageous
over getting logs from memory (or in addition to).

Add a hook for this alternate debugging mode via a configfs. This translates into a parameter passed to GuC during load time.

Quoted 6 lines
Quoted 4 lines

v2: Convert to configfs from modparam (Matt)
v3: Configfs documentation formatting (Shuicheng) Kerneldoc/comment add + configfs entry ordering Only set the guc_log_target when GuC log is enabled (Daniele)

nit: we may keep change log under --- so it stays on the ML only

Ok makes sense I'll do that on the next upload.

Quoted 3 lines

and please not forget to use -v option while preparing new patch revisions

Thanks Michal, I'll make sure to include this going forward.

Quoted 56 lines

[1]
https://git-scm.com/docs/git-format-patch#Documentation/git-format-patch.txt--vn

Quoted 52 lines

---
 drivers/gpu/drm/xe/xe_configfs.c | 70
++++++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_configfs.h |  5 +++
 drivers/gpu/drm/xe/xe_defaults.h |  1 +
 drivers/gpu/drm/xe/xe_guc.c      | 11 +++--

 4 files changed, 84 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_configfs.c +7 -0
index 32102600a148..e4511ee4e135 100644
@@ -83,6 +83,16 @@
   *
   * This attribute can only be set before binding to the device.
   *
+ * GuC log target:
+ * ---------------
+ *
+ * Set the destination for the GuC log. 0 - memory only (default),
+ * 1 - NPK only, 2 - memory + NPK. Example::
+ *
+ *     # echo 2 >

/sys/kernel/config/xe/0000:03:00.0/guc_log_target
+ *
+ * This attribute can only be set before binding to the device.
+ *
  * Allowed GT types:
  * -----------------
  *

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -256,6 +266,7 @@ struct xe_config_group_device {
         struct config_group sriov;


        struct xe_config_device {
+               u8 guc_log_target;
                u64 gt_types_allowed;
                u64 engines_allowed;
                struct wa_bb
ctx_restore_post_bb[XE_ENGINE_CLASS_MAX];

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -277,6 +288,7 @@ struct xe_config_group_device {
  };


 static const struct xe_config_device device_defaults = { +       .guc_log_target = XE_DEFAULT_GUC_LOG_TARGET, .gt_types_allowed = U64_MAX, .engines_allowed = U64_MAX, .survivability_mode = false,

Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -357,6 +369,41 @@ static bool is_bound(struct
 xe_config_group_device *dev)
         return ret;
  }

can we expose this new attribute only for XE_DEBUG_GUC config? we can easily use xe_config_device_is_visible for this

Makes sense to me. I'll make the change.

Quoted 35 lines
Quoted 23 lines

+static ssize_t guc_log_target_show(struct config_item *item, char *page)

drivers/gpu/drm/xe/xe_configfs.c +7 -0
+{
+       struct xe_config_device *dev = to_xe_config_device(item);
+
+       return sprintf(page, "%d\n", dev->guc_log_target);
+}
+
+static ssize_t guc_log_target_store(struct config_item *item,

const char *page, size_t len)
+{
+       struct xe_config_group_device *dev =
to_xe_config_group_device(item);
+       u8 guc_log_target;
+       int ret;

drivers/gpu/drm/xe/xe_configfs.c +7 -0
+
+       ret = kstrtou8(page, 0, &guc_log_target);
+       if (ret)
+               return ret;
+
+       /*
+        * No need to define full enumeration set since this is
Quoted 4 lines

directly
+        * applied from the user here to GuC.
+        */
+#define GUC_LOG_TARGET_MAX     2

late to the party but agree with Daniele that this should be part of the
GuC ABI file, and unlike Daniele I would prefer to enforce that as otherwise
we will start again mixing local defines that we can change with GuC definitions that we don't own and can't change

Quoted 5 lines
Quoted 3 lines

(and yes, GUC_LOG_LEVEL min/max definitions should also follow that rule
so they should be fixed too - someday ...)

Maybe I'll just include that in the next rev...

btw, as there might be more "GuC" specific attributes, maybe we should try to group them?

/sys/kernel/config/xe/

└── 0000:4d:00.0
    ├── ...
    └── guc
        ├── firmware_path	""
        ├── log_level		0..5
        ├── log_npk		false|true
        ├── log_target		0..3
        └── ...
Quoted 34 lines
Quoted 12 lines

for me it looks that this MAX could be based on existing define:

#define GUC_LOG_TARGET_MAX      FIELD_MAX(GUC_LOG_DESTINATION)

but I'm wondering whether actually we should expose in stable configfs
the low-level GuC ABI definitions

maybe more safe solution would be to add just higher-level attribute

Quoted 8 lines

        bool guc_npk; /* use NPK? default: false */

and just convert that into GuC ABI bits in guc_ctl_debug_flags() ?

        flags |= FIELD_PREP(GUC_LOG_DESTINATION, xe_configfs_guc_npk(pdev) ? GUC_LOG_TARGET_MEM_AND_NPK :
                        GUC_LOG_TARGET_MEM_ONLY);

So I do like having the ability to pick and chose how we configure the logging here. I think in most cases sending to both lmem and npk is what we want, but there might be some corner case debugs where any regular access to lmem (or even smem) like this causes problems and we really do just want to send everything to npk. And we could of course default to send to npk and lmem, but I think for the general case we will never actually use this - it's a debug only function.

But your point about ABI is fair here. We don't have any use case beyond these two targets today, but that doesn't mean it always has to be the case... We could enforce these values for 0-2 and only add additional destinations on top of that.

Quoted 6 lines

Although given this is really a debug feature, would it make more sense to split this out as part of a debug only configfs? That's really the case for almost all of what we have in configfs today, minus maybe the max VF configuration - it isn't about performance tuning or anything, just about reducing scope of the driver in one way or another or enabling some debug capability otherwise. To me that isn't a true ABI.

+1

but in the past I was told that configfs is ABI

Quoted 6 lines

What if I split this into xe_configfs.c and xe_configfs_debug.c, moved all of the debug specific entries to the latter with a little less restriction and kept the max VF one in xe_configfs.c for now? Then xe_configfs_debug.c can wrap in CONFIG_DRM_XE_DEBUG/CONFIG_DRM_XE_DEBUG_GUC?

so now that's the question to the maintainers - and I guess the main question here is if already exposed attributes can be now hidden

(maybe we can just clarify that some entries are DEBUG only, and thus may be changed/dropped in the future)

Quoted 172 lines

I'll wait to hear back before making a change like that so we're on the same page.

Quoted 55 lines
Quoted 48 lines

+       if (guc_log_target > GUC_LOG_TARGET_MAX)
+               return -EINVAL;

drivers/gpu/drm/xe/xe_configfs.c +10 -0
+#undef GUC_LOG_TARGET_MAX
+> +    guard(mutex)(&dev->lock);
+       if (is_bound(dev))
+               return -EBUSY;
+
+       dev->config.guc_log_target = guc_log_target;
+
+       return len;
+}
+

 static ssize_t survivability_mode_show(struct config_item *item, char *page)
 {
        struct xe_config_device *dev = to_xe_config_device(item);

drivers/gpu/drm/xe/xe_configfs.c +1 -0
@@ -815,6 +862,7 @@ CONFIGFS_ATTR(, ctx_restore_post_bb);
  CONFIGFS_ATTR(, enable_psmi);
  CONFIGFS_ATTR(, engines_allowed);
  CONFIGFS_ATTR(, gt_types_allowed);
+CONFIGFS_ATTR(, guc_log_target);
  CONFIGFS_ATTR(, survivability_mode);


 static struct configfs_attribute *xe_config_device_attrs[] = {

drivers/gpu/drm/xe/xe_configfs.c +1 -0
@@ -823,6 +871,7 @@ static struct configfs_attribute
 *xe_config_device_attrs[] = {
         &attr_enable_psmi,
         &attr_engines_allowed,
         &attr_gt_types_allowed,
+       &attr_guc_log_target,
         &attr_survivability_mode,
         NULL,

 };

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -1095,6 +1144,7 @@ static void dump_custom_dev_config(struct
 pci_dev *pdev,
                                  dev->config.attr_); \
         } while (0)


+       PRI_CUSTOM_ATTR("%d", guc_log_target); PRI_CUSTOM_ATTR("%llx", gt_types_allowed); PRI_CUSTOM_ATTR("%llx", engines_allowed); PRI_CUSTOM_ATTR("%d", enable_psmi);

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -1147,6 +1197,26 @@ bool
 xe_configfs_get_survivability_mode(struct pci_dev *pdev)
         return mode;
  }
Quoted 4 lines


+/**
+ * xe_configfs_get_guc_log_target - get configfs GuC log target attribute

nit: we try to append () to the function name in doc, like:

Quoted 2 lines

    * xe_configfs_get_guc_log_target() - Get GuC log target attribute.

Ah makes sense thanks.

Thanks,
Stuart

Quoted 104 lines

[2]
https://docs.kernel.org/doc-guide/kernel-doc.html#function-documentation

Quoted 99 lines

+ * @pdev: pci device
+ *
+ * Return: guc_log_target attribute in configfs
+ */

drivers/gpu/drm/xe/xe_configfs.c +3 -0
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)
+{
+       struct xe_config_group_device *dev =

find_xe_config_group_device(pdev);
+       u8 target;

drivers/gpu/drm/xe/xe_configfs.c +10 -0
+
+       if (!dev)
+               return device_defaults.guc_log_target;
+
+       target = dev->config.guc_log_target;
+       config_group_put(&dev->group);
+
+       return target;
+}
+

 static u64 get_gt_types_allowed(struct pci_dev *pdev) {
        struct xe_config_group_device *dev = find_xe_config_group_device(pdev);

drivers/gpu/drm/xe/xe_configfs.h +1 -0
index 07d62bf0c152..fb5cb7c57e75 100644
@@ -19,6 +19,7 @@ int xe_configfs_init(void);
  void xe_configfs_exit(void);
  void xe_configfs_check_device(struct pci_dev *pdev);
  bool xe_configfs_get_survivability_mode(struct pci_dev *pdev);
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev);
  bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev);
  bool xe_configfs_media_gt_allowed(struct pci_dev *pdev);
  u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev);
@@ -38,6 +39,10 @@ static inline int xe_configfs_init(void) {
 return 0; }
  static inline void xe_configfs_exit(void) { }
  static inline void xe_configfs_check_device(struct pci_dev *pdev)
 { }

 static inline bool xe_configfs_get_survivability_mode(struct pci_dev *pdev) { return false; }
+static inline u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)

drivers/gpu/drm/xe/xe_configfs.h +3 -0
+{
+       return XE_DEFAULT_GUC_LOG_TARGET;
+}

 static inline bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev) { return true; }
 static inline bool xe_configfs_media_gt_allowed(struct pci_dev *pdev) { return true; }
 static inline u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev) { return U64_MAX; }

drivers/gpu/drm/xe/xe_defaults.h +1 -0
index c8ae1d5f3d60..fbe670668a04 100644
@@ -12,6 +12,7 @@
  #else
  #define XE_DEFAULT_GUC_LOG_LEVEL               1
  #endif
+#define XE_DEFAULT_GUC_LOG_TARGET              0


 #define
XE_DEFAULT_PROBE_DISPLAY               IS_ENABLED(CONFIG_DRM_XE_DIS PLAY)
 #define XE_DEFAULT_VRAM_BAR_SIZE               0

drivers/gpu/drm/xe/xe_guc.c +0 -0
index e762eada21db..c40bd4aec2ce 100644
@@ -73,13 +73,18 @@ static u32 guc_bo_ggtt_addr(struct xe_guc *guc,


 static u32 guc_ctl_debug_flags(struct xe_guc *guc)
 {
+       struct pci_dev *pdev = to_pci_dev(guc_to_xe(guc)->drm.dev); u32 level = xe_guc_log_get_level(&guc->log);
        u32 flags = 0;

-       if (!GUC_LOG_LEVEL_IS_VERBOSE(level))
+       if (!GUC_LOG_LEVEL_IS_VERBOSE(level)) {
                flags |= GUC_LOG_DISABLED;
-       else
-               flags |= FIELD_PREP(GUC_LOG_VERBOSITY, GUC_LOG_LEVEL_TO_VERBOSITY(level));
+       } else {
+               flags |= FIELD_PREP(GUC_LOG_VERBOSITY,
+
GUC_LOG_LEVEL_TO_VERBOSITY(level));
+               flags |= FIELD_PREP(GUC_LOG_DESTINATION, +
xe_configfs_get_guc_log_target(pdev));
+       }

        return flags;
 }

#7 lore raw
Quoted 156 lines · Michal Wajdeczko
Quoted 141 lines · Stuart
Quoted 14 lines · Michal Wajdeczko
Quoted 12 lines · Stuart Summers

From: John Harrison <[email protected]>

GuC provides the ability to gather logs through a hardware interface
called NPK. For certain debugging scenarios this can be advantageous
over getting logs from memory (or in addition to).

Add a hook for this alternate debugging mode via a configfs. This
translates into a parameter passed to GuC during load time.

Quoted 7 lines
Quoted 5 lines

v2: Convert to configfs from modparam (Matt)
v3: Configfs documentation formatting (Shuicheng) Kerneldoc/comment add + configfs entry ordering Only set the guc_log_target when GuC log is enabled (Daniele)

nit: we may keep change log under --- so it stays on the ML only

Ok makes sense I'll do that on the next upload.

Quoted 3 lines

and please not forget to use -v option while preparing new patch revisions

Thanks Michal, I'll make sure to include this going forward.

Quoted 59 lines

[1]
https://git-scm.com/docs/git-format-patch#Documentation/git-format-patch.txt--vn

Quoted 55 lines

---
 drivers/gpu/drm/xe/xe_configfs.c | 70
++++++++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_configfs.h |  5 +++ drivers/gpu/drm/xe/xe_defaults.h |  1 + drivers/gpu/drm/xe/xe_guc.c      | 11 +++--

 4 files changed, 84 insertions(+), 3 deletions(-)
drivers/gpu/drm/xe/xe_configfs.c +0 -0
index 32102600a148..e4511ee4e135 100644
@@ -83,6 +83,16 @@
   *
   * This attribute can only be set before binding to the

device.
  *
+ * GuC log target:
+ * ---------------
+ *
+ * Set the destination for the GuC log. 0 - memory only (default),
+ * 1 - NPK only, 2 - memory + NPK. Example::
+ *
+ *     # echo 2 > /sys/kernel/config/xe/0000:03:00.0/guc_log_target
+ *
+ * This attribute can only be set before binding to the device.
+ *
  * Allowed GT types:
  * -----------------
  *

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -256,6 +266,7 @@ struct xe_config_group_device {
         struct config_group sriov;


        struct xe_config_device {
+               u8 guc_log_target;
                u64 gt_types_allowed;
                u64 engines_allowed;
                struct wa_bb
ctx_restore_post_bb[XE_ENGINE_CLASS_MAX];

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -277,6 +288,7 @@ struct xe_config_group_device {
  };


 static const struct xe_config_device device_defaults = { +       .guc_log_target = XE_DEFAULT_GUC_LOG_TARGET, .gt_types_allowed = U64_MAX, .engines_allowed = U64_MAX, .survivability_mode = false,

Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -357,6 +369,41 @@ static bool is_bound(struct
 xe_config_group_device *dev)
         return ret;
  }

can we expose this new attribute only for XE_DEBUG_GUC config? we can easily use xe_config_device_is_visible for this

Makes sense to me. I'll make the change.

Quoted 40 lines
Quoted 25 lines

+static ssize_t guc_log_target_show(struct config_item *item, char
*page)
+{
+       struct xe_config_device *dev = to_xe_config_device(item);

drivers/gpu/drm/xe/xe_configfs.c +5 -0
+
+       return sprintf(page, "%d\n", dev->guc_log_target);
+}
+
+static ssize_t guc_log_target_store(struct config_item *item,

const char *page, size_t len)
+{
+       struct xe_config_group_device *dev = to_xe_config_group_device(item);
+       u8 guc_log_target;
+       int ret;

drivers/gpu/drm/xe/xe_configfs.c +7 -0
+
+       ret = kstrtou8(page, 0, &guc_log_target);
+       if (ret)
+               return ret;
+
+       /*
+        * No need to define full enumeration set since this is
Quoted 4 lines

directly
+        * applied from the user here to GuC.
+        */
+#define GUC_LOG_TARGET_MAX     2

late to the party but agree with Daniele that this should be part of
the
GuC ABI file, and unlike Daniele I would prefer to enforce that as
otherwise
we will start again mixing local defines that we can change with GuC
definitions that we don't own and can't change

Quoted 6 lines
Quoted 4 lines

(and yes, GUC_LOG_LEVEL min/max definitions should also follow that
rule
so they should be fixed too - someday ...)

Maybe I'll just include that in the next rev...

btw, as there might be more "GuC" specific attributes, maybe we should
try to group them?

/sys/kernel/config/xe/

Quoted 8 lines
└── 0000:4d:00.0
    ├── ...
    └── guc
        ├── firmware_path       ""
        ├── log_level           0..5
        ├── log_npk             false|true
        ├── log_target          0..3
        └── ...

Yeah makes sense to me...

Quoted 54 lines
Quoted 42 lines
Quoted 16 lines

for me it looks that this MAX could be based on existing define:

#define GUC_LOG_TARGET_MAX      FIELD_MAX(GUC_LOG_DESTINATION)

but I'm wondering whether actually we should expose in stable configfs
the low-level GuC ABI definitions

maybe more safe solution would be to add just higher-level attribute

        bool guc_npk; /* use NPK? default: false */

Quoted 7 lines

and just convert that into GuC ABI bits in guc_ctl_debug_flags() ?

        flags |= FIELD_PREP(GUC_LOG_DESTINATION, xe_configfs_guc_npk(pdev) ? GUC_LOG_TARGET_MEM_AND_NPK :
                        GUC_LOG_TARGET_MEM_ONLY);

So I do like having the ability to pick and chose how we configure the
logging here. I think in most cases sending to both lmem and npk is what we want, but there might be some corner case debugs where any regular access to lmem (or even smem) like this causes problems and we
really do just want to send everything to npk. And we could of course
default to send to npk and lmem, but I think for the general case we
will never actually use this - it's a debug only function.

But your point about ABI is fair here. We don't have any use case beyond these two targets today, but that doesn't mean it always has to
be the case... We could enforce these values for 0-2 and only add additional destinations on top of that.

Quoted 11 lines

Although given this is really a debug feature, would it make more sense
to split this out as part of a debug only configfs? That's really the
case for almost all of what we have in configfs today, minus maybe the
max VF configuration - it isn't about performance tuning or anything,
just about reducing scope of the driver in one way or another or enabling some debug capability otherwise. To me that isn't a true ABI.

Quoted 3 lines

+1

but in the past I was told that configfs is ABI

At least from the documentation it seems like it is. The documentation compares it directly to sysfs - a configuration alternative to the sysfs runtime. But at least wrapping in DRM_XE_DEBUG we can prevent obvious mis-use... For now I can at least float the patch and get feedback. I'll add the pros and cons from what you described in the new cover letter so we can discuss.

Quoted 9 lines
Quoted 8 lines

What if I split this into xe_configfs.c and xe_configfs_debug.c, moved
all of the debug specific entries to the latter with a little less restriction and kept the max VF one in xe_configfs.c for now? Then xe_configfs_debug.c can wrap in CONFIG_DRM_XE_DEBUG/CONFIG_DRM_XE_DEBUG_GUC?

Quoted 5 lines

so now that's the question to the maintainers - and I guess the main question here is if already exposed attributes can be now hidden

(maybe we can just clarify that some entries are DEBUG only, and thus may be changed/dropped in the future)

Yeah I mean to me at least if we call it out as debug via config, it means an end user should rely on it... it requires them to rebuild the kernel if nothing else from the distro release.

Thanks,
Stuart

Quoted 184 lines
Quoted 183 lines

I'll wait to hear back before making a change like that so we're on the
same page.

Quoted 58 lines
Quoted 50 lines

+       if (guc_log_target > GUC_LOG_TARGET_MAX) +               return -EINVAL;

drivers/gpu/drm/xe/xe_configfs.c +10 -0
+#undef GUC_LOG_TARGET_MAX
+> +    guard(mutex)(&dev->lock);
+       if (is_bound(dev))
+               return -EBUSY;
+
+       dev->config.guc_log_target = guc_log_target;
+
+       return len;
+}
+

 static ssize_t survivability_mode_show(struct config_item *item,
char *page)
 {
        struct xe_config_device *dev = to_xe_config_device(item);

drivers/gpu/drm/xe/xe_configfs.c +1 -0
@@ -815,6 +862,7 @@ CONFIGFS_ATTR(, ctx_restore_post_bb);
  CONFIGFS_ATTR(, enable_psmi);
  CONFIGFS_ATTR(, engines_allowed);
  CONFIGFS_ATTR(, gt_types_allowed);
+CONFIGFS_ATTR(, guc_log_target);
  CONFIGFS_ATTR(, survivability_mode);


 static struct configfs_attribute *xe_config_device_attrs[] = {

drivers/gpu/drm/xe/xe_configfs.c +1 -0
@@ -823,6 +871,7 @@ static struct configfs_attribute
 *xe_config_device_attrs[] = {
         &attr_enable_psmi,
         &attr_engines_allowed,
         &attr_gt_types_allowed,
+       &attr_guc_log_target,
         &attr_survivability_mode,
         NULL,

 };

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -1095,6 +1144,7 @@ static void dump_custom_dev_config(struct
 pci_dev *pdev,
                                  dev->config.attr_); \
         } while (0)


+       PRI_CUSTOM_ATTR("%d", guc_log_target); PRI_CUSTOM_ATTR("%llx", gt_types_allowed); PRI_CUSTOM_ATTR("%llx", engines_allowed); PRI_CUSTOM_ATTR("%d", enable_psmi);

drivers/gpu/drm/xe/xe_configfs.c +0 -0
@@ -1147,6 +1197,26 @@ bool
 xe_configfs_get_survivability_mode(struct pci_dev *pdev)
         return mode;
  }
Quoted 5 lines


+/**
+ * xe_configfs_get_guc_log_target - get configfs GuC log target
attribute

nit: we try to append () to the function name in doc, like:

Quoted 2 lines

    * xe_configfs_get_guc_log_target() - Get GuC log target attribute.

Ah makes sense thanks.

Thanks,
Stuart

Quoted 110 lines

[2]
https://docs.kernel.org/doc-guide/kernel-doc.html#function-documentation

Quoted 105 lines

+ * @pdev: pci device
+ *
+ * Return: guc_log_target attribute in configfs
+ */

drivers/gpu/drm/xe/xe_configfs.c +3 -0
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)
+{
+       struct xe_config_group_device *dev =

find_xe_config_group_device(pdev);
+       u8 target;

drivers/gpu/drm/xe/xe_configfs.c +10 -0
+
+       if (!dev)
+               return device_defaults.guc_log_target;
+
+       target = dev->config.guc_log_target;
+       config_group_put(&dev->group);
+
+       return target;
+}
+

 static u64 get_gt_types_allowed(struct pci_dev *pdev) {
        struct xe_config_group_device *dev = find_xe_config_group_device(pdev);

drivers/gpu/drm/xe/xe_configfs.h +1 -0
index 07d62bf0c152..fb5cb7c57e75 100644
@@ -19,6 +19,7 @@ int xe_configfs_init(void);
  void xe_configfs_exit(void);
  void xe_configfs_check_device(struct pci_dev *pdev);
  bool xe_configfs_get_survivability_mode(struct pci_dev *pdev);
+u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev);
  bool xe_configfs_primary_gt_allowed(struct pci_dev *pdev);
  bool xe_configfs_media_gt_allowed(struct pci_dev *pdev);
  u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev);
@@ -38,6 +39,10 @@ static inline int xe_configfs_init(void) {
 return 0; }
  static inline void xe_configfs_exit(void) { }

 static inline void xe_configfs_check_device(struct pci_dev *pdev)
{ }
 static inline bool xe_configfs_get_survivability_mode(struct pci_dev *pdev) { return false; }
+static inline u8 xe_configfs_get_guc_log_target(struct pci_dev *pdev)

drivers/gpu/drm/xe/xe_configfs.h +3 -0
+{
+       return XE_DEFAULT_GUC_LOG_TARGET;
+}

 static inline bool xe_configfs_primary_gt_allowed(struct pci_dev
*pdev) { return true; }
 static inline bool xe_configfs_media_gt_allowed(struct pci_dev *pdev) { return true; }
 static inline u64 xe_configfs_get_engines_allowed(struct pci_dev
*pdev) { return U64_MAX; }

drivers/gpu/drm/xe/xe_defaults.h +1 -0
index c8ae1d5f3d60..fbe670668a04 100644
@@ -12,6 +12,7 @@
  #else
  #define XE_DEFAULT_GUC_LOG_LEVEL               1
  #endif
+#define XE_DEFAULT_GUC_LOG_TARGET              0


 #define
XE_DEFAULT_PROBE_DISPLAY               IS_ENABLED(CONFIG_DRM_XE _DIS
PLAY)
 #define XE_DEFAULT_VRAM_BAR_SIZE               0

drivers/gpu/drm/xe/xe_guc.c +0 -0
index e762eada21db..c40bd4aec2ce 100644
@@ -73,13 +73,18 @@ static u32 guc_bo_ggtt_addr(struct xe_guc
 *guc,


 static u32 guc_ctl_debug_flags(struct xe_guc *guc) {
+       struct pci_dev *pdev = to_pci_dev(guc_to_xe(guc)-

Quoted 1 line

drm.dev);

        u32 level = xe_guc_log_get_level(&guc->log); u32 flags = 0;

-       if (!GUC_LOG_LEVEL_IS_VERBOSE(level))
+       if (!GUC_LOG_LEVEL_IS_VERBOSE(level)) { flags |= GUC_LOG_DISABLED;
-       else
-               flags |= FIELD_PREP(GUC_LOG_VERBOSITY, GUC_LOG_LEVEL_TO_VERBOSITY(level));
+       } else {
+               flags |= FIELD_PREP(GUC_LOG_VERBOSITY, +
GUC_LOG_LEVEL_TO_VERBOSITY(level));
+               flags |= FIELD_PREP(GUC_LOG_DESTINATION, +
xe_configfs_get_guc_log_target(pdev));
+       }

        return flags;
 }

#8 lore raw
In reply to Summers, Stuart
Quoted 14 lines · Stuart
Quoted 13 lines · Michal Wajdeczko
Quoted 11 lines · Stuart Summers

From: John Harrison <[email protected]>

GuC provides the ability to gather logs through a hardware interface
called NPK. For certain debugging scenarios this can be advantageous
over getting logs from memory (or in addition to).

Add a hook for this alternate debugging mode via a configfs. This translates into a parameter passed to GuC during load time.

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

v2: Convert to configfs from modparam (Matt)
v3: Configfs documentation formatting (Shuicheng) Kerneldoc/comment add + configfs entry ordering Only set the guc_log_target when GuC log is enabled (Daniele)

nit: we may keep change log under --- so it stays on the ML only

Ok makes sense I'll do that on the next upload.

Is this an intentional deviation from the quite prevalent drm subsystem style of including the changelog in the commit message?

I'm not dead set on either style personally, but I do not like conflicting review feedback, and people not knowing what to do.

BR,
Jani.

Signature · 1 line
Jani Nikula, Intel
#9 lore raw
Quoted 25 lines · Jani Nikula
Quoted 23 lines · Stuart
Quoted 21 lines · Michal Wajdeczko
Quoted 12 lines · Stuart Summers

From: John Harrison <[email protected]>

GuC provides the ability to gather logs through a hardware interface
called NPK. For certain debugging scenarios this can be advantageous
over getting logs from memory (or in addition to).

Add a hook for this alternate debugging mode via a configfs. This
translates into a parameter passed to GuC during load time.

Quoted 5 lines

v2: Convert to configfs from modparam (Matt)
v3: Configfs documentation formatting (Shuicheng) Kerneldoc/comment add + configfs entry ordering Only set the guc_log_target when GuC log is enabled (Daniele)

nit: we may keep change log under --- so it stays on the ML only

Quoted 8 lines
Quoted 1 line

Ok makes sense I'll do that on the next upload.

Is this an intentional deviation from the quite prevalent drm subsystem
style of including the changelog in the commit message?

I'm not dead set on either style personally, but I do not like conflicting review feedback, and people not knowing what to do.

I agree it would be nice to have consistency, whatever we decide. I don't have a strong preference either way, although it is interesting to me to see progression looking at the patch history - but we can get the same looking at the mailing list archives which is probably even more interesting.

Do we have a general recommendation here? I don't see anything in the git format-patch section. The kernel canonical patch format documentation [1] does mention this as a possibility, but not a requirement (from my reading):
"""
One good use for the additional comments after the --- marker is for a diffstat, to show what files have changed, and the number of inserted and deleted lines per file. A diffstat is especially useful on bigger patches. Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. A good example of such comments might be patch changelogs which describe what has changed between the v1 and v2 version of the patch.
"""

[1]:
https://www.kernel.org/doc/html/v4.11/process/submitting-patches.html#the-canonical-patch-format

Thanks,
Stuart

Quoted 6 lines

BR,
Jani.