Skip to contentSkip to conversation

ACPI: AGDI: fix missing newline in error message

PATCH Applied Haoyu Lu 3 participants 3 messages Apr 7 – Apr 8

Subsystems (2)
lore
Share & tools
lore

Haoyu Lu

author
#0 lore raw

PATCH v3 1/1 ACPI: AGDI: fix missing newline in error message

Add the missing trailing newline to the dev_err() message printed when SDEI event registration fails.

This keeps the error output as a properly terminated log line.

Fixes a2a591fb76e6f5461dfd04715b69c317e50c43a5 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device")

---
Changes in v2:
- Change subject prefix from "acpi: arm64: agdi:" to "ACPI: AGDI:"

Changes in v3:
- Move version history below the "---" separator as per review feedback

 drivers/acpi/arm64/agdi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/arm64/agdi.c +1 -1
index feb4b2cb4618..0c2d9d6c160b 100644
@@ -36,7 +36,7 @@ static int agdi_sdei_probe(struct platform_device *pdev,
 
 	err = sdei_event_register(adata->sdei_event, agdi_sdei_handler, pdev);
 	if (err) {
-		dev_err(&pdev->dev, "Failed to register for SDEI event %d",
+		dev_err(&pdev->dev, "Failed to register for SDEI event %d\n",
 			adata->sdei_event);
 		return err;
 	}

--
2.17.1

maintainer Reviewed-by on v3 1/1
#1 lore raw
Quoted 23 lines · Haoyu Lu

Add the missing trailing newline to the dev_err() message printed when SDEI event registration fails.

This keeps the error output as a properly terminated log line.

Fixes a2a591fb76e6f5461dfd04715b69c317e50c43a5 ("ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device")

---
Changes in v2:
- Change subject prefix from "acpi: arm64: agdi:" to "ACPI: AGDI:"

Changes in v3:
- Move version history below the "---" separator as per review feedback

  drivers/acpi/arm64/agdi.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/arm64/agdi.c +0 -0
index feb4b2cb4618..0c2d9d6c160b 100644

drivers/acpi/arm64/agdi.c static int agdi_sdei_probe(struct platform_device *pdev, · line 42

Quoted 8 lines
drivers/acpi/arm64/agdi.c +1 -1
@@ -36,7 +36,7 @@ static int agdi_sdei_probe(struct platform_device *pdev,
 
  	err = sdei_event_register(adata->sdei_event, agdi_sdei_handler, pdev);
  	if (err) {
-		dev_err(&pdev->dev, "Failed to register for SDEI event %d",
+		dev_err(&pdev->dev, "Failed to register for SDEI event %d\n",
  			adata->sdei_event);
  		return err;
  	}

Thanks
Hanjun