net: initialize sk_rx_queue_mapping in sk_clone()
Subsystems (3)
PATCH 1/1 net: initialize sk_rx_queue_mapping in sk_clone()
sk_clone() initializes sk_tx_queue_mapping via sk_tx_queue_clear() but does not initialize sk_rx_queue_mapping. Since this field is in the sk_dontcopy region, it is neither copied from the parent socket by sock_copy() nor zeroed by sk_prot_alloc() (called without __GFP_ZERO from sk_clone).
Commit 03cfda4fa6ea ("tcp: fix another uninit-value (sk_rx_queue_mapping)") attempted to fix this by introducing sk_mark_napi_id_set() with force_set=true in tcp_child_process(). However, sk_mark_napi_id_set() -> sk_rx_queue_set() only writes when skb_rx_queue_recorded(skb) is true. If the 3-way handshake ACK arrives through a device that does not record rx_queue (e.g. loopback or veth), sk_rx_queue_mapping remains uninitialized.
When a subsequent data packet arrives with a recorded rx_queue, sk_mark_napi_id() -> sk_rx_queue_update() reads the uninitialized field for comparison (force_set=false path), triggering KMSAN.
This was reproduced by establishing a TCP connection over loopback (which does not call skb_record_rx_queue), then attaching a BPF TC program on lo ingress to set skb->queue_mapping on data packets:
BUG: KMSAN: uninit-value in tcp_v4_do_rcv (net/ipv4/tcp_ipv4.c:1875) tcp_v4_do_rcv (net/ipv4/tcp_ipv4.c:1875) tcp_v4_rcv (net/ipv4/tcp_ipv4.c:2287) ip_protocol_deliver_rcu (net/ipv4/ip_input.c:207) ip_local_deliver_finish (net/ipv4/ip_input.c:242) ip_local_deliver (net/ipv4/ip_input.c:262) ip_rcv (net/ipv4/ip_input.c:573) __netif_receive_skb (net/core/dev.c:6294) process_backlog (net/core/dev.c:6646) __napi_poll (net/core/dev.c:7710) net_rx_action (net/core/dev.c:7929) handle_softirqs (kernel/softirq.c:623) do_softirq (kernel/softirq.c:523) __local_bh_enable_ip (kernel/softirq.c:?) __dev_queue_xmit (net/core/dev.c:?) ip_finish_output2 (net/ipv4/ip_output.c:237) ip_output (net/ipv4/ip_output.c:438) __ip_queue_xmit (net/ipv4/ip_output.c:534) __tcp_transmit_skb (net/ipv4/tcp_output.c:1693) tcp_write_xmit (net/ipv4/tcp_output.c:3064) tcp_sendmsg_locked (net/ipv4/tcp.c:?) tcp_sendmsg (net/ipv4/tcp.c:1465) inet_sendmsg (net/ipv4/af_inet.c:865) sock_write_iter (net/socket.c:1195) vfs_write (fs/read_write.c:688) ...
Uninit was created at:
kmem_cache_alloc_noprof (mm/slub.c:4873)
sk_prot_alloc (net/core/sock.c:2239)
sk_alloc (net/core/sock.c:2301)
inet_create (net/ipv4/af_inet.c:334)
__sock_create (net/socket.c:1605)
__sys_socket (net/socket.c:1747)
Fix this at the root by adding sk_rx_queue_clear() alongside sk_tx_queue_clear() in sk_clone().
--- net/core/sock.c | 1 + 1 file changed, 1 insertion(+)
net/core/sock.c +1 -0
@@ -2583,6 +2583,7 @@ struct sock *sk_clone(const struct sock *sk, const gfp_t priority,sk_set_socket (newsk,NULL );sk_tx_queue_clear (newsk); +sk_rx_queue_clear (newsk);RCU_INIT_POINTER (newsk->sk_wq,NULL );if (newsk->sk_prot->sockets_allocated)
Signature · 1 line
2.43.0
Quoted 15 lines · Jiayuan Chen
sk_clone()initializessk_tx_queue_mappingviask_tx_queue_clear()but does not initializesk_rx_queue_mapping. Since this field is in thesk_dontcopyregion, it is neither copied from the parent socket bysock_copy()nor zeroed bysk_prot_alloc()(called without__GFP_ZEROfromsk_clone).Commit
03cfda4fa6ea("tcp: fix another uninit-value (sk_rx_queue_mapping)") attempted to fix this by introducingsk_mark_napi_id_set()with force_set=true intcp_child_process(). However,sk_mark_napi_id_set()->sk_rx_queue_set()only writes whenskb_rx_queue_recorded(skb)is true. If the 3-way handshake ACK arrives through a device that does not recordrx_queue(e.g. loopback or veth),sk_rx_queue_mappingremains uninitialized.
Quoted 7 lines
When a subsequent data packet arrives with a recorded
rx_queue,sk_mark_napi_id()->sk_rx_queue_update()reads the uninitialized field for comparison (force_set=false path), triggering KMSAN.This was reproduced by establishing a TCP connection over loopback (which does not call
skb_record_rx_queue), then attaching a BPF TC program on lo ingress to setskb->queue_mappingon data packets:
Ok, it's a somewhat convoluted way, and no real harm but KMSAN :)
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 14 lines · On Tue, 7 Apr 2026 16:42:18 +0800 you wrote:
sk_clone()initializessk_tx_queue_mappingviask_tx_queue_clear()but does not initializesk_rx_queue_mapping. Since this field is in thesk_dontcopyregion, it is neither copied from the parent socket bysock_copy()nor zeroed bysk_prot_alloc()(called without__GFP_ZEROfromsk_clone).Commit
03cfda4fa6ea("tcp: fix another uninit-value (sk_rx_queue_mapping)") attempted to fix this by introducingsk_mark_napi_id_set()with force_set=true intcp_child_process(). However,sk_mark_napi_id_set()->sk_rx_queue_set()only writes whenskb_rx_queue_recorded(skb)is true. If the 3-way handshake ACK arrives through a device that does not recordrx_queue(e.g. loopback or veth),sk_rx_queue_mappingremains uninitialized.
Quoted 1 line
[...]
Here is the summary with links:
- [net] net: initialize sk_rx_queue_mapping in sk_clone()
https://git.kernel.org/netdev/net-next/c/1a6b3965385a
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html