tools: fwumdata: Fix use-after-free in parse_config()
PATCH 1/1 tools: fwumdata: Fix use-after-free in parse_config()
In parse_config(), devname is dynamically allocated by sscanf(). When sscanf() fails to fill enough fields (rc < 3), devname is freed and the loop continues to the next line. However, if the next call to sscanf() fails to match (rc == 0), devname is not written and still holds the stale freed pointer. The subsequent free(devname) then operates on already-freed memory.
Fix this by resetting devname to NULL before each sscanf() call, so that a non-matching call leaves a NULL pointer and the subsequent free() becomes a harmless no-op.
--- tools/fwumdata_src/fwumdata.c | 1 + 1 file changed, 1 insertion(+)
tools/fwumdata_src/fwumdata.c +1 -0
@@ -84,6 +84,7 @@ static int parse_config(const char *fname)if (line[0 ] =='#' || line[0 ] =='\n' )continue ; + devname =NULL ; rc = sscanf(line, "%ms %lli %lx %lx", &devname, &devices[i].devoff,
Signature · 1 line
2.43.0
Hi Kory
Quoted 8 lines · Kory Maincent
In
parse_config(), devname is dynamically allocated bysscanf(). Whensscanf()fails to fill enough fields (rc < 3), devname is freed and the loop continues to the next line. However, if the next call tosscanf()fails to match (rc == 0), devname is not written and still holds the stale freed pointer. The subsequent free(devname) then operates on already-freed memory.
Quoted 8 lines
Fix this by resetting devname to NULL before each
sscanf()call, so that a non-matching call leaves a NULL pointer and the subsequentfree()becomes a harmless no-op.Reported-by Coverity ScanSigned-off-by Kory Maincent <[email protected]>---
Quoted 18 lines
tools/fwumdata_src/fwumdata.c | 1 + 1 file changed, 1 insertion(+)tools/fwumdata_src/fwumdata.c +1
-1@@ -84,6 +84,7 @@ static int parse_config(const char *fname)if (line[0 ] =='#' || line[0 ] =='\n' )continue ; + devname =NULL ; rc = sscanf(line, "%ms %lli %lx %lx", &devname, &devices[i].devoff, --2.43.0