arm: dts: s5p4418: fix "mmc write failed" e.g. at cmd saveenv
PATCH 1/1 arm: dts: s5p4418: fix "mmc write failed" e.g. at cmd saveenv
s5p4418-pinctrl.dtsi: Fix mmc bus definitions to fix "mmc write failed" e.g. when cmd saveenv is executed. Initialize all four GPIO of the mmc-buses instead of only the first one.
---
arch/arm/dts/s5p4418-pinctrl.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/dts/s5p4418-pinctrl.dtsi +3 -3
@@ -35,7 +35,7 @@ pinctrl@C0010000 { }; mmc0_bus4: mmc0-bus-width4 { - pins = "gpiob-1, gpiob-3, gpiob-5, gpiob-7"; + pins = "gpiob-1", "gpiob-3", "gpiob-5", "gpiob-7"; pin-function = <1>; pin-pull = <2>; pin-strength = <1>;
@@ -56,7 +56,7 @@ pinctrl@C0010000 { }; mmc1_bus4: mmc1-bus-width4 { - pins = "gpiod-24, gpiod-25, gpiod-26, gpiod-27"; + pins = "gpiod-24", "gpiod-25", "gpiod-26", "gpiod-27"; pin-function = <1>; pin-pull = <2>; pin-strength = <1>;
@@ -77,7 +77,7 @@ pinctrl@C0010000 { }; mmc2_bus4: mmc2-bus-width4 { - pins = "gpioc-20, gpioc-21, gpioc-22, gpioc-23"; + pins = "gpioc-20", "gpioc-21", "gpioc-22", "gpioc-23"; pin-function = <2>; pin-pull = <2>; pin-strength = <1>;
Signature · 1 line
2.17.1
Quoted 9 lines · Stefan Bosch
s5p4418-pinctrl.dtsi: Fix mmc bus definitions to fix "mmc write failed" e.g. when cmd saveenv is executed. Initialize all four GPIO of the mmc-buses instead of only the first one.Signed-off-by Stefan Bosch <[email protected]>---
arch/arm/dts/s5p4418-pinctrl.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Hey, I'm curious what it would take to move this to using OF_UPSTREAM, where I assume this problem has already been fixed? Thanks!
Signature · 1 line
Tom
Hi Tom,
Quoted 6 lines · Tom Rini
Quoted 4 lines · Stefan Bosch
s5p4418-pinctrl.dtsi: Fix mmc bus definitions to fix "mmc write failed" e.g. when cmd saveenv is executed. Initialize all four GPIO of the mmc-buses instead of only the first one.
Quoted 9 lines
Quoted 5 lines
Signed-off-by Stefan Bosch <[email protected]>---
arch/arm/dts/s5p4418-pinctrl.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)Hey, I'm curious what it would take to move this to using
OF_UPSTREAM, where I assume this problem has already been fixed? Thanks!
If I'm not mistaken, using OF_UPSTREAM is not possible because I think the s5p4418 SoC is not in the Linux kernel source tree and therefore also not in the devicetree-rebasing repo.
Regards
Stefan
Quoted 15 lines · Stefan Bosch
Hi Tom,
Quoted 12 lines · Tom Rini
Quoted 9 lines · Stefan Bosch
s5p4418-pinctrl.dtsi: Fix mmc bus definitions to fix "mmc write failed" e.g. when cmd saveenv is executed. Initialize all four GPIO of the mmc-buses instead of only the first one.Signed-off-by Stefan Bosch <[email protected]>---
arch/arm/dts/s5p4418-pinctrl.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 6 lines
Quoted 3 lines
Hey, I'm curious what it would take to move this to using
OF_UPSTREAM, where I assume this problem has already been fixed? Thanks!If I'm not mistaken, using
OF_UPSTREAMis not possible because I think the s5p4418 SoC is not in the Linux kernel source tree and therefore also not in the devicetree-rebasing repo.
Ah. That would be higher bar to clear. OK, thanks!
Signature · 1 line
Tom