Skip to contentSkip to conversation

dt-bindings: display: bridge: lt9211: Require data-lanes on DSI input ports

PATCH Applied Marek Vasut 3 participants 5 messages Apr 7 – May 8

Subsystems (4)
Device tree bindings DRM drivers DRM misc DRM drivers for bridge chips
lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH v2 1/1 dt-bindings: display: bridge: lt9211: Require data-lanes on DSI input ports

The Lontium LT9211 is capable of 1..4 DSI lanes per input DSI port, describe the lane count for each input port in the schema.

For example Linux kernel driver does already use that information and fails to probe if it is missing.

Signed-off-by Marek Vasut <[email protected]>

---
Cc: Andrzej Hajda <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Jernej Skrabec <[email protected]>
Cc: Jonas Karlman <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Maarten Lankhorst <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Neil Armstrong <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Robert Foss <[email protected]>
Cc: Simona Vetter <[email protected]>
Cc: Thomas Zimmermann <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
V2: - Update commit message, indicate Linux already requires data-lanes property
- Add required: data-lanes

---
 .../display/bridge/lontium,lt9211.yaml        | 43 ++++++++++++++++++-
 1 file changed, 41 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/display/bridge/lontium,lt9211.yaml +41 -2
index 9a6e9b25d14a9..7cfe92a8bcd72 100644
@@ -36,18 +36,56 @@ properties:
 
     properties:
       port@0:
-        $ref: /schemas/graph.yaml#/properties/port
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description:
           Primary MIPI DSI port-1 for MIPI input or
           LVDS port-1 for LVDS input or DPI input.
 
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+
+            properties:
+              data-lanes:
+                description: array of physical DSI data lane indexes.
+                minItems: 1
+                items:
+                  - const: 1
+                  - const: 2
+                  - const: 3
+                  - const: 4
+
+            required:
+              - data-lanes
+
       port@1:
-        $ref: /schemas/graph.yaml#/properties/port
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description:
           Additional MIPI port-2 for MIPI input or LVDS port-2
           for LVDS input. Used in combination with primary
           port-1 to drive higher resolution displays
 
+        properties:
+          endpoint:
+            $ref: /schemas/media/video-interfaces.yaml#
+            unevaluatedProperties: false
+
+            properties:
+              data-lanes:
+                description: array of physical DSI data lane indexes.
+                minItems: 1
+                items:
+                  - const: 1
+                  - const: 2
+                  - const: 3
+                  - const: 4
+
+            required:
+              - data-lanes
+
       port@2:
         $ref: /schemas/graph.yaml#/properties/port
         description:

@@ -99,6 +137,7 @@ examples:
             reg = <0>;
 
             endpoint {
+              data-lanes = <1 2 3 4>;
               remote-endpoint = <&dsi0_out>;
             };
           };
Signature · 1 line
2.53.0
author
#2 lore raw
Quoted 10 lines · Krzysztof Kozlowski
Quoted 7 lines · Marek Vasut

The Lontium LT9211 is capable of 1..4 DSI lanes per input DSI port, describe the lane count for each input port in the schema.

For example Linux kernel driver does already use that information and fails to probe if it is missing.

Signed-off-by Marek Vasut <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>

Can this be applied to drm-misc now ?

Thank you

author
#3 lore raw
In reply to Krzysztof Kozlowski
Quoted 10 lines · Krzysztof Kozlowski
Quoted 7 lines · Marek Vasut

The Lontium LT9211 is capable of 1..4 DSI lanes per input DSI port, describe the lane count for each input port in the schema.

For example Linux kernel driver does already use that information and fails to probe if it is missing.

Signed-off-by Marek Vasut <[email protected]>
Reviewed-by Krzysztof Kozlowski <[email protected]>

Can this be applied via drm-misc now ?

Applied
#4 lore raw
In reply to Marek Vasut
Quoted 8 lines · Marek Vasut

The Lontium LT9211 is capable of 1..4 DSI lanes per input DSI port, describe the lane count for each input port in the schema.

For example Linux kernel driver does already use that information and fails to probe if it is missing.

[...]

Applied to drm-misc-next, thanks!

[1/1] dt-bindings: display: bridge: lt9211: Require data-lanes on DSI input ports

      commit: c2738d88b624a977e42a1734fad4b15993ac354a

Best regards,

Signature · 2 lines
With best wishes
Dmitry