wifi: iwlwifi: remove unused header inclusions
PATCH 1/1 wifi: iwlwifi: remove unused header inclusions
Remove header files that are included but provide no symbols, types, or macros used by the including translation unit.
In iwl-trans.c, fw/api/tx.h defines TX command structures (iwl_tx_cmd, iwl_tx_resp, TX_CMD_* flags) used by the PCIe TX path, not by the transport core itself. Similarly, iwl-fh.h defines Flow Handler register addresses and DMA-related constants (FH_*, RFH_*, TFD_*) that are consumed by PCIe-specific code, none of which are referenced in iwl-trans.c.
In iwl-nvm-parse.c, fw/acpi.h defines ACPI/SAR/GEO/PPAG interfaces (iwl_acpi_*, iwl_sar_*, iwl_geo_*). No references to any of these interfaces exist in this file.
---
This is my first commit to the Linux kernel. Feel free to give any feedback on my process or style. Thx.
Tested by building the module with clang and W=2:
make M=drivers/net/wireless/intel/iwlwifi CC=clang W=2 \
KCFLAGS="-Wno-error=enum-enum-conversion -Wno-error=shadow \
-Wno-error=unused-macros"No new warnings introduced.
drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c | 1 - drivers/net/wireless/intel/iwlwifi/iwl-trans.c | 2 -- 2 files changed, 3 deletions(-)
drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c +0 -1
@@ -18,7 +18,6 @@#include "iwl-prph.h" #include "iwl-io.h" #include "iwl-csr.h" -#include "fw/acpi.h" #include "fw/api/nvm-reg.h" #include "fw/api/commands.h" #include "fw/api/cmdhdr.h"
drivers/net/wireless/intel/iwlwifi/iwl-trans.c +0 -2
@@ -8,10 +8,8 @@#include <linux/bsearch.h> #include <linux/list.h> -#include "fw/api/tx.h" #include "iwl-trans.h" #include "iwl-drv.h" -#include "iwl-fh.h" #include <linux/dmapool.h> #include "fw/api/commands.h" #include "pcie/gen1_2/internal.h"
--
2.53.0