spi: pl022: enable compile testing
PATCH 1/1 spi: pl022: enable compile testing
There seems to be nothing preventing this driver from being compile tested so enable that for wider build coverage.
--- drivers/spi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/Kconfig +1 -1
@@ -866,7 +866,7 @@ config SPI_PIC32_SQI config SPI_PL022 tristate "ARM AMBA PL022 SSP controller" - depends on ARM_AMBA + depends on ARM_AMBA || COMPILE_TEST default y if ARCH_REALVIEW default y if INTEGRATOR_IMPD1 default y if ARCH_VERSATILE
Signature · 1 line
2.52.0
Mark Brown
maintainerQuoted 2 lines · Johan Hovold
There seems to be nothing preventing this driver from being compile tested so enable that for wider build coverage.
$ grep amba drivers/spi/spi-pl022.c
#include <linux/amba/bus.h>
#include <linux/amba/pl022.h>
struct amba_device *adev;
static int pl022_probe(struct amba_device *adev, const struct amba_id *id)
status = amba_request_regions(adev, NULL);
amba_set_drvdata(adev, pl022);
amba_release_regions(adev);
pl022_remove(struct amba_device *adev)
struct pl022 *pl022 = amba_get_drvdata(adev);
amba_release_regions(adev);
static const struct amba_id pl022_ids[] = {
MODULE_DEVICE_TABLE(amba, pl022_ids);
static struct amba_driver pl022_driver = {
return amba_driver_register(&pl022_driver);
amba_driver_unregister(&pl022_driver);At least amba_request_regions() and amba_release_regions() don't appear to have stubs for !AMBA?
Quoted 21 lines · Mark Brown
Quoted 2 lines · Johan Hovold
There seems to be nothing preventing this driver from being compile tested so enable that for wider build coverage.
$ grep amba drivers/spi/spi-pl022.c #include <linux/amba/bus.h> #include <linux/amba/pl022.h> struct amba_device *adev; static int pl022_probe(struct amba_device *adev, const struct amba_id *id) status = amba_request_regions(adev, NULL); amba_set_drvdata(adev, pl022); amba_release_regions(adev); pl022_remove(struct amba_device *adev) struct pl022 *pl022 = amba_get_drvdata(adev); amba_release_regions(adev); static const struct amba_id pl022_ids[] = { MODULE_DEVICE_TABLE(amba, pl022_ids); static struct amba_driver pl022_driver = { return amba_driver_register(&pl022_driver); amba_driver_unregister(&pl022_driver);
Quoted 2 lines
At least
amba_request_regions()andamba_release_regions()don't appear to have stubs for !AMBA?
Hmm, it builds here on x86 with gcc (15) both as a module and as built-in.
It seems the probe function is discarded before linking as the amba driver struct is never used on !AMBA. It definitely compiles.
$ nm /tmp/kbuild/nu/drivers/spi/spi-pl022.o
0000000000000000 d __exitcall_pl022_exit
0000000000000000 r __initcall__kmod_spi_pl022__527_2185_pl022_init4
0000000000000000 r __mod_device_table__kmod_spi_pl022__amba__pl022_ids
0000000000000000 t pl022_exit
0000000000000000 r pl022_ids
0000000000000000 t pl022_init
U __SCK__WARN_trap
0000000000000000 d __UNIQUE_ID_addressable_pl022_init_528
0000000000000008 d __UNIQUE_ID_addressable___SCK__WARN_trap_496.15
000000000000006d r __UNIQUE_ID_modinfo_529
000000000000003b r __UNIQUE_ID_modinfo_530
0000000000000016 r __UNIQUE_ID_modinfo_531
0000000000000000 r __UNIQUE_ID_modinfo_532
0000000000000030 d vendor_arm
0000000000000000 d vendor_lsi
0000000000000020 d vendor_st
0000000000000010 d vendor_st_pl023Johan
Mark Brown
maintainerQuoted 1 line · Johan Hovold
spi: pl022: enable compile testing
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.1
Thanks!
[1/1] spi: pl022: enable compile testing
https://git.kernel.org/broonie/spi/c/484eb2c4cc7f
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark