seq_buf: add KUnit tests for seq_buf_putmem_hex()
Subsystems (3)
PATCH 1/1 seq_buf: add KUnit tests for seq_buf_putmem_hex()
The seq_buf KUnit suite does not exercise seq_buf_putmem_hex().
Add one test for the len > 8 chunking path and one overflow test where a later chunk no longer fits in the buffer.
--- lib/tests/seq_buf_kunit.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
lib/tests/seq_buf_kunit.c +34 -0
@@ -184,6 +184,38 @@ static void seq_buf_get_buf_commit_test(struct kunit *test)KUNIT_EXPECT_TRUE (test,seq_buf_has_overflowed (&s)); } +static void seq_buf_putmem_hex_test (struct kunit *test) +{ +DECLARE_SEQ_BUF (s,24 ); +const u8 data[] = {0 ,1 ,2 ,3 ,4 ,5 ,6 ,7 ,8 ,9 }; +#ifdef __BIG_ENDIAN +const char *expected ="0001020304050607 0809 " ; +#else +const char *expected ="0706050403020100 0908 " ; +#endif + +KUNIT_EXPECT_EQ (test,seq_buf_putmem_hex (&s, data,sizeof (data)),0 ); +KUNIT_EXPECT_FALSE (test,seq_buf_has_overflowed (&s)); +KUNIT_EXPECT_EQ (test,seq_buf_used (&s),strlen (expected)); +KUNIT_EXPECT_STREQ (test,seq_buf_str (&s), expected); +} + +static void seq_buf_putmem_hex_overflow_test (struct kunit *test) +{ +DECLARE_SEQ_BUF (s,20 ); +const u8 data[] = {0 ,1 ,2 ,3 ,4 ,5 ,6 ,7 ,8 ,9 }; +#ifdef __BIG_ENDIAN +const char *expected ="0001020304050607 " ; +#else +const char *expected ="0706050403020100 " ; +#endif + +KUNIT_EXPECT_EQ (test,seq_buf_putmem_hex (&s, data,sizeof (data)),-1 ); +KUNIT_EXPECT_TRUE (test,seq_buf_has_overflowed (&s)); +KUNIT_EXPECT_EQ (test,seq_buf_used (&s),20 ); +KUNIT_EXPECT_STREQ (test,seq_buf_str (&s), expected); +} +static struct kunit_case seq_buf_test_cases[] = {KUNIT_CASE (seq_buf_init_test),KUNIT_CASE (seq_buf_declare_test),
@@ -194,6 +226,8 @@ static struct kunit_case seq_buf_test_cases[] = {KUNIT_CASE (seq_buf_printf_test),KUNIT_CASE (seq_buf_printf_overflow_test),KUNIT_CASE (seq_buf_get_buf_commit_test), +KUNIT_CASE (seq_buf_putmem_hex_test), + KUNIT_CASE(seq_buf_putmem_hex_overflow_test), {} };
Signature · 1 line
2.50.0
kernel test robot
build botkernel test robot noticed the following build errors:
Hi Shuvam,
kernel test robot noticed the following build errors:
[auto build test ERROR on akpm-mm/mm-nonmm-unstable]
[also build test ERROR on akpm-mm/mm-everything linus/master v7.0-rc7 next-20260407] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shuvam-Pandey/seq_buf-add-KUnit-tests-for-seq_buf_putmem_hex/20260408-090623 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-nonmm-unstable patch link: https://lore.kernel.org/r/20260406033728.25998-1-shuvampandey1%40gmail.com patch subject: [PATCH] seq_buf: add KUnit tests for seq_buf_putmem_hex() config: arm-randconfig-002-20260408 (https://download.01.org/0day-ci/archive/20260408/[email protected]/config) compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project c80443cd37b2e2788cba67ffa180a6331e5f0791) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260408/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>, old ones prefixed by <<):
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/arm/probes/kprobes/test-kprobes.o
>> ERROR: modpost: "seq_buf_putmem_hex" [lib/tests/seq_buf_kunit.ko] undefined!
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
PATCH v2 1/1 seq_buf: export seq_buf_putmem_hex() and add KUnit tests
In reply to Shuvam Pandeyseq_buf: export seq_buf_putmem_hex() and add KUnit tests
The seq_buf KUnit suite does not exercise seq_buf_putmem_hex().
Add one test for the len > 8 chunking path and one overflow test where a later chunk no longer fits in the buffer.
Export seq_buf_putmem_hex() as well so SEQ_BUF_KUNIT_TEST=m links cleanly. Without the export, modpost reports seq_buf_putmem_hex as undefined when seq_buf_kunit is built as a module.
---
v2:
- export seq_buf_putmem_hex() so SEQ_BUF_KUNIT_TEST=m links cleanly
- validate with a fresh arm64 build using CONFIG_KUNIT=y and CONFIG_SEQ_BUF_KUNIT_TEST=m
lib/seq_buf.c | 1 + lib/tests/seq_buf_kunit.c | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+)
lib/seq_buf.c +1 -0
@@ -298,6 +298,7 @@ int seq_buf_putmem_hex(struct seq_buf *s, const void *mem, }return 0 ; } +EXPORT_SYMBOL_GPL (seq_buf_putmem_hex);/** * seq_buf_path - copy a path into the sequence buffer
lib/tests/seq_buf_kunit.c +34 -0
@@ -184,6 +184,38 @@ static void seq_buf_get_buf_commit_test(struct kunit *test)KUNIT_EXPECT_TRUE (test,seq_buf_has_overflowed (&s)); } +static void seq_buf_putmem_hex_test (struct kunit *test) +{ +DECLARE_SEQ_BUF (s,24 ); +const u8 data[] = {0 ,1 ,2 ,3 ,4 ,5 ,6 ,7 ,8 ,9 }; +#ifdef __BIG_ENDIAN +const char *expected ="0001020304050607 0809 " ; +#else +const char *expected ="0706050403020100 0908 " ; +#endif + +KUNIT_EXPECT_EQ (test,seq_buf_putmem_hex (&s, data,sizeof (data)),0 ); +KUNIT_EXPECT_FALSE (test,seq_buf_has_overflowed (&s)); +KUNIT_EXPECT_EQ (test,seq_buf_used (&s),strlen (expected)); +KUNIT_EXPECT_STREQ (test,seq_buf_str (&s), expected); +} + +static void seq_buf_putmem_hex_overflow_test (struct kunit *test) +{ +DECLARE_SEQ_BUF (s,20 ); +const u8 data[] = {0 ,1 ,2 ,3 ,4 ,5 ,6 ,7 ,8 ,9 }; +#ifdef __BIG_ENDIAN +const char *expected ="0001020304050607 " ; +#else +const char *expected ="0706050403020100 " ; +#endif + +KUNIT_EXPECT_EQ (test,seq_buf_putmem_hex (&s, data,sizeof (data)),-1 ); +KUNIT_EXPECT_TRUE (test,seq_buf_has_overflowed (&s)); +KUNIT_EXPECT_EQ (test,seq_buf_used (&s),20 ); +KUNIT_EXPECT_STREQ (test,seq_buf_str (&s), expected); +} +static struct kunit_case seq_buf_test_cases[] = {KUNIT_CASE (seq_buf_init_test),KUNIT_CASE (seq_buf_declare_test),
@@ -194,6 +226,8 @@ static struct kunit_case seq_buf_test_cases[] = {KUNIT_CASE (seq_buf_printf_test),KUNIT_CASE (seq_buf_printf_overflow_test),KUNIT_CASE (seq_buf_get_buf_commit_test), +KUNIT_CASE (seq_buf_putmem_hex_test), + KUNIT_CASE(seq_buf_putmem_hex_overflow_test), {} };
Re: [PATCH v2] seq_buf: export seq_buf_putmem_hex() and add KUnit tests
Quoted 11 lines · On Wed, 8 Apr 2026 20:29:49 +0545 Shuvam Pandey <[email protected]>…
seq_buf: exportseq_buf_putmem_hex()and add KUnit testsThe
seq_bufKUnit suite does not exerciseseq_buf_putmem_hex().Add one test for the len > 8 chunking path and one overflow test where a later chunk no longer fits in the buffer.
Export
seq_buf_putmem_hex()as well so SEQ_BUF_KUNIT_TEST=m links cleanly. Without the export, modpost reportsseq_buf_putmem_hexas undefined whenseq_buf_kunitis built as a module.
Please always send a new version as its own thread and not as a reply to the old version.
Also, for tracing and seq_buf, use capital letters in the subject:
seq_buf: Export seq_buf_putmem_hex() and add KUnit tests
Quoted 3 lines
Signed-off-by Shuvam Pandey <[email protected]>---
v2:
This should be:
Changes since v1: https://lore.kernel.org/all/[email protected]/
Quoted 5 lines
- export
seq_buf_putmem_hex()so SEQ_BUF_KUNIT_TEST=m links cleanly
- validate with a fresh arm64 build usingCONFIG_KUNIT=yandCONFIG_SEQ_BUF_KUNIT_TEST=mlib/seq_buf.c | 1 + lib/tests/seq_buf_kunit.c | 34 ++++++++++++++++++++++++++++++++++
-- Steve