Skip to contentSkip to conversation

package/libnl: enable host package variant

PATCH In review Giulio Benetti 3 participants 5 messages Apr 8 – Apr 19

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 package/libnl: enable host package variant

host-libnl is needed for host-nfs-utils.

---
V1->V2:
* drop HOST_LIBNL_INSTALL_STAGING = YES as pointed by Thomas Petazzoni

---
 package/libnl/libnl.mk | 3 +++
 1 file changed, 3 insertions(+)
package/libnl/libnl.mk +3 -0
index a0441b7835..b1254d2ba0 100644
@@ -13,6 +13,8 @@ LIBNL_CPE_ID_VALID = YES
 LIBNL_INSTALL_STAGING = YES
 LIBNL_DEPENDENCIES = host-bison host-flex host-pkgconf
 
+HOST_LIBNL_DEPENDENCIES = host-bison host-flex host-pkgconf
+
 ifeq ($(BR2_PACKAGE_LIBNL_TOOLS),y)
 LIBNL_CONF_OPTS += --enable-cli
 else
@@ -27,3 +29,4 @@ LIBNL_CONF_OPTS += --disable-unit-tests
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH v2 2/2 package/nfs-utils: bump version to 2.9.1

Add dependency to libnl that became mandatory with commit:
https://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commitdiff;h=d2fa3421f857e04de7f79cdf3114a0fe73983d25

Add 3 local patches pending upstream to fix build failures.

Release announce:
https://lore.kernel.org/linux-nfs/[email protected]/

---
V1->V2:
* reworked patches 1 and 2 and added patch 3 to fix build with old glibc

---
 ..._file-fix-missing-string.h-inclusion.patch | 28 +++++++
 ....h-file-to-deal-with-old-Linux-api-a.patch | 77 +++++++++++++++++++
 ...kend_sqlite.c-fix-getrandom-fallback.patch | 30 ++++++++
 package/nfs-utils/Config.in                   |  1 +
 package/nfs-utils/nfs-utils.hash              |  4 +-
 package/nfs-utils/nfs-utils.mk                |  6 +-
 6 files changed, 141 insertions(+), 5 deletions(-)
 create mode 100644 package/nfs-utils/0001-fh_key_file-fix-missing-string.h-inclusion.patch
 create mode 100644 package/nfs-utils/0002-Introduce-compat.h-file-to-deal-with-old-Linux-api-a.patch
 create mode 100644 package/nfs-utils/0003-support-backend_sqlite.c-fix-getrandom-fallback.patch
package/nfs-utils/0001-fh_key_file-fix-missing-string.h-inclusion.patch new file +28 -0
new file mode 100644
index 0000000000..838d519d5a
@@ -0,0 +1,28 @@
+From 2d99ff0aa8a3b4d20558bce742edaaed9d24b3cb Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <[email protected]>
+Date: Tue, 7 Apr 2026 17:23:13 +0200
+Subject: [PATCH] fh_key_file: fix missing string.h inclusion
+
+Add #include <string.h> to fix build failure.
+
+Upstream: https://lore.kernel.org/linux-nfs/[email protected]/T/#t
+Signed-off-by: Giulio Benetti <[email protected]>
+---
+ support/nfs/fh_key_file.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/support/nfs/fh_key_file.c b/support/nfs/fh_key_file.c
+index 5f5eafc1..81ea1500 100644
+--- a/support/nfs/fh_key_file.c
++++ b/support/nfs/fh_key_file.c
+@@ -26,6 +26,7 @@
+ #include <sys/types.h>
+ #include <unistd.h>
+ #include <errno.h>
++#include <string.h>
+ #include <uuid/uuid.h>
+ 
+ #include "nfslib.h"
+-- 
+2.47.3
+
package/nfs-utils/0002-Introduce-compat.h-file-to-deal-with-old-Linux-api-a.patch new file +77 -0

77 lines not on this page · raw message

package/nfs-utils/0003-support-backend_sqlite.c-fix-getrandom-fallback.patch new file +30 -0
new file mode 100644
index 0000000000..86d615ca34
@@ -0,0 +1,30 @@
+From dbd44e7d6d4140e5e9d01f0a6daf6f3e45e5acbc Mon Sep 17 00:00:00 2001
+From: Giulio Benetti <[email protected]>
+Date: Wed, 8 Apr 2026 14:28:28 +0200
+Subject: [PATCH] support/backend_sqlite.c: fix getrandom() fallback
+
+In old Linux/Glibc versions __NR_getrandom is defined in <sys/random.h>
+so let's add it to fix build failure.
+
+Upstream: https://lore.kernel.org/linux-nfs/[email protected]/T/#u
+Signed-off-by: Giulio Benetti <[email protected]>
+---
+ support/reexport/backend_sqlite.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/support/reexport/backend_sqlite.c b/support/reexport/backend_sqlite.c
+index 0eb5ea37..a1e981e4 100644
+--- a/support/reexport/backend_sqlite.c
++++ b/support/reexport/backend_sqlite.c
+@@ -9,6 +9,8 @@
+ #include <string.h>
+ #include <unistd.h>
+ 
++#include <sys/syscall.h>
++
+ #ifdef HAVE_GETRANDOM
+ # include <sys/random.h>
+ # if !defined(SYS_getrandom) && defined(__NR_getrandom)
+-- 
+2.47.3
+
package/nfs-utils/Config.in +1 -0
index 419b605667..295ce28edb 100644
@@ -8,6 +8,7 @@ config BR2_PACKAGE_NFS_UTILS
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # getrandom()
 	select BR2_PACKAGE_LIBEVENT
+	select BR2_PACKAGE_LIBNL
 	select BR2_PACKAGE_LIBTIRPC # IPv6 requires libtirpc
 	select BR2_PACKAGE_LIBTIRPC_RPCDB
 	select BR2_PACKAGE_SQLITE
package/nfs-utils/nfs-utils.hash +2 -2
index 1e3f63d419..19315e60a3 100644
@@ -1,4 +1,4 @@
-# From https://www.kernel.org/pub/linux/utils/nfs-utils/2.8.7/sha256sums.asc
-sha256  59d0f1e17b18efaa60ea3ccf89a9cad3217f8d3b23c18d2fe34b25c8969d60ae  nfs-utils-2.8.7.tar.xz
+# From https://www.kernel.org/pub/linux/utils/nfs-utils/2.9.1/sha256sums.asc
+sha256  302846343bf509f8f884c23bdbd0fe853b7f7cbb6572060a9082279d13b21a2c  nfs-utils-2.9.1.tar.xz
 # Locally computed
 sha256  576540abf5e95029ad4ad90e32071385a5e95b2c30708c706116f3eb87b9a3de  COPYING
package/nfs-utils/nfs-utils.mk +3 -3
index 3d391c1804..df9fdbc052 100644
@@ -4,12 +4,12 @@
 #
 ################################################################################
 
-NFS_UTILS_VERSION = 2.8.7
+NFS_UTILS_VERSION = 2.9.1
 NFS_UTILS_SOURCE = nfs-utils-$(NFS_UTILS_VERSION).tar.xz
 NFS_UTILS_SITE = https://www.kernel.org/pub/linux/utils/nfs-utils/$(NFS_UTILS_VERSION)
 NFS_UTILS_LICENSE = GPL-2.0+
 NFS_UTILS_LICENSE_FILES = COPYING
-NFS_UTILS_DEPENDENCIES = host-nfs-utils host-pkgconf libevent libtirpc sqlite util-linux
+NFS_UTILS_DEPENDENCIES = host-nfs-utils host-pkgconf libevent libnl libtirpc sqlite util-linux
 NFS_UTILS_CPE_ID_VENDOR = linux-nfs
 
 NFS_UTILS_CONF_ENV = knfsd_cv_bsd_signals=no
@@ -23,7 +23,7 @@ NFS_UTILS_CONF_OPTS = \
 	--with-statedir=/run/nfs \
 	--with-rpcgen=$(HOST_DIR)/bin/rpcgen
 
-HOST_NFS_UTILS_DEPENDENCIES = host-pkgconf host-libtirpc host-libevent host-sqlite host-util-linux
+HOST_NFS_UTILS_DEPENDENCIES = host-pkgconf host-libtirpc host-libevent host-libnl host-sqlite host-util-linux
 
 HOST_NFS_UTILS_CONF_OPTS = \
 	--enable-tirpc \
Signature · 6 lines
2.47.3

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by on v2 1/2
#3 lore raw
In reply to Giulio Benetti

Hi Giulio,

Quoted 1 line

host-libnl is needed for host-nfs-utils.

Quoted 13 lines

---
V1->V2:
* drop HOST_LIBNL_INSTALL_STAGING = YES as pointed by Thomas Petazzoni

---
 package/libnl/libnl.mk | 3 +++
 1 file changed, 3 insertions(+)
package/libnl/libnl.mk +0 -0
index a0441b7835..b1254d2ba0 100644

package/libnl/libnl.mk LIBNL_CPE_ID_VALID = YES · line 16

Quoted 4 lines
package/libnl/libnl.mk +1 -0
@@ -13,6 +13,8 @@ LIBNL_CPE_ID_VALID = YES
 LIBNL_INSTALL_STAGING = YES
 LIBNL_DEPENDENCIES = host-bison host-flex host-pkgconf
 
+HOST_LIBNL_DEPENDENCIES = host-bison host-flex host-pkgconf

I would personally reuse already defined variable:
HOST_LIBNL_DEPENDENCIES = $(LIBNL_DEPENDENCIES) but I know that's not how is usually in Buildroot defined.

Kind regards,
Petr

package/libnl/libnl.mk LIBNL_CONF_OPTS += --disable-unit-tests · line 32

Quoted 9 lines
package/libnl/libnl.mk +2 -0
+
 ifeq ($(BR2_PACKAGE_LIBNL_TOOLS),y)
 LIBNL_CONF_OPTS += --enable-cli
 else
@@ -27,3 +29,4 @@ LIBNL_CONF_OPTS += --disable-unit-tests
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot