Skip to contentSkip to conversation

pinctrl: qcom: sdm670-lpass-lpi: label variables as static

PATCH In review Richard Acayan 2 participants 2 messages Apr 8 – Apr 9

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: qcom: sdm670-lpass-lpi: label variables as static

These variables are local to the driver and have no need to be exported to the global namespace. Label them as static to fix compiler warnings.

---
 drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/qcom/pinctrl-sdm670-lpass-lpi.c +2 -2
index 6270c6d09c22..858146c408d0 100644
@@ -80,7 +80,7 @@ static const char * const pdm_sync_groups[] = { "gpio19" };
 static const char * const pdm_tx_groups[] = { "gpio20" };
 static const char * const slimbus_clk_groups[] = { "gpio18" };
 
-const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
+static const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
 	LPI_PINGROUP(0, LPI_NO_SLEW, _, _, _, _),
 	LPI_PINGROUP(1, LPI_NO_SLEW, _, _, _, _),
 	LPI_PINGROUP(2, LPI_NO_SLEW, _, _, _, _),
@@ -115,7 +115,7 @@ const struct lpi_pingroup sdm670_lpi_pinctrl_groups[] = {
 	LPI_PINGROUP(31, LPI_NO_SLEW, _, _, _, _),
 };
 
-const struct lpi_function sdm670_lpi_pinctrl_functions[] = {
+static const struct lpi_function sdm670_lpi_pinctrl_functions[] = {
 	LPI_FUNCTION(comp_rx),
 	LPI_FUNCTION(dmic1_clk),
 	LPI_FUNCTION(dmic1_data),
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 7 lines · Richard Acayan

These variables are local to the driver and have no need to be exported to the global namespace. Label them as static to fix compiler warnings.

Oh I just made the same patch, nevermind I'll apply this one instead.

Yours,
Linus Walleij