tests/kms_writeback: fix coding style issues
PATCH 1/1 tests/kms_writeback: fix coding style issues
Fix missing spaces after comma in two igt_skip_on_f() calls and in the writeback-invalid-parameters subtest description strings.
--- tests/kms_writeback.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
tests/kms_writeback.c +6 -6
@@ -58,8 +58,8 @@* Description: Validate WRITEBACK_FB_ID with valid and invalid options * * SUBTEST: writeback-invalid-parameters -* Description: Writeback has a couple of parameters linked together(output -* framebuffer and fence); this test goes throughthe combination +* Description: Writeback has a couple of parameters linked together (output +* framebuffer and fence); this test goes through the combination * of possible bad options * * SUBTEST: writeback-pixel-formats
@@ -620,8 +620,8 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)drmModeFreePropertyBlob (formats_blob); } -igt_describe ("Writeback has a couple of parameters linked together" -"(output framebuffer and fence); this test goes through" +igt_describe ("Writeback has a couple of parameters linked together " +"(output framebuffer and fence); this test goes through " "the combination of possible bad options" ); igt_subtest("writeback-invalid-parameters") {igt_fb_t invalid_output_fb;
@@ -644,7 +644,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)igt_fb_t output_fb;igt_skip_on (data.dump_check || data.list_modes); -igt_skip_on_f (!(data.supported_colors &XRGB8888 ),"DRM_FORMAT_XRGB8888 is unsupported\n" ); +igt_skip_on_f (!(data.supported_colors &XRGB8888 ),"DRM_FORMAT_XRGB8888 is unsupported\n" ); fb_id = igt_create_fb(display.drm_fd, mode.hdisplay, mode.vdisplay, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
@@ -678,7 +678,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)igt_fb_t output_fb;igt_skip_on (data.dump_check || data.list_modes); -igt_skip_on_f (!(data.supported_colors &XRGB8888 ),"DRM_FORMAT_XRGB8888 is unsupported\n" ); +igt_skip_on_f (!(data.supported_colors &XRGB8888 ),"DRM_FORMAT_XRGB8888 is unsupported\n" ); fb_id = igt_create_fb(display.drm_fd, mode.hdisplay, mode.vdisplay, DRM_FORMAT_XRGB8888, igt_fb_mod_to_tiling(0),
Signature · 1 line
2.43.0
Quoted 6 lines
Subject: [PATCH] tests/kms_writeback: fix coding style issues
Fix missing spaces after comma in two
igt_skip_on_f()calls and in the writeback-invalid-parameters subtest description strings.Signed-off-by Alex Hung <[email protected]>
LGTM,
Quoted 59 lines
--- tests/kms_writeback.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)tests/kms_writeback.c index renamed from tests/kms_writeback.c +0
-0
f15abba96..5031fcb83100644tests/kms_writeback.c +4
-4@@ -58,8 +58,8 @@* Description: Validate WRITEBACK_FB_ID with valid and invalid options * * SUBTEST: writeback-invalid-parameters -* Description: Writeback has a couple of parameters linked together(output -* framebuffer and fence); this test goes throughthe combination +* Description: Writeback has a couple of parameters linked together (output +* framebuffer and fence); this test goes through the combination * of possible bad options * * SUBTEST: writeback-pixel-formats @@ -620,8 +620,8 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)drmModeFreePropertyBlob (formats_blob); } -igt_describe ("Writeback has a couple of parameters linked together" -"(output framebuffer and fence); this test goes through" +igt_describe ("Writeback has a couple of parameters linked together " +"(output framebuffer and fence); this test goes through " "the combination of possible bad options" ); igt_subtest("writeback-invalid-parameters") {tests/kms_writeback.c +2
-1igt_fb_t invalid_output_fb;@@ -644,7 +644,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)igt_fb_t output_fb;igt_skip_on (data.dump_check || data.list_modes); -igt_skip_on_f (!(data.supported_colors & XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n"); +igt_skip_on_f (!(data.supported_colors &XRGB8888 ), +"DRM_FORMAT_XRGB8888 is unsupported\n" ); fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,mode.vdisplay,
tests/kms_writeback.c +2
-1DRM_FORMAT_XRGB8888 , DRM_FORMAT_MOD_LINEAR,@@ -678,7 +678,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)igt_fb_t output_fb;igt_skip_on (data.dump_check || data.list_modes); -igt_skip_on_f (!(data.supported_colors & XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n"); +igt_skip_on_f (!(data.supported_colors &XRGB8888 ), +"DRM_FORMAT_XRGB8888 is unsupported\n" ); fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,mode.vdisplay,
tests/kms_writeback.c +0
-1DRM_FORMAT_XRGB8888 , igt_fb_mod_to_tiling(0), --2.43.0
Hi Kandpal,,
Quoted 10 lines · Suraj
Quoted 6 lines
Subject: [PATCH] tests/kms_writeback: fix coding style issues
Fix missing spaces after comma in two
igt_skip_on_f()calls and in the writeback-invalid-parameters subtest description strings.Signed-off-by Alex Hung <[email protected]>LGTM,
Reviewed-by Suraj Kandpal <[email protected]>
Thank you all, pushed.
Regards,
Kamil
Quoted 60 lines
Quoted 59 lines
--- tests/kms_writeback.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)tests/kms_writeback.c index renamed from tests/kms_writeback.c +0
-0
f15abba96..5031fcb83100644tests/kms_writeback.c +4
-4@@ -58,8 +58,8 @@* Description: Validate WRITEBACK_FB_ID with valid and invalid options * * SUBTEST: writeback-invalid-parameters -* Description: Writeback has a couple of parameters linked together(output -* framebuffer and fence); this test goes throughthe combination +* Description: Writeback has a couple of parameters linked together (output +* framebuffer and fence); this test goes through the combination * of possible bad options * * SUBTEST: writeback-pixel-formats @@ -620,8 +620,8 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)drmModeFreePropertyBlob (formats_blob); } -igt_describe ("Writeback has a couple of parameters linked together" -"(output framebuffer and fence); this test goes through" +igt_describe ("Writeback has a couple of parameters linked together " +"(output framebuffer and fence); this test goes through " "the combination of possible bad options" ); igt_subtest("writeback-invalid-parameters") {tests/kms_writeback.c +2
-1igt_fb_t invalid_output_fb;@@ -644,7 +644,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)igt_fb_t output_fb;igt_skip_on (data.dump_check || data.list_modes); -igt_skip_on_f (!(data.supported_colors & XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n"); +igt_skip_on_f (!(data.supported_colors &XRGB8888 ), +"DRM_FORMAT_XRGB8888 is unsupported\n" ); fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,mode.vdisplay,
tests/kms_writeback.c +2
-1DRM_FORMAT_XRGB8888 , DRM_FORMAT_MOD_LINEAR,@@ -678,7 +678,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)igt_fb_t output_fb;igt_skip_on (data.dump_check || data.list_modes); -igt_skip_on_f (!(data.supported_colors & XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n"); +igt_skip_on_f (!(data.supported_colors &XRGB8888 ), +"DRM_FORMAT_XRGB8888 is unsupported\n" ); fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,mode.vdisplay,
tests/kms_writeback.c +0
-1DRM_FORMAT_XRGB8888 , igt_fb_mod_to_tiling(0), --2.43.0
Patchwork
CI✗ Fi.CI.BAT: failure for tests/kms_writeback: fix coding style issues
In reply to Alex Hung== Series Details ==
== Series Details ==
Series: tests/kms_writeback: fix coding style issues
URL : https://patchwork.freedesktop.org/series/164575/
State : failure
== Summary ==
Series 164575 revision 1 was fully merged or fully failed: no git log