ceph: fix a buffer leak in __ceph_setxattr()
Subsystems (2)
Viacheslav Dubeyko
maintainerPATCH 1/1 ceph: fix a buffer leak in __ceph_setxattr()
From: Viacheslav Dubeyko <[email protected]>
The old_blob in __ceph_setxattr() can store ci->i_xattrs.prealloc_blob value during the retry. However, it is never called the ceph_buffer_put() for the old_blob object. This patch fixes the issue of the buffer leak.
Signed-off-by Viacheslav Dubeyko <[email protected]>
cc Alex Markuze <[email protected]>
cc Ilya Dryomov <[email protected]>
cc Patrick Donnelly <[email protected]>
cc Ceph Development <[email protected]>
--- fs/ceph/xattr.c | 1 + 1 file changed, 1 insertion(+)
fs/ceph/xattr.c +1 -0
@@ -1294,6 +1294,7 @@ int __ceph_setxattr(struct inode *inode, const char *name, do_sync:spin_unlock (&ci->i_ceph_lock); +ceph_buffer_put (old_blob); do_sync_unlocked:if (lock_snap_rwsem)up_read (&mdsc->snap_rwsem);
Signature · 1 line
2.53.0
Reviewed-by Alex Markuze <[email protected]>
Quoted 33 lines · Viacheslav Dubeyko
From: Viacheslav Dubeyko <[email protected]>
The
old_blobin__ceph_setxattr()can storeci->i_xattrs.prealloc_blobvalue during the retry. However, it is never called theceph_buffer_put()for theold_blobobject. This patch fixes the issue of the buffer leak.Signed-off-by Viacheslav Dubeyko <[email protected]>cc Alex Markuze <[email protected]>cc Ilya Dryomov <[email protected]>cc Patrick Donnelly <[email protected]>cc Ceph Development <[email protected]>--- fs/ceph/xattr.c | 1 + 1 file changed, 1 insertion(+)fs/ceph/xattr.c +1
-1@@ -1294,6 +1294,7 @@ int __ceph_setxattr(struct inode *inode, const char *name, do_sync:spin_unlock (&ci->i_ceph_lock); +ceph_buffer_put (old_blob); do_sync_unlocked:if (lock_snap_rwsem)up_read (&mdsc->snap_rwsem); --2.53.0