netkit: Don't emit scrub attribute for single device mode
Daniel Borkmann
maintainerPATCH 1/1 netkit: Don't emit scrub attribute for single device mode
When userspace reads a single mode netkit device via RTM_GETLINK, it receives IFLA_NETKIT_SCRUB=NETKIT_SCRUB_DEFAULT attribute from netkit_fill_info(). If that attribute is echoed back to recreate the device, the seen_scrub presence check in netkit_new_link() causes creation to fail with -EOPNOTSUPP. Since it has no meaning for single devices at this point, just don't dump it.
--- drivers/net/netkit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/netkit.c +2 -1
@@ -1214,7 +1214,8 @@ static int netkit_fill_info(struct sk_buff *skb, const struct net_device *dev)return -EMSGSIZE ;if (nla_put_u32 (skb,IFLA_NETKIT_MODE , nk->mode))return -EMSGSIZE ; -if (nla_put_u32 (skb,IFLA_NETKIT_SCRUB , nk->scrub)) +if (nk->pair ==NETKIT_DEVICE_PAIR && +nla_put_u32 (skb,IFLA_NETKIT_SCRUB , nk->scrub))return -EMSGSIZE ;if (nla_put_u16 (skb,IFLA_NETKIT_HEADROOM , dev->needed_headroom))return -EMSGSIZE ;
Signature · 1 line
2.43.0
Quoted 18 lines · Daniel Borkmann
When userspace reads a single mode netkit device via
RTM_GETLINK, it receives IFLA_NETKIT_SCRUB=NETKIT_SCRUB_DEFAULT attribute fromnetkit_fill_info(). If that attribute is echoed back to recreate the device, theseen_scrubpresence check innetkit_new_link()causes creation to fail with-EOPNOTSUPP. Since it has no meaning for single devices at this point, just don't dump it.Fixes 481038960538 ("netkit: Add single device mode for netkit")Signed-off-by Daniel Borkmann <[email protected]>--- drivers/net/netkit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/net/netkit.c +0
-0
drivers/net/netkit.c static int netkit_fill_info(struct sk_buff *skb, const struct net_device *dev) · line 1221
Quoted 9 lines
drivers/net/netkit.c +2
-1@@ -1214,7 +1214,8 @@ static int netkit_fill_info(struct sk_buff *skb, const struct net_device *dev)return -EMSGSIZE ;if (nla_put_u32 (skb,IFLA_NETKIT_MODE , nk->mode))return -EMSGSIZE ; -if (nla_put_u32 (skb,IFLA_NETKIT_SCRUB , nk->scrub)) +if (nk->pair ==NETKIT_DEVICE_PAIR && +nla_put_u32 (skb,IFLA_NETKIT_SCRUB , nk->scrub))return -EMSGSIZE ;if (nla_put_u16 (skb,IFLA_NETKIT_HEADROOM , dev->needed_headroom))return -EMSGSIZE ;
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Fri, 10 Apr 2026 09:23:34 +0200 you wrote:
When userspace reads a single mode netkit device via
RTM_GETLINK, it receives IFLA_NETKIT_SCRUB=NETKIT_SCRUB_DEFAULT attribute fromnetkit_fill_info(). If that attribute is echoed back to recreate the device, theseen_scrubpresence check innetkit_new_link()causes creation to fail with-EOPNOTSUPP. Since it has no meaning for single devices at this point, just don't dump it.[...]
Here is the summary with links:
- [net-next] netkit: Don't emit scrub attribute for single device mode
https://git.kernel.org/netdev/net-next/c/e530b484b705
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html