Skip to contentSkip to conversation

ALSA: usb-audio: Add quirk for PreSonus AudioBox USB

PATCH Applied Abhinav Mahadevan 2 participants 8 messages Apr 10 – Apr 29 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: usb-audio: Add quirk for PreSonus AudioBox USB

The PreSonus AudioBox USB (0x194f:0x0301) only supports S24_3LE format for both playback and capture. It does not support S16_LE despite being a USB full-speed device. Add explicit format quirks for both the playback (interface 2) and capture (interface 3) interfaces to ensure correct format negotiation.

---
 sound/usb/quirks-table.h | 48 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)
sound/usb/quirks-table.h +48 -0
index b6dfe3b63..803e03d4d 100644
@@ -2652,6 +2652,54 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
+{
+	/*
+	 * The AudioBox USB advertises S24_3LE as the only supported format
+	 * for both playback and capture. It does not support S16_LE despite
+	 * being a USB full-speed device.
+	 */
+	USB_DEVICE(0x194f, 0x0301),
+	QUIRK_DRIVER_INFO {
+		.vendor_name = "PreSonus",
+		.product_name = "AudioBox USB",
+		QUIRK_DATA_COMPOSITE {
+			{ QUIRK_DATA_IGNORE(0) },
+			{
+				QUIRK_DATA_AUDIOFORMAT(2) {
+					.formats = SNDRV_PCM_FMTBIT_S24_3LE,
+					.channels = 2,
+					.iface = 2,
+					.altsetting = 1,
+					.altset_idx = 1,
+					.attributes = 0,
+					.endpoint = 0x01,
+					.ep_attr = USB_ENDPOINT_XFER_ISOC,
+					.rates = SNDRV_PCM_RATE_44100 |
+						 SNDRV_PCM_RATE_48000,
+					.rate_min = 44100,
+					.rate_max = 48000,
+				}
+			},
+			{
+				QUIRK_DATA_AUDIOFORMAT(3) {
+					.formats = SNDRV_PCM_FMTBIT_S24_3LE,
+					.channels = 2,
+					.iface = 3,
+					.altsetting = 1,
+					.altset_idx = 1,
+					.attributes = 0,
+					.endpoint = 0x82,
+					.ep_attr = USB_ENDPOINT_XFER_ISOC,
+					.rates = SNDRV_PCM_RATE_44100 |
+						 SNDRV_PCM_RATE_48000,
+					.rate_min = 44100,
+					.rate_max = 48000,
+				}
+			},
+			QUIRK_COMPOSITE_END
+		}
+	}
+},
 #endif /* disabled */
 
 {
Signature · 1 line
2.43.0
Applied
#1 lore raw
Quoted 8 lines · Abhinav Mahadevan

The PreSonus AudioBox USB (0x194f:0x0301) only supports S24_3LE format for both playback and capture. It does not support S16_LE despite being a USB full-speed device. Add explicit format quirks for both the playback (interface 2) and capture (interface 3) interfaces to ensure correct format negotiation.

Thanks, applied now.

Takashi

#2 lore raw

PATCH v2 1/1 ALSA: usb-audio: Add quirk for PreSonus AudioBox USB

In reply to Abhinav Mahadevan

The PreSonus AudioBox USB (0x194f:0x0301) only supports S24_3LE format for both playback and capture. It does not support S16_LE despite being a USB full-speed device. Add explicit format quirks for both the playback (interface 2) and capture (interface 3) interfaces to ensure correct format negotiation.

---

v2: Fix placement - entry was incorrectly inside a #if 0 disabled block. Moved to after the #endif /* disabled */.

 sound/usb/quirks-table.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/usb/quirks-table.h +3 -1
index 803e03d4d..4e9cfff40 100644
@@ -2652,6 +2652,9 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
+
+#endif /* disabled */
+
 {
 	/*
 	 * The AudioBox USB advertises S24_3LE as the only supported format
@@ -2700,7 +2703,6 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
-#endif /* disabled */
 
 {
 	/*
Signature · 1 line
2.43.0
#3 lore raw
Quoted 7 lines · Abhinav Mahadevan

The PreSonus AudioBox USB (0x194f:0x0301) only supports S24_3LE format for both playback and capture. It does not support S16_LE despite being a USB full-speed device. Add explicit format quirks for both the playback (interface 2) and capture (interface 3) interfaces to ensure correct format negotiation.

Quoted 5 lines

---

v2: Fix placement - entry was incorrectly inside a #if 0 disabled block. Moved to after the #endif /* disabled */.

The patch description doesn't match with what you actually change here. Also, as it's a correction, it should have a Fixes tag. Please update the description and resubmit.

thanks,

Takashi

Quoted 29 lines
 
 sound/usb/quirks-table.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/usb/quirks-table.h +3 -1
index 803e03d4d..4e9cfff40 100644
@@ -2652,6 +2652,9 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
+
+#endif /* disabled */
+
 {
 	/*
 	 * The AudioBox USB advertises S24_3LE as the only supported format
@@ -2700,7 +2703,6 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
-#endif /* disabled */
 
 {
 	/*
Signature · 1 line
2.43.0
#4 lore raw

PATCH v3 1/1 ALSA: usb-audio: Add quirk for PreSonus AudioBox USB

In reply to Abhinav Mahadevan

The PreSonus AudioBox USB (0x194f:0x0301) only advertises S24_3LE for both playback and capture interfaces. Add an explicit entry to the quirks table to ensure correct format handling for this device.

Fixes 099cce2b5 ("ALSA: usb-audio: Add quirk for PreSonus AudioBox USB")

---

v3: Update patch description to accurately reflect the change (adding a quirks table entry, not fixing format negotiation). Add Fixes tag referencing the original commit.

v2: Fix placement - entry was incorrectly inside a #if 0 disabled block. Moved to after the #endif /* disabled */.

 sound/usb/quirks-table.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/usb/quirks-table.h +3 -1
index 803e03d4d..4e9cfff40 100644
@@ -2652,6 +2652,9 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
+
+#endif /* disabled */
+
 {
 	/*
 	 * The AudioBox USB advertises S24_3LE as the only supported format
@@ -2700,7 +2703,6 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
-#endif /* disabled */
 
 {
 	/*
Signature · 1 line
2.43.0
#5 lore raw
Quoted 6 lines · Abhinav Mahadevan

The PreSonus AudioBox USB (0x194f:0x0301) only advertises S24_3LE for both playback and capture interfaces. Add an explicit entry to the quirks table to ensure correct format handling for this device.

Fixes 099cce2b5 ("ALSA: usb-audio: Add quirk for PreSonus AudioBox USB")

Non-existing commit ID for the upstream.
And, you'll have to put 12 letters SHA id here.

Quoted 5 lines

---

v3: Update patch description to accurately reflect the change (adding a quirks table entry, not fixing format negotiation).

... and it's not exactly what *this* patch does!
You don't have to repeat the same text you already gave in the original commit at all.

Basically this patch *corrects* the position of the quirk entry that was mistakenly put into the disabled block in the previous commit.

Please resubmit with a proper patch description and Fixes tag again.

thanks,

Takashi

#6 lore raw

PATCH v4 1/1 ALSA: usb-audio: Fix quirk entry placement for PreSonus AudioBox USB

In reply to Abhinav Mahadevan

The quirk entry for PreSonus AudioBox USB was mistakenly placed inside a disabled #if 0 block. Move it to the correct position after the

Fixes 34fe4a9df247 ("ALSA: usb-audio: Add quirk for PreSonus AudioBox USB")

---

v4: Use correct upstream commit hash in Fixes tag (12 characters). Rewrite patch description to accurately describe this patch - correcting the position of the entry from inside a disabled #if 0 block to after the #endif /* disabled */.

 sound/usb/quirks-table.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/usb/quirks-table.h +3 -1
index 803e03d4d..4e9cfff40 100644
@@ -2652,6 +2652,9 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
+
+#endif /* disabled */
+
 {
 	/*
 	 * The AudioBox USB advertises S24_3LE as the only supported format
@@ -2700,7 +2703,6 @@ YAMAHA_DEVICE(0x7010, "UB99"),
 		}
 	}
 },
-#endif /* disabled */
 
 {
 	/*
Signature · 1 line
2.43.0
#7 lore raw

Re: [PATCH v4] ALSA: usb-audio: Fix quirk entry placement for PreSonus AudioBox USB

Quoted 6 lines · Abhinav Mahadevan

The quirk entry for PreSonus AudioBox USB was mistakenly placed inside a disabled #if 0 block. Move it to the correct position after the

Fixes 34fe4a9df247 ("ALSA: usb-audio: Add quirk for PreSonus AudioBox USB")

Applied now. Thanks.

Takashi