Skip to contentSkip to conversation

net: phy: realtek: use LEDCR page number define on RTL8211F

PATCH Applied Aleksander Jan Bajkowski 3 participants 3 messages Apr 11 – Apr 13

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phy: realtek: use LEDCR page number define on RTL8211F

Replace the magic number with an existing define for the LEDCR register page number on the RTL8211F.

---
 drivers/net/phy/realtek/realtek_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/phy/realtek/realtek_main.c +3 -2
index 75565fbdbf6d..536cbb3820eb 100644
@@ -874,7 +874,7 @@ static int rtl8211f_led_hw_control_get(struct phy_device *phydev, u8 index,
 	if (index >= RTL8211x_LED_COUNT)
 		return -EINVAL;
 
-	val = phy_read_paged(phydev, 0xd04, RTL8211F_LEDCR);
+	val = phy_read_paged(phydev, RTL8211F_LEDCR_PAGE, RTL8211F_LEDCR);
 	if (val < 0)
 		return val;
 
@@ -936,7 +936,8 @@ static int rtl8211f_led_hw_control_set(struct phy_device *phydev, u8 index,
 	reg <<= RTL8211F_LEDCR_SHIFT * index;
 	reg |= RTL8211F_LEDCR_MODE;	 /* Mode B */
 
-	return phy_modify_paged(phydev, 0xd04, RTL8211F_LEDCR, mask, reg);
+	return phy_modify_paged(phydev, RTL8211F_LEDCR_PAGE, RTL8211F_LEDCR,
+				mask, reg);
 }
 
 static int rtl8211e_led_hw_control_get(struct phy_device *phydev, u8 index,
Signature · 1 line
2.51.0
#2 lore raw
In reply to Aleksander Jan Bajkowski
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Sat, 11 Apr 2026 12:51:45 +0200 you wrote:

Replace the magic number with an existing define for the LEDCR register page number on the RTL8211F.

---
 drivers/net/phy/realtek/realtek_main.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Here is the summary with links:
- net: phy: realtek: use LEDCR page number define on RTL8211F

    https://git.kernel.org/netdev/net-next/c/43a2deae3661

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html