Skip to contentSkip to conversation

arm64: dts: st: Fix SAI addresses on stm32mp251

PATCH In review Marek Vasut 3 participants 3 messages Apr 11 – Jun 1

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: st: Fix SAI addresses on stm32mp251

The second field of SAI register addresses should be within 0x3f0 bytes from the start of the SAI register addresses, the second field describes the ID registers which are at that addrses. Currently, the second field does not match RM, fix it.

Fixes bf26d75a95f1 ("arm64: dts: st: add sai support on stm32mp251")

---
Cc: Alexandre Torgue <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Olivier Moysan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
 arch/arm64/boot/dts/st/stm32mp251.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/st/stm32mp251.dtsi +4 -4
index 673fbc5632e69..9c63fdb5a885a 100644
@@ -1202,7 +1202,7 @@ spi5: spi@40280000 {
 
 			sai1: sai@40290000 {
 				compatible = "st,stm32mp25-sai";
-				reg = <0x40290000 0x4>, <0x4029a3f0 0x10>;
+				reg = <0x40290000 0x4>, <0x402903f0 0x10>;
 				ranges = <0 0x40290000 0x400>;
 				#address-cells = <1>;
 				#size-cells = <1>;
@@ -1236,7 +1236,7 @@ sai1b: audio-controller@40290024 {
 
 			sai2: sai@402a0000 {
 				compatible = "st,stm32mp25-sai";
-				reg = <0x402a0000 0x4>, <0x402aa3f0 0x10>;
+				reg = <0x402a0000 0x4>, <0x402a03f0 0x10>;
 				ranges = <0 0x402a0000 0x400>;
 				#address-cells = <1>;
 				#size-cells = <1>;
@@ -1270,7 +1270,7 @@ sai2b: audio-controller@402a0024 {
 
 			sai3: sai@402b0000 {
 				compatible = "st,stm32mp25-sai";
-				reg = <0x402b0000 0x4>, <0x402ba3f0 0x10>;
+				reg = <0x402b0000 0x4>, <0x402b03f0 0x10>;
 				ranges = <0 0x402b0000 0x400>;
 				#address-cells = <1>;
 				#size-cells = <1>;
@@ -1362,7 +1362,7 @@ usart1: serial@40330000 {
 
 			sai4: sai@40340000 {
 				compatible = "st,stm32mp25-sai";
-				reg = <0x40340000 0x4>, <0x4034a3f0 0x10>;
+				reg = <0x40340000 0x4>, <0x403403f0 0x10>;
 				ranges = <0 0x40340000 0x400>;
 				#address-cells = <1>;
 				#size-cells = <1>;
Signature · 1 line
2.53.0
Reviewed-by on v1 1/1
#1 lore raw

Hi Marek,

Quoted 54 lines · Marek Vasut

The second field of SAI register addresses should be within 0x3f0 bytes from the start of the SAI register addresses, the second field describes the ID registers which are at that addrses. Currently, the second field does not match RM, fix it.

Fixes bf26d75a95f1 ("arm64: dts: st: add sai support on stm32mp251")

---
Cc: Alexandre Torgue <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Olivier Moysan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
  arch/arm64/boot/dts/st/stm32mp251.dtsi | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/st/stm32mp251.dtsi +3 -3
index 673fbc5632e69..9c63fdb5a885a 100644
@@ -1202,7 +1202,7 @@ spi5: spi@40280000 {
 
  			sai1: sai@40290000 {
  				compatible = "st,stm32mp25-sai";
-				reg = <0x40290000 0x4>, <0x4029a3f0 0x10>;
+				reg = <0x40290000 0x4>, <0x402903f0 0x10>;
  				ranges = <0 0x40290000 0x400>;
  				#address-cells = <1>;
  				#size-cells = <1>;
@@ -1236,7 +1236,7 @@ sai1b: audio-controller@40290024 {
 
  			sai2: sai@402a0000 {
  				compatible = "st,stm32mp25-sai";
-				reg = <0x402a0000 0x4>, <0x402aa3f0 0x10>;
+				reg = <0x402a0000 0x4>, <0x402a03f0 0x10>;
  				ranges = <0 0x402a0000 0x400>;
  				#address-cells = <1>;
  				#size-cells = <1>;
@@ -1270,7 +1270,7 @@ sai2b: audio-controller@402a0024 {
 
  			sai3: sai@402b0000 {
  				compatible = "st,stm32mp25-sai";
-				reg = <0x402b0000 0x4>, <0x402ba3f0 0x10>;
+				reg = <0x402b0000 0x4>, <0x402b03f0 0x10>;
  				ranges = <0 0x402b0000 0x400>;
  				#address-cells = <1>;
  				#size-cells = <1>;

arch/arm64/boot/dts/st/stm32mp251.dtsi usart1: serial@40330000 { · line 1368

Quoted 8 lines
arch/arm64/boot/dts/st/stm32mp251.dtsi +1 -1
@@ -1362,7 +1362,7 @@ usart1: serial@40330000 {
 
  			sai4: sai@40340000 {
  				compatible = "st,stm32mp25-sai";
-				reg = <0x40340000 0x4>, <0x4034a3f0 0x10>;
+				reg = <0x40340000 0x4>, <0x403403f0 0x10>;
  				ranges = <0 0x40340000 0x400>;
  				#address-cells = <1>;
  				#size-cells = <1>;

Thanks for your patch
BRs
Olivier

maintainer
#2 lore raw
In reply to Marek Vasut

Hi Marek

Quoted 54 lines · Marek Vasut

The second field of SAI register addresses should be within 0x3f0 bytes from the start of the SAI register addresses, the second field describes the ID registers which are at that addrses. Currently, the second field does not match RM, fix it.

Fixes bf26d75a95f1 ("arm64: dts: st: add sai support on stm32mp251")

---
Cc: Alexandre Torgue <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Maxime Coquelin <[email protected]>
Cc: Olivier Moysan <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

---
  arch/arm64/boot/dts/st/stm32mp251.dtsi | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm64/boot/dts/st/stm32mp251.dtsi +3 -3
index 673fbc5632e69..9c63fdb5a885a 100644
@@ -1202,7 +1202,7 @@ spi5: spi@40280000 {
 
  			sai1: sai@40290000 {
  				compatible = "st,stm32mp25-sai";
-				reg = <0x40290000 0x4>, <0x4029a3f0 0x10>;
+				reg = <0x40290000 0x4>, <0x402903f0 0x10>;
  				ranges = <0 0x40290000 0x400>;
  				#address-cells = <1>;
  				#size-cells = <1>;
@@ -1236,7 +1236,7 @@ sai1b: audio-controller@40290024 {
 
  			sai2: sai@402a0000 {
  				compatible = "st,stm32mp25-sai";
-				reg = <0x402a0000 0x4>, <0x402aa3f0 0x10>;
+				reg = <0x402a0000 0x4>, <0x402a03f0 0x10>;
  				ranges = <0 0x402a0000 0x400>;
  				#address-cells = <1>;
  				#size-cells = <1>;
@@ -1270,7 +1270,7 @@ sai2b: audio-controller@402a0024 {
 
  			sai3: sai@402b0000 {
  				compatible = "st,stm32mp25-sai";
-				reg = <0x402b0000 0x4>, <0x402ba3f0 0x10>;
+				reg = <0x402b0000 0x4>, <0x402b03f0 0x10>;
  				ranges = <0 0x402b0000 0x400>;
  				#address-cells = <1>;
  				#size-cells = <1>;

arch/arm64/boot/dts/st/stm32mp251.dtsi usart1: serial@40330000 { · line 1368

Quoted 8 lines
arch/arm64/boot/dts/st/stm32mp251.dtsi +1 -1
@@ -1362,7 +1362,7 @@ usart1: serial@40330000 {
 
  			sai4: sai@40340000 {
  				compatible = "st,stm32mp25-sai";
-				reg = <0x40340000 0x4>, <0x4034a3f0 0x10>;
+				reg = <0x40340000 0x4>, <0x403403f0 0x10>;
  				ranges = <0 0x40340000 0x400>;
  				#address-cells = <1>;
  				#size-cells = <1>;

Applied on stm32-next.

thanks!
Alex