staging: fbtft: fix coding style issue in fbtft-bus.c
Subsystems (3)
PATCH 1/1 staging: fbtft: fix coding style issue in fbtft-bus.c
Remove trailing space and comma before closing parenthesis ')' in define_fbtft_write_reg macro as reported by checkpatch.pl.
--- drivers/staging/fbtft/fbtft-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +2 -2
@@ -62,9 +62,9 @@ out: \ } \EXPORT_SYMBOL (func); -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8) define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16) -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)void fbtft_write_reg8_bus9 (struct fbtft_par *par,int len, ...) {
Signature · 1 line
2.47.3
PATCH v3 1/1 staging: fbtft: replace empty macro args with identity converter
The define_fbtft_write_reg macro calls 'modifier' as a function. Passing an empty token as modifier is undefined behavior in C for fixed-arity macros. Introduce fbtft_no_conv() as an identity function to replace the empty args in the no-conversion cases.
--- drivers/staging/fbtft/fbtft-bus.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +4 -2
@@ -11,6 +11,8 @@* *****************************************************************************/ +#define fbtft_no_conv (x) (x) +#define define_fbtft_write_reg (func, buffer_type, data_type, modifier) \ void func(struct fbtft_par *par, int len, ...) \ { \
@@ -62,9 +64,9 @@ out: \ } \EXPORT_SYMBOL (func); -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, fbtft_no_conv) define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16) -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, fbtft_no_conv)void fbtft_write_reg8_bus9 (struct fbtft_par *par,int len, ...) {
Signature · 1 line
2.47.3
Re: [PATCH v3] staging: fbtft: replace empty macro args with identity converter
Quoted 5 lines · Baker
The
define_fbtft_write_regmacro calls 'modifier' as a function. Passing an empty token as modifier is undefined behavior in C for fixed-arity macros. Introducefbtft_no_conv()as an identity function to replace the empty args in the no-conversion cases.
This trick is used in the kernel (usually for u8). If you really want to improve, use _Generic() instead.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Greg KH
maintainerRe: [PATCH v3] staging: fbtft: replace empty macro args with identity converter
Quoted 9 lines · Andy Shevchenko
Quoted 5 lines · Baker
The
define_fbtft_write_regmacro calls 'modifier' as a function. Passing an empty token as modifier is undefined behavior in C for fixed-arity macros. Introducefbtft_no_conv()as an identity function to replace the empty args in the no-conversion cases.This trick is used in the kernel (usually for u8). If you really want to improve, use
_Generic()instead.
No, sorry, this code is fine as-is.
greg k-h
Re: [PATCH v3] staging: fbtft: replace empty macro args with identity converter
Quoted 8 lines · Greg KH
Quoted 7 lines · Andy Shevchenko
Quoted 5 lines · Baker
The
define_fbtft_write_regmacro calls 'modifier' as a function. Passing an empty token as modifier is undefined behavior in C for fixed-arity macros. Introducefbtft_no_conv()as an identity function to replace the empty args in the no-conversion cases.
Quoted 4 lines
Quoted 2 lines
This trick is used in the kernel (usually for u8). If you really want to improve, use
_Generic()instead.No, sorry, this code is fine as-is.
Works for me. I suggested they explore the possibilities, it might be helpful somewhere else in case of the similar requirements (like in a new code).
Signature · 2 lines
With Best Regards, Andy Shevchenko
Greg KH
maintainerRe: [PATCH v3] staging: fbtft: replace empty macro args with identity converter
In reply to BakerQuoted 39 lines · Baker
The
define_fbtft_write_regmacro calls 'modifier' as a function. Passing an empty token as modifier is undefined behavior in C for fixed-arity macros. Introducefbtft_no_conv()as an identity function to replace the empty args in the no-conversion cases.Signed-off-by Baker <[email protected]>--- drivers/staging/fbtft/fbtft-bus.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/staging/fbtft/fbtft-bus.c +4
-2@@ -11,6 +11,8 @@* *****************************************************************************/ +#define fbtft_no_conv (x) (x) +#define define_fbtft_write_reg (func, buffer_type, data_type, modifier) \ void func(struct fbtft_par *par, int len, ...) \ { \@@ -62,9 +64,9 @@ out: \ } \EXPORT_SYMBOL (func); -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, ) +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, fbtft_no_conv) define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16) -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, ) +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, fbtft_no_conv)void fbtft_write_reg8_bus9 (struct fbtft_par *par,int len, ...) {Signature · 1 line
2.47.3
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- It looks like you did not use your "real" name for the patch on either the Signed-off-by: line, or the From: line (both of which have to match). Please read the kernel file, Documentation/process/submitting-patches.rst for how to do this correctly.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot
kernel test robot
build botkernel test robot noticed the following build errors:
Hi Baker,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Baker/staging-fbtft-fix-coding-style-issue-in-fbtft-bus-c/20260414-101811 base: staging/staging-testing patch link: https://lore.kernel.org/r/20260412173317.3329-1-mzndmzn%40gmail.com patch subject: [PATCH] staging: fbtft: fix coding style issue in fbtft-bus.c config: arm-randconfig-r072-20260414 (https://download.01.org/0day-ci/archive/20260414/[email protected]/config) compiler: arm-linux-gnueabi-gcc (GCC) 13.4.0 smatch: v0.5.0-9007-gcf3ea02b reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260414/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> drivers/staging/fbtft/fbtft-bus.c:65:53: error: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given
65 | define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
| ^
drivers/staging/fbtft/fbtft-bus.c:14: note: macro "define_fbtft_write_reg" defined here
14 | #define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
|
>> drivers/staging/fbtft/fbtft-bus.c:65:23: error: expected ';' before 'void'
65 | define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
| ^
| ;
drivers/staging/fbtft/fbtft-bus.c:67:57: error: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given
67 | define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
| ^
drivers/staging/fbtft/fbtft-bus.c:14: note: macro "define_fbtft_write_reg" defined here
14 | #define define_fbtft_write_reg(func, buffer_type, data_type, modifier) \
|
drivers/staging/fbtft/fbtft-bus.c:67:23: error: expected ';' before 'void'
67 | define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
| ^
| ;
68 |
69 | void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
| ~~~~ vim +/define_fbtft_write_reg +65 drivers/staging/fbtft/fbtft-bus.c
64
> 65 define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
66 define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
67 define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16)
68 Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki