drm/scheduler: signal scheduled fence when kill job
PATCH 1/1 drm/scheduler: signal scheduled fence when kill job
From: "Lin.Cao" <[email protected]>
[ Upstream commit 471db2c2d4f80ee94225a1ef246e4f5011733e50 ]
When an entity from application B is killed, drm_sched_entity_kill() removes all jobs belonging to that entity through drm_sched_entity_kill_jobs_work(). If application A's job depends on a scheduled fence from application B's job, and that fence is not properly signaled during the killing process, application A's dependency cannot be cleared.
This leads to application A hanging indefinitely while waiting for a dependency that will never be resolved. Fix this issue by ensuring that scheduled fences are properly signaled when an entity is killed, allowing dependent applications to continue execution.
[ Modified drm_sched_fence_scheduled(job->s_fence, NULL) to
drm_sched_fence_scheduled(job->s_fence) for kernel 6.1.y ]
--- drivers/gpu/drm/scheduler/sched_entity.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/scheduler/sched_entity.c +1 -0
@@ -196,6 +196,7 @@ static void drm_sched_entity_kill_jobs_work(struct work_struct *wrk) {struct drm_sched_job *job =container_of (wrk,typeof (*job), work); +drm_sched_fence_scheduled (job->s_fence,NULL );drm_sched_fence_finished (job->s_fence);WARN_ON (job->s_fence->parent); job->sched->ops->free_job (job);
Signature · 1 line
2.35.3
PATCH v2 1/1 drm/scheduler: signal scheduled fence when kill job
From: "Lin.Cao" <[email protected]>
[ Upstream commit 471db2c2d4f80ee94225a1ef246e4f5011733e50 ]
When an entity from application B is killed, drm_sched_entity_kill() removes all jobs belonging to that entity through drm_sched_entity_kill_jobs_work(). If application A's job depends on a scheduled fence from application B's job, and that fence is not properly signaled during the killing process, application A's dependency cannot be cleared.
This leads to application A hanging indefinitely while waiting for a dependency that will never be resolved. Fix this issue by ensuring that scheduled fences are properly signaled when an entity is killed, allowing dependent applications to continue execution.
[ Modified drm_sched_fence_scheduled(job->s_fence, NULL) to
drm_sched_fence_scheduled(job->s_fence) for kernel 6.1.y ]
---
v1 -> v2:
Forgot to git commit after modifying drm_sched_fence_scheduled(job->s_fence, NULL) to drm_sched_fence_scheduled(job->s_fence)
--- drivers/gpu/drm/scheduler/sched_entity.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/scheduler/sched_entity.c +1 -0
@@ -196,6 +196,7 @@ static void drm_sched_entity_kill_jobs_work(struct work_struct *wrk) {struct drm_sched_job *job =container_of (wrk,typeof (*job), work); +drm_sched_fence_scheduled (job->s_fence);drm_sched_fence_finished (job->s_fence);WARN_ON (job->s_fence->parent); job->sched->ops->free_job (job);
Signature · 1 line
2.35.3