bpf: btf: reject division by zero in btf_struct_walk for zero-size flex array elements
PATCH 1/1 bpf: btf: reject division by zero in btf_struct_walk for zero-size flex array elements
btf_struct_walk() computes off = (off - moff) % t->size when handling access to a flexible array member. If the element type is a zero-size struct (e.g., struct B {}), t->size is 0 and this causes a division- by-zero exception. On x86 this triggers a #DE fault resulting in a kernel panic.
The BTF validator does not reject zero-size structs: btf_struct_check_meta() passes trivially for vlen=0 structs, and btf_array_resolve() skips the overflow check for flex arrays (nelems=0). This allows a user to load crafted BTF containing struct B {}; struct A { int x; struct B flex[]; } and then trigger the crash when the verifier calls btf_struct_walk() during program load.
Fix this by adding a check for t->size == 0 before the modulo operation. When a zero-size element type is encountered in a flex array, return -EINVAL to reject the access.
Note: ARM64 is not affected because its udiv instruction returns 0 for division by zero (no exception). However, the resulting incorrect offset computation would still be a logic bug.
--- kernel/bpf/btf.c | 7 +++++++ 1 file changed, 7 insertions(+)
kernel/bpf/btf.c +7 -0
@@ -7103,6 +7103,13 @@ static int btf_struct_walk(struct bpf_verifier_log *log, const struct btf *btf,if (!btf_type_is_struct (t)) goto error; +/* Zero-size element type (e.g., empty struct) would cause +* division by zero below. Reject the access. +*/ +if (t->size ==0 ) { +bpf_log (log,"zero-size type in flex array\n" ); + goto error; + } off = (off - moff) % t->size; goto again;
Signature · 1 line
2.39.3 (Apple Git-145)
[email protected]
AI reviewShould the Fixes: tag reference a different commit? Commit 1dc92851849c adds BTF Var and DataSec support but does not modify btf_struct_walk() and does not introduce the modulo operation that causes…
Quoted 1 line
Fixes 1dc92851849c ("bpf: kernel side support for BTF Var and DataSec")
Should the Fixes: tag reference a different commit? Commit 1dc92851849c adds BTF Var and DataSec support but does not modify btf_struct_walk() and does not introduce the modulo operation that causes this bug.
The vulnerable line:
off = (off - moff) % t->size;
was introduced in 9c5f8a1008a1 ("bpf: Support variable length array in tracing programs"), which added the flex array handling path to btf_struct_walk(). The Fixes: tag pointing to the wrong commit could result in incomplete stable backports.
Suggested:
kernel/bpf/btf.c static int btf_struct_walk(struct bpf_verifier_log *log, const struct btf *btf, · line 7157
Quoted 11 lines
kernel/bpf/btf.c +3
-0@@ -7152,6 +7152,13 @@ static int btf_struct_walk(struct bpf_verifier_log *log, const struct btf *btf,if (!btf_type_is_struct (t)) goto error; +/* Zero-size element type (e.g., empty struct) would cause +* division by zero below. Reject the access. +*/
This isn't a bug, but the BPF subsystem uses the style where the opening /* is on its own line for multi-line comments:
/*
* Zero-size element type (e.g., empty struct) would cause
* division by zero below. Reject the access.
*/
kernel/bpf/btf.c static int btf_struct_walk(struct bpf_verifier_log *log, const struct btf *btf, · line 7114
Quoted 6 lines
kernel/bpf/btf.c +4
-0+if (t->size ==0 ) { +bpf_log (log,"zero-size type in flex array\n" ); + goto error; + } off = (off - moff) % t->size; goto again;
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/24334874776
Hi Dudu,
The "btf:" in the subject should be dropped. "bpf:" is enough.
BTW, a selftest is required to verify the change. If it is a BUG, the selftest should reproduce it without the fix.
Quoted 1 line · On 13/4/26 17:26, [email protected] wrote:
Quoted 1 line
Fixes 1dc92851849c ("bpf: kernel side support for BTF Var and DataSec")
[...]
Quoted 15 lines
kernel/bpf/btf.c static int btf_struct_walk(struct bpf_verifier_log *log, const struct btf *btf, · line 7157
Quoted 11 lines
kernel/bpf/btf.c +3
-0@@ -7152,6 +7152,13 @@ static int btf_struct_walk(struct bpf_verifier_log *log, const struct btf *btf,if (!btf_type_is_struct (t)) goto error; +/* Zero-size element type (e.g., empty struct) would cause +* division by zero below. Reject the access. +*/ This isn't a bug, but the BPF subsystem uses the style where the opening /* is on its own line for multi-line comments:
Quoted 5 lines
/*
* Zero-size element type (e.g., empty struct) would cause
* division by zero below. Reject the access.
*/
AI review of the comment style is correct.
Thanks,
Leon
Quoted 1 line
Quoted 1 line
[...]
Quoted 4 lines · Leon Hwang
Hi Dudu,
The "btf:" in the subject should be dropped. "bpf:" is enough.
And the target tree should be specified when respin:
[PATCH bpf v2] bpf: ...
That said, it is a BUG to be fixed on bpf tree. Thereafter, ci bot will run tests based on bpf tree.
Thanks,
Leon
Eduard Zingerman
maintainerQuoted 6 lines · Dudu Lu
btf_struct_walk()computesoff = (off - moff) % t->sizewhen handling access to a flexible array member. If the element type is a zero-size struct (e.g.,struct B {}),t->sizeis 0 and this causes a division- by-zero exception. On x86 this triggers a #DE fault resulting in a kernel panic.
Quoted 6 lines
The BTF validator does not reject zero-size structs:
btf_struct_check_meta()passes trivially for vlen=0 structs, andbtf_array_resolve()skips the overflow check for flex arrays (nelems=0). This allows a user to load crafted BTF containingstruct B {}; struct A { int x; struct B flex[]; }and then trigger the crash when the verifier callsbtf_struct_walk()during program load.
Could you please add a selftest as well?
[...]