drm/amdgpu/userq: unmap_helper dont return the queue state
Subsystems (2)
PATCH v4 1/1 drm/amdgpu/userq: unmap_helper dont return the queue state
We check for return value of amdgpu_userq_unmap_helper and compare it against the queue->state which is logically wrong and we should just check for failure and do the needfull.
Signed-off-by Sunil Khatri <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c +1 -1
@@ -645,7 +645,7 @@ amdgpu_userq_destroy(struct amdgpu_userq_mgr *uq_mgr, struct amdgpu_usermode_queamdgpu_userq_detect_and_reset_queues (uq_mgr); r =amdgpu_userq_unmap_helper (queue);/*TODO: It requires a reset for userq hw unmap error*/ -if (unlikely (r !=AMDGPU_USERQ_STATE_UNMAPPED )) { +if (r) {drm_warn (adev_to_drm (uq_mgr->adev),"trying to destroy a HW mapping userq\n" ); queue->state =AMDGPU_USERQ_STATE_HUNG ; }
Signature · 1 line
2.34.1