Skip to contentSkip to conversation

pinctrl: More compile testing

PATCH In review Krzysztof Kozlowski 5 participants 13 messages Apr 10 – Apr 28

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover pinctrl: More compile testing

Follows https://lore.kernel.org/r/[email protected]/
but should not depend on it anyhow.

More compile testing means better bot coverage. Plus having || COMPILE_TEST and obj-CONFIG_ARCH_FOO is kind of pointless.

I built these on arm, arm64, i386, x86_64, sparc, m68k, s390, riscv and powerpc. Branch is pushed also to LKP, so more build tests will follow.

Best regards,
Krzysztof

---
Krzysztof Kozlowski (4):
pinctrl: realtek: Enable compile testing
pinctrl: aspeed: Enable compile testing outside of ARCH_ASPEED
pinctrl: vt8500: Enable compile testing
ARM: realtek: MAINTAINERS: Include pin controller drivers

 MAINTAINERS                     |  1 +
 drivers/pinctrl/Makefile        |  6 +++---
 drivers/pinctrl/realtek/Kconfig | 12 ++++++------
 drivers/pinctrl/vt8500/Kconfig  | 13 +++++++------
 4 files changed, 17 insertions(+), 15 deletions(-)

---
base-commit: a53c56fc5daedea57de51c02ede0b48f055fd8b3
change-id: 20260410-pinctrl-testing-10edae894600

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>
#1 lore raw

PATCH 1/4 pinctrl: realtek: Enable compile testing

Enable compile testing for Realtek pin controller drivers for increased build and static checkers coverage. PINCTRL_RTD uses pinconf_generic_dt_node_to_map(), thus needs OF.

---
 drivers/pinctrl/Makefile        |  2 +-
 drivers/pinctrl/realtek/Kconfig | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)
drivers/pinctrl/Makefile +1 -1
index 9d33fa28a096..b054cfb99348 100644
@@ -82,7 +82,7 @@ obj-y				+= nuvoton/
 obj-y				+= nxp/
 obj-$(CONFIG_PINCTRL_PXA)	+= pxa/
 obj-y				+= qcom/
-obj-$(CONFIG_ARCH_REALTEK)      += realtek/
+obj-$(CONFIG_PINCTRL_RTD)	+= realtek/
 obj-$(CONFIG_PINCTRL_RENESAS)	+= renesas/
 obj-$(CONFIG_PINCTRL_SAMSUNG)	+= samsung/
 obj-y				+= sophgo/
drivers/pinctrl/realtek/Kconfig +6 -6
index 054e85db99e7..a156c4ef556e 100644
@@ -2,8 +2,8 @@
 
 config PINCTRL_RTD
 	tristate "Realtek DHC core pin controller driver"
-	depends on ARCH_REALTEK
-	default y
+	depends on ARCH_REALTEK || (COMPILE_TEST && OF)
+	default ARCH_REALTEK
 	select PINMUX
 	select GENERIC_PINCONF
 	select REGMAP_MMIO
@@ -11,22 +11,22 @@ config PINCTRL_RTD
 config PINCTRL_RTD1619B
 	tristate "Realtek DHC 1619B pin controller driver"
 	depends on PINCTRL_RTD
-	default y
+	default ARCH_REALTEK
 
 config PINCTRL_RTD1319D
 	tristate "Realtek DHC 1319D pin controller driver"
 	depends on PINCTRL_RTD
-	default y
+	default ARCH_REALTEK
 
 config PINCTRL_RTD1315E
 	tristate "Realtek DHC 1315E pin controller driver"
 	depends on PINCTRL_RTD
-	default y
+	default ARCH_REALTEK
 
 config PINCTRL_RTD1625
 	tristate "Realtek DHC 1625 pin controller driver"
 	depends on PINCTRL_RTD
-	default y
+	default ARCH_REALTEK
 	help
 	  This driver enables support for the pin controller on the Realtek
 	  RTD1625 SoCs.
Signature · 1 line
2.51.0
maintainer Reviewed-by on v1 1/4
#2 lore raw

RE: [PATCH 1/4] pinctrl: realtek: Enable compile testing

Quoted 67 lines

Enable compile testing for Realtek pin controller drivers for increased build and static checkers coverage. PINCTRL_RTD uses pinconf_generic_dt_node_to_map(), thus needs OF.

---
 drivers/pinctrl/Makefile        |  2 +-
 drivers/pinctrl/realtek/Kconfig | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)
drivers/pinctrl/Makefile index renamed from drivers/pinctrl/Makefile +0 -0

9d33fa28a096..b054cfb99348 100644

drivers/pinctrl/Makefile +1 -1
@@ -82,7 +82,7 @@ obj-y                         += nuvoton/
 obj-y                          += nxp/
 obj-$(CONFIG_PINCTRL_PXA)      += pxa/
 obj-y                          += qcom/
-obj-$(CONFIG_ARCH_REALTEK)      += realtek/
+obj-$(CONFIG_PINCTRL_RTD)      += realtek/
 obj-$(CONFIG_PINCTRL_RENESAS)  += renesas/
 obj-$(CONFIG_PINCTRL_SAMSUNG)  += samsung/
 obj-y                          += sophgo/
drivers/pinctrl/realtek/Kconfig +6 -7
index 054e85db99e7..a156c4ef556e 100644
@@ -2,8 +2,8 @@
 
 config PINCTRL_RTD
        tristate "Realtek DHC core pin controller driver"
-       depends on ARCH_REALTEK
-       default y
+       depends on ARCH_REALTEK || (COMPILE_TEST && OF)
+       default ARCH_REALTEK
        select PINMUX
        select GENERIC_PINCONF
        select REGMAP_MMIO
@@ -11,22 +11,22 @@ config PINCTRL_RTD
 config PINCTRL_RTD1619B
        tristate "Realtek DHC 1619B pin controller driver"
        depends on PINCTRL_RTD
-       default y
+       default ARCH_REALTEK
 
 config PINCTRL_RTD1319D
        tristate "Realtek DHC 1319D pin controller driver"
        depends on PINCTRL_RTD
-       default y
+       default ARCH_REALTEK
 
 config PINCTRL_RTD1315E
        tristate "Realtek DHC 1315E pin controller driver"
        depends on PINCTRL_RTD
-       default y
+       default ARCH_REALTEK
 
 config PINCTRL_RTD1625
        tristate "Realtek DHC 1625 pin controller driver"
        depends on PINCTRL_RTD
-       default y
+       default ARCH_REALTEK
        help
          This driver enables support for the pin controller on the Realtek
          RTD1625 SoCs.
 
--
Quoted 1 line

2.51.0

#3 lore raw

PATCH 2/4 pinctrl: aspeed: Enable compile testing outside of ARCH_ASPEED

In reply to Krzysztof Kozlowski

Since inception in commit 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs"), the Aspeed pin controller drivers cannot be compile tested, unless ARCH_ASPEED is selected. . That partially defeats the purpose of compile testing, since ARCH_ASPEED is pulled when building platform kernels.

---
 drivers/pinctrl/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/Makefile +1 -1
index b054cfb99348..9320ffae5f31 100644
@@ -66,7 +66,7 @@ obj-$(CONFIG_PINCTRL_ZYNQMP)	+= pinctrl-zynqmp.o
 obj-$(CONFIG_PINCTRL_ZYNQ)	+= pinctrl-zynq.o
 
 obj-y				+= actions/
-obj-$(CONFIG_ARCH_ASPEED)	+= aspeed/
+obj-$(CONFIG_PINCTRL_ASPEED)	+= aspeed/
 obj-y				+= bcm/
 obj-$(CONFIG_PINCTRL_BERLIN)	+= berlin/
 obj-y				+= cirrus/
Signature · 1 line
2.51.0
#4 lore raw

PATCH 3/4 pinctrl: vt8500: Enable compile testing

In reply to Krzysztof Kozlowski

Enable compile testing for Realtek pin controller drivers for increased build and static checkers coverage. PINCTRL_WMT uses gpiochip_get_data(), thus needs GPIOLIB.

---
 drivers/pinctrl/Makefile       |  2 +-
 drivers/pinctrl/vt8500/Kconfig | 13 +++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)
drivers/pinctrl/Makefile +1 -1
index 9320ffae5f31..78135ee963db 100644
@@ -97,4 +97,4 @@ obj-y				+= tegra/
 obj-y				+= ti/
 obj-$(CONFIG_PINCTRL_UNIPHIER)	+= uniphier/
 obj-$(CONFIG_PINCTRL_VISCONTI)	+= visconti/
-obj-$(CONFIG_ARCH_VT8500)	+= vt8500/
+obj-$(CONFIG_PINCTRL_WMT)	+= vt8500/
drivers/pinctrl/vt8500/Kconfig +7 -6
index 2ca00b54b7a8..1a40c153a82a 100644
@@ -3,16 +3,17 @@
 # VIA/Wondermedia PINCTRL drivers
 #
 
-if ARCH_VT8500
+if ARCH_VT8500 || COMPILE_TEST
 
 config PINCTRL_WMT
 	bool
 	select PINMUX
 	select GENERIC_PINCONF
+	select GPIOLIB
 
 config PINCTRL_VT8500
 	bool "VIA VT8500 pin controller driver"
-	depends on ARCH_WM8505
+	depends on ARCH_WM8505 || COMPILE_TEST
 	select PINCTRL_WMT
 	help
 	  Say yes here to support the gpio/pin control module on
@@ -20,7 +21,7 @@ config PINCTRL_VT8500
 
 config PINCTRL_WM8505
 	bool "Wondermedia WM8505 pin controller driver"
-	depends on ARCH_WM8505
+	depends on ARCH_WM8505 || COMPILE_TEST
 	select PINCTRL_WMT
 	help
 	  Say yes here to support the gpio/pin control module on
@@ -28,7 +29,7 @@ config PINCTRL_WM8505
 
 config PINCTRL_WM8650
 	bool "Wondermedia WM8650 pin controller driver"
-	depends on ARCH_WM8505
+	depends on ARCH_WM8505 || COMPILE_TEST
 	select PINCTRL_WMT
 	help
 	  Say yes here to support the gpio/pin control module on
@@ -36,7 +37,7 @@ config PINCTRL_WM8650
 
 config PINCTRL_WM8750
 	bool "Wondermedia WM8750 pin controller driver"
-	depends on ARCH_WM8750
+	depends on ARCH_WM8750 || COMPILE_TEST
 	select PINCTRL_WMT
 	help
 	  Say yes here to support the gpio/pin control module on
@@ -44,7 +45,7 @@ config PINCTRL_WM8750
 
 config PINCTRL_WM8850
 	bool "Wondermedia WM8850 pin controller driver"
-	depends on ARCH_WM8850
+	depends on ARCH_WM8850 || COMPILE_TEST
 	select PINCTRL_WMT
 	help
 	  Say yes here to support the gpio/pin control module on
Signature · 1 line
2.51.0
#5 lore raw

Re: [PATCH 3/4] pinctrl: vt8500: Enable compile testing

Hi Krzysztof,

Quoted 1 line · Krzysztof Kozlowski

Enable compile testing for Realtek pin controller drivers for increased

Small nit, but this looks like a copy-paste error from the other patch.

	Realtek -> VIA/Wondermedia (or vt8500, whatever you prefer)

Best,
Sander

#6 lore raw

Re: [PATCH 3/4] pinctrl: vt8500: Enable compile testing

Quoted 9 lines · Sander Vanheule

Hi Krzysztof,

Quoted 1 line · Krzysztof Kozlowski

Enable compile testing for Realtek pin controller drivers for increased

Small nit, but this looks like a copy-paste error from the other patch.

	Realtek -> VIA/Wondermedia (or vt8500, whatever you prefer)

Yes.

Best regards,
Krzysztof

#7 lore raw

PATCH 4/4 ARM: realtek: MAINTAINERS: Include pin controller drivers

In reply to Krzysztof Kozlowski

No dedicated maintainers are shown for Realtek SoC pin controllers, except pinctrl subsystem maintainer, which means reduced review and impression of abandoned drivers. Pin controller drivers are essential part of an SoC, so in case of lack of dedicated entry at least cover it by the SoC platform maintainers.

---

This patch should go via Realtek SoC maintainers, not pinctrl.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 10d12b51b1f6..374ce55e4fb6 100644
@@ -3373,6 +3373,7 @@ F:	Documentation/devicetree/bindings/arm/realtek.yaml
 F:	arch/arm/boot/dts/realtek/
 F:	arch/arm/mach-realtek/
 F:	arch/arm64/boot/dts/realtek/
+F:	drivers/pinctrl/realtek/
 
 ARM/RISC-V/RENESAS ARCHITECTURE
 M:	Geert Uytterhoeven <[email protected]>
Signature · 1 line
2.51.0
maintainer Acked-by on v1 4/4
#8 lore raw

RE: [PATCH 4/4] ARM: realtek: MAINTAINERS: Include pin controller drivers

Quoted 26 lines

No dedicated maintainers are shown for Realtek SoC pin controllers, except pinctrl subsystem maintainer, which means reduced review and impression of abandoned drivers. Pin controller drivers are essential part of an SoC, so in case of lack of dedicated entry at least cover it by the SoC platform maintainers.

---

This patch should go via Realtek SoC maintainers, not pinctrl.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 10d12b51b1f6..374ce55e4fb6 100644
@@ -3373,6 +3373,7 @@ F:

Documentation/devicetree/bindings/arm/realtek.yaml

 F:     arch/arm/boot/dts/realtek/
 F:     arch/arm/mach-realtek/
 F:     arch/arm64/boot/dts/realtek/
+F:     drivers/pinctrl/realtek/
Quoted 5 lines

ARM/RISC-V/RENESAS ARCHITECTURE
M: Geert Uytterhoeven <[email protected]>

--
2.51.0

#9 lore raw

Re: [PATCH 4/4] ARM: realtek: MAINTAINERS: Include pin controller drivers

Quoted 26 lines · Yu-Chun Lin [林祐君]
Quoted 26 lines

No dedicated maintainers are shown for Realtek SoC pin controllers, except pinctrl subsystem maintainer, which means reduced review and impression of abandoned drivers. Pin controller drivers are essential part of an SoC, so in case of lack of dedicated entry at least cover it by the SoC platform maintainers.

---

This patch should go via Realtek SoC maintainers, not pinctrl.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 10d12b51b1f6..374ce55e4fb6 100644
@@ -3373,6 +3373,7 @@ F:

Documentation/devicetree/bindings/arm/realtek.yaml

 F:     arch/arm/boot/dts/realtek/
 F:     arch/arm/mach-realtek/
 F:     arch/arm64/boot/dts/realtek/
+F:     drivers/pinctrl/realtek/
Quoted 7 lines
Quoted 5 lines

ARM/RISC-V/RENESAS ARCHITECTURE
M: Geert Uytterhoeven <[email protected]>

--
2.51.0

So James will pick it up?

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH 4/4] ARM: realtek: MAINTAINERS: Include pin controller drivers

Quoted 35 lines · Yu-Chun Lin [林祐君]
Quoted 26 lines
Quoted 26 lines

No dedicated maintainers are shown for Realtek SoC pin controllers, except pinctrl subsystem maintainer, which means reduced review and impression of abandoned drivers. Pin controller drivers are essential part of an SoC, so in case of lack of dedicated entry at least cover it by the SoC platform maintainers.

---

This patch should go via Realtek SoC maintainers, not pinctrl.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 10d12b51b1f6..374ce55e4fb6 100644
@@ -3373,6 +3373,7 @@ F:

Documentation/devicetree/bindings/arm/realtek.yaml

 F:     arch/arm/boot/dts/realtek/
 F:     arch/arm/mach-realtek/
 F:     arch/arm64/boot/dts/realtek/
+F:     drivers/pinctrl/realtek/
Quoted 7 lines
Quoted 5 lines

ARM/RISC-V/RENESAS ARCHITECTURE
M: Geert Uytterhoeven <[email protected]>

--
2.51.0

Quoted 4 lines

So James will pick it up?

Best regards,
Krzysztof

Sorry for the confusion. I'll pick up this patch and include it in a series along with the maintainer updates and other DTS changes. I plan to submit the series to soc@ during the v7.1-rc1 to v7.1-rc5 window.

Best regards,
Yu-Chun

maintainer
#11 lore raw

Re: [PATCH 4/4] ARM: realtek: MAINTAINERS: Include pin controller drivers

In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski

No dedicated maintainers are shown for Realtek SoC pin controllers, except pinctrl subsystem maintainer, which means reduced review and impression of abandoned drivers. Pin controller drivers are essential part of an SoC, so in case of lack of dedicated entry at least cover it by the SoC platform maintainers.

I didn't apply this patch since Yu-Chun says it will be applied to the SoC tree.

Yours,
Linus Walleij