Skip to contentSkip to conversation

Bump libecoli and grout; DPDK packaging improvement

PATCH In review Maxime Leroy 2 participants 9 messages Apr 13 – Jul 13

lore
Share & tools
lore
#0 lore raw

cover Bump libecoli and grout; DPDK packaging improvement

This patch series updates the libecoli and grout packages in Buildroot and adds a new option to the DPDK package.

Summary of changes:
- libecoli is bumped to version 0.11.3
- grout is bumped to version 0.15.0
- A new DPDK option allows disabling target installation, which is useful when a DPDK application is statically linked against DPDK libraries

Tested in GitLab CI:
- https://gitlab.com/maxime-leroy/buildroot/-/pipelines/2449432442

Maxime Leroy (3):
package/libecoli: bump version to 0.11.3 package/dpdk: add option to disable target installation package/grout: bump version to 0.15.0

 package/dpdk/Config.in         | 13 +++++++++++++
 package/dpdk/dpdk.mk           |  6 ++++++
 package/grout/Config.in        | 10 ++++------
 package/grout/grout.hash       |  2 +-
 package/grout/grout.mk         |  5 ++---
 package/libecoli/libecoli.hash |  2 +-
 package/libecoli/libecoli.mk   |  2 +-
 7 files changed, 28 insertions(+), 12 deletions(-)
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/3 package/libecoli: bump version to 0.11.3

See the release note of the new versions:
https://github.com/rjarry/libecoli/releases/tag/v0.11.3
https://github.com/rjarry/libecoli/releases/tag/v0.11.2
https://github.com/rjarry/libecoli/releases/tag/v0.11.1
https://github.com/rjarry/libecoli/releases/tag/v0.11.0

---
 package/libecoli/libecoli.hash | 2 +-
 package/libecoli/libecoli.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/libecoli/libecoli.hash +1 -1
index 4045c7e19d..882f01fa99 100644
@@ -1,3 +1,3 @@
 # Locally computed:
-sha256  ec359850f4f338b607d05200d508736b14eaa30fca8aefdfde980a283afd789d  libecoli-0.10.1.tar.gz
+sha256  25ed9638452fa050749746c863574dfd47df95bde98347d210c9deedea188151  libecoli-0.11.3.tar.gz
 sha256  e58bf9ec962bee9b3e37abcaa0bc0ec940b05efdc1d1a5a4d9e2fdbcc08b7bdd  LICENSE
package/libecoli/libecoli.mk +1 -1
index 96617a1689..5d4b3993f8 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBECOLI_VERSION = 0.10.1
+LIBECOLI_VERSION = 0.11.3
 LIBECOLI_SITE = $(call github,rjarry,libecoli,v$(LIBECOLI_VERSION))
 LIBECOLI_INSTALL_STAGING = YES
 LIBECOLI_LICENSE = BSD-3-Clause
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by Vincent Jardin on v1 1/3
#2 lore raw

Re: [Buildroot] [PATCH 1/3] package/libecoli: bump version to 0.11.3

Thanks Maxime,

Quoted 2 lines · Maxime Leroy

Assuming the build checks with:
https://gitlab.com/maxime-leroy/buildroot/-/jobs/13897336249

Best regards,
Vincent
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw

Re: [Buildroot] [PATCH 1/3] package/libecoli: bump version to 0.11.3

In reply to Maxime Leroy

Hi Maxime,

Quoted 7 lines · Maxime Leroy

See the release note of the new versions:
https://github.com/rjarry/libecoli/releases/tag/v0.11.3
https://github.com/rjarry/libecoli/releases/tag/v0.11.2
https://github.com/rjarry/libecoli/releases/tag/v0.11.1
https://github.com/rjarry/libecoli/releases/tag/v0.11.0

I applied the patch 1 and 3 of this series (the package bumps). I'm skipping the patch 2 adding the dpdk install target option for the time being.

Best regards,

Julien.
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw

PATCH 2/3 package/dpdk: add option to disable target installation

In reply to Maxime Leroy

Introduce BR2_PACKAGE_DPDK_INSTALL_TARGET (default y) to control whether DPDK is installed on the target. When disabled, DPDK is kept in staging only for build-time use.

This is useful when DPDK is only needed to build applications and is not required at runtime on the target, e.g. when an application is linked statically against the DPDK libraries (such as grout).

---
 package/dpdk/Config.in | 13 +++++++++++++
 package/dpdk/dpdk.mk   |  6 ++++++
 2 files changed, 19 insertions(+)
package/dpdk/Config.in +13 -0
index b658145e5b..69c5edf634 100644
@@ -37,11 +37,24 @@ config BR2_PACKAGE_DPDK
 
 if BR2_PACKAGE_DPDK
 
+config BR2_PACKAGE_DPDK_INSTALL_TARGET
+	bool "install DPDK on target"
+	default y
+	help
+	  Say y if you want DPDK libraries and tools installed on the
+	  target root filesystem (e.g. /usr/lib, /usr/bin).
+
+	  Say n if DPDK is only used as a build-time dependency from
+	  the staging directory (e.g. for static linking), and you do
+	  not want any DPDK files on the final image.
+
 config BR2_PACKAGE_DPDK_EXAMPLES
 	bool "Install examples"
+	depends on BR2_PACKAGE_DPDK_INSTALL_TARGET
 
 config BR2_PACKAGE_DPDK_TESTS
 	bool "Install tests"
+	depends on BR2_PACKAGE_DPDK_INSTALL_TARGET
 
 config BR2_PACKAGE_DPDK_DRIVERS_LIST
 	string "List of enabled drivers"
package/dpdk/dpdk.mk +6 -0
index 080f924329..2f744e519f 100644
@@ -74,6 +74,12 @@ ifneq ($(DPDK_APPS),)
   endif
 endif
 
+ifeq ($(BR2_PACKAGE_DPDK_INSTALL_TARGET),y)
+DPDK_INSTALL_TARGET = YES
+else
+DPDK_INSTALL_TARGET = NO
+endif
+
 ifeq ($(BR2_PACKAGE_DPDK_TESTS),y)
 DPDK_CONF_OPTS += -Dtests=true
 else
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by Vincent Jardin on v1 2/3
#5 lore raw

Re: [Buildroot] [PATCH 2/3] package/dpdk: add option to disable target installation

Hi Maxime,

Quoted 3 lines · Maxime Leroy

Introduce BR2_PACKAGE_DPDK_INSTALL_TARGET (default y) to control whether DPDK is installed on the target. When disabled, DPDK is kept in staging only for build-time use.

Can you explain why we need such specific trick with the DPDK ?

From your comments below, I guess it means:
- DPDK has its own internal build logic with both .a and .so build
- for performance purposes, on many targets, we link with the .a so it is useless to install the .so on the targets.

Quoted 5 lines

This is useful when DPDK is only needed to build applications and is not required at runtime on the target, e.g. when an application is linked statically against the DPDK libraries (such as grout).

Best regards,
Vincent
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#6 lore raw

PATCH 3/3 package/grout: bump version to 0.15.0

In reply to Maxime Leroy

Drop util-linux dependency, libsmartcols is no longer used. Bump GCC requirement from 4.9 to 13 for gnu2x and C23 enum underlying types support.

See the release note of the new version:
https://github.com/DPDK/grout/releases/tag/v0.15.0

---
 package/grout/Config.in  | 10 ++++------
 package/grout/grout.hash |  2 +-
 package/grout/grout.mk   |  5 ++---
 3 files changed, 7 insertions(+), 10 deletions(-)
package/grout/Config.in +4 -6
index 1cfec41d7a..c57937dc18 100644
@@ -2,8 +2,8 @@ config BR2_PACKAGE_GROUT
 	bool "grout"
 	depends on BR2_PACKAGE_DPDK_ARCH_SUPPORTS # dpdk
 	depends on BR2_TOOLCHAIN_HAS_THREADS # dpdk
-	depends on BR2_USE_MMU # dpdk, numactl, libecoli, util-linux-smartcols
-	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # dpdk
+	depends on BR2_USE_MMU # dpdk, numactl, libecoli
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_13 # C23 enum underlying types
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_19 # dpdk
 	depends on BR2_TOOLCHAIN_USES_GLIBC # dpdk
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC # numactl
@@ -14,16 +14,14 @@ config BR2_PACKAGE_GROUT
 	select BR2_PACKAGE_NUMACTL
 	select BR2_PACKAGE_LIBECOLI
 	select BR2_PACKAGE_LIBMNL
-	select BR2_PACKAGE_UTIL_LINUX
-	select BR2_PACKAGE_UTIL_LINUX_LIBSMARTCOLS
 	help
 	  Graph router based on DPDK
 
-comment "grout needs a glibc toolchain w/ dynamic library, threads, wchar, gcc >= 4.9, headers >= 4.19"
+comment "grout needs a glibc toolchain w/ dynamic library, threads, wchar, gcc >= 13, headers >= 4.19"
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_DPDK_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_ATOMIC
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_TOOLCHAIN_USES_GLIBC || \
-		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_13 || \
 		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_19
package/grout/grout.hash +1 -1
index bf3d6b87ec..ead390f8fc 100644
@@ -1,3 +1,3 @@
 # Locally computed:
-sha256  4ccceea87ead25dfbee7d44d25283abc61173caf6bae08c9644fa9a6cb6b9ade  grout-0.14.3.tar.gz
+sha256  c4a289d13453a42961db2131a179e95965450feb27505f4c463adbd8970e0440  grout-0.15.0.tar.gz
 sha256  1e412aae8da58b718c78b3d7a52eb547004384d4347e4746a22ca6af7522930c  licenses/BSD-3-clause.txt
package/grout/grout.mk +2 -3
index 39bdc7f824..0b66995dfe 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GROUT_VERSION = 0.14.3
+GROUT_VERSION = 0.15.0
 GROUT_SITE = $(call github,DPDK,grout,v$(GROUT_VERSION))
 GROUT_LICENSE = BSD-3-Clause
 GROUT_LICENSE_FILES = licenses/BSD-3-clause.txt
@@ -18,8 +18,7 @@ GROUT_DEPENDENCIES = \
 	libevent \
 	libmnl \
 	numactl \
-	libecoli \
-	util-linux
+	libecoli
 
 define GROUT_LINUX_CONFIG_FIXUPS
 	$(call KCONFIG_ENABLE_OPT,CONFIG_TUN)
Signature · 6 lines
2.43.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by Vincent Jardin on v1 3/3
#7 lore raw

Re: [Buildroot] [PATCH 3/3] package/grout: bump version to 0.15.0

Hi Maxime,

LGTM

Quoted 8 lines

Drop util-linux dependency, libsmartcols is no longer used. Bump GCC requirement from 4.9 to 13 for gnu2x and C23 enum underlying types support.

See the release note of the new version:
https://github.com/DPDK/grout/releases/tag/v0.15.0

Assuming the build checks from:
https://gitlab.com/maxime-leroy/buildroot/-/jobs/13897336249

Best regards,
Vincent
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot