Skip to contentSkip to conversation

ixgbevf: fix use-after-free in VEPA multicast source pruning

PATCH In review Michael Bommarito 3 participants 5 messages Apr 13 – May 11

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbevf: fix use-after-free in VEPA multicast source pruning

ixgbevf_clean_rx_irq() prunes frames whose source MAC matches the VF's own address (VEPA multicast workaround) by freeing the skb and continuing to the next descriptor:

    dev_kfree_skb_irq(skb);
    continue;

The skb pointer is declared outside the while loop and persists across iterations. Because the continue skips the "skb = NULL" reset at the bottom of the loop, the next iteration enters the "else if (skb)" path and calls ixgbevf_add_rx_frag() on the freed skb, dereferencing skb_shinfo(skb)->nr_frags — a use-after-free in NAPI softirq context.

The sibling driver iavf already handles this correctly by nulling the pointer before continuing. Apply the same pattern here.

I do not have ixgbevf hardware; the bug was found by static analysis (scan_drop_continue_loops.py + semgrep drop_continue_in_loop, multi-tool corroboration with the highest score in the scan). The UAF was confirmed under KASAN by loading a test module that reproduces the exact code pattern (alloc skb, kfree_skb, then read skb_shinfo(skb)->nr_frags):

  BUG: KASAN: slab-use-after-free in ixgbevf_uaf_test_init+0x100/0x1000
  Read of size 8 at addr 000000006163ae78 by task insmod/30
  freed 208-byte region [000000006163adc0, 000000006163ae90)

QEMU emulates igb (82576) but not ixgbe (82599), and the igbvf VF driver does not include the VEPA source pruning path, so a full end-to-end reproduction with emulated hardware was not possible.

Fixes bad17234ba70 ("ixgbevf: Change receive model to use double buffered page based receives")
Assisted-by Claude:claude-opus-4-6
Assisted-by Codex:gpt-5-4
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +1 -0
index 42f89a179a3f..4ba3be961ab6 100644
@@ -1221,6 +1221,7 @@ static int ixgbevf_clean_rx_irq(struct ixgbevf_q_vector *q_vector,
 		    ether_addr_equal(rx_ring->netdev->dev_addr,
 				     eth_hdr(skb)->h_source)) {
 			dev_kfree_skb_irq(skb);
+			skb = NULL;
 			continue;
 		}
 
Signature · 1 line
2.53.0
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 30 lines · Michael Bommarito

ixgbevf_clean_rx_irq() prunes frames whose source MAC matches the VF's own address (VEPA multicast workaround) by freeing the skb and continuing to the next descriptor:

    dev_kfree_skb_irq(skb);
    continue;

The skb pointer is declared outside the while loop and persists across iterations. Because the continue skips the "skb = NULL" reset at the bottom of the loop, the next iteration enters the "else if (skb)" path and calls ixgbevf_add_rx_frag() on the freed skb, dereferencing skb_shinfo(skb)->nr_frags — a use-after-free in NAPI softirq context.

The sibling driver iavf already handles this correctly by nulling the pointer before continuing. Apply the same pattern here.

I do not have ixgbevf hardware; the bug was found by static analysis (scan_drop_continue_loops.py + semgrep drop_continue_in_loop, multi-tool corroboration with the highest score in the scan). The UAF was confirmed under KASAN by loading a test module that reproduces the exact code pattern (alloc skb, kfree_skb, then read skb_shinfo(skb)->nr_frags):

  BUG: KASAN: slab-use-after-free in ixgbevf_uaf_test_init+0x100/0x1000
  Read of size 8 at addr 000000006163ae78 by task insmod/30
  freed 208-byte region [000000006163adc0, 000000006163ae90)

QEMU emulates igb (82576) but not ixgbe (82599), and the igbvf VF driver does not include the VEPA source pruning path, so a full end-to-end reproduction with emulated hardware was not possible.

Quoted 5 lines
Fixes bad17234ba70 ("ixgbevf: Change receive model to use double buffered page based receives")
Assisted-by Claude:claude-opus-4-6
Assisted-by Codex:gpt-5-4

Sashiko flags a number of issues in the same function that do not seem related to your patch.

I'd suggest looking over them if you are interested in follow-up work in this area.

...

#2 lore raw
Quoted 5 lines · Simon Horman

Sashiko flags a number of issues in the same function that do not seem related to your patch.

I'd suggest looking over them if you are interested in follow-up work in this area.

Sure, I'd be happy to keep going here if you're open to more hardening patches.

Two Qs for you:

1. Do you want smaller patches for each or bigger method-level patches?

2. Anything on my list below that you would *not* want me touching? I'll combine with anything I can find from your Sashiko items

1. line 104
rule: semgrep bug-on-in-net-code (CWE-617)
match: BUG_ON(!test_bit(__IXGBEVF_SERVICE_SCHED,
&adapter->state))
where: ixgbevf_service_event_schedule()
status: untriaged

2. lines 1219-1225
rule: net-drop-continue-in-loop + scan_drop_continue_loops.py
match: VEPA multicast pruning kfree_skb + continue (UAF)
where: ixgbevf_clean_rx_irq()
status: SHIPPED as commit ca62ac02b30d (this patch)

3. line 2769
rule: semgrep signed-int-as-size-param-kmalloc
match: q_vector = kzalloc(size, GFP_KERNEL) (signed size)
status: untriaged

4. line 3452
rule: semgrep signed-int-as-size-param-kmalloc
match: tx_ring->tx_buffer_info = vmalloc(size) (signed size)
status: untriaged

5. line 3530
rule: semgrep signed-int-as-size-param-kmalloc
match: rx_ring->rx_buffer_info = vmalloc(size) (signed size)
status: untriaged

6. line 4114
rule: semgrep narrow-accumulator-overflow
match: i += tx_ring->count;
status: untriaged

7. line 4189
rule: semgrep narrow-accumulator-overflow
match: count += TXD_USE_COUNT(skb_frag_size(frag));
status: untriaged

8. line 4192
rule: semgrep narrow-accumulator-overflow
match: count += skb_shinfo(skb)->nr_frags;
status: untriaged

9. line 4695
rule: coccinelle cancel_work.cocci
match: INIT_WORK(&adapter->service_task, ixgbevf_service_task)
with no matching cancel_work_sync on teardown path
status: untriaged

10. line 4752
rule: coccinelle null_after_free.cocci
where: ixgbevf_probe() err_dma path
status: untriaged

11. line 4795
rule: coccinelle null_after_free.cocci
where: ixgbevf_remove()
status: untriaged

reviewer
#3 lore raw
Quoted 9 lines · Michael Bommarito
Quoted 5 lines · Simon Horman

Sashiko flags a number of issues in the same function that do not seem related to your patch.

I'd suggest looking over them if you are interested in follow-up work in this area.

Sure, I'd be happy to keep going here if you're open to more hardening patches.

Speaking for myself: I'm happy to review patches that correct bugs.

I'm also happy to review patches that otherwise improve the code. But I think the Intel people might be able to provide better guidance here.

Please be aware of the Netdev guidance on cleanups:

Quoted 4 lines

Two Qs for you:

1. Do you want smaller patches for each or bigger method-level patches?

The general rule of thumb is one patch per problem. Personally, I prefer small patches.

Quoted 3 lines

2. Anything on my list below that you would *not* want me touching? I'll combine with anything I can find from your Sashiko items

...

Quoted 10 lines

3. line 2769
rule: semgrep signed-int-as-size-param-kmalloc
match: q_vector = kzalloc(size, GFP_KERNEL) (signed size)
status: untriaged

4. line 3452
rule: semgrep signed-int-as-size-param-kmalloc
match: tx_ring->tx_buffer_info = vmalloc(size) (signed size)
status: untriaged

Quoted 4 lines

5. line 3530
rule: semgrep signed-int-as-size-param-kmalloc
match: rx_ring->rx_buffer_info = vmalloc(size) (signed size)
status: untriaged

I didn't look closely, but: I am a little skeptical that these signed size problems are worth fixing; while the other items on your list look worth fixing to me.

...

#4 lore raw
Quoted 62 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Simon Horman
Sent: Thursday, April 16, 2026 7:14 PM
To: Michael Bommarito <[email protected]>
Cc: [email protected]; Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw <[email protected]>; Andrew Lunn <[email protected]>; David S. Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; [email protected]; [email protected]; linux- [email protected]
Subject: Re: [Intel-wired-lan] [PATCH net] ixgbevf: fix use-after-free in VEPA multicast source pruning

Quoted 9 lines · Michael Bommarito
Quoted 5 lines · Simon Horman

Sashiko flags a number of issues in the same function that do not seem related to your patch.

I'd suggest looking over them if you are interested in follow-up work in this area.

Sure, I'd be happy to keep going here if you're open to more hardening patches.

Speaking for myself: I'm happy to review patches that correct bugs.

I'm also happy to review patches that otherwise improve the code. But I think the Intel people might be able to provide better guidance here.

Please be aware of the Netdev guidance on cleanups:

Quoted 4 lines

Two Qs for you:

1. Do you want smaller patches for each or bigger method-level patches?

The general rule of thumb is one patch per problem. Personally, I prefer small patches.

Quoted 3 lines

2. Anything on my list below that you would *not* want me touching? I'll combine with anything I can find from your Sashiko items

...

Quoted 10 lines

3. line 2769
rule: semgrep signed-int-as-size-param-kmalloc
match: q_vector = kzalloc(size, GFP_KERNEL) (signed size)
status: untriaged

4. line 3452
rule: semgrep signed-int-as-size-param-kmalloc
match: tx_ring->tx_buffer_info = vmalloc(size) (signed size)
status: untriaged

Quoted 4 lines

5. line 3530
rule: semgrep signed-int-as-size-param-kmalloc
match: rx_ring->rx_buffer_info = vmalloc(size) (signed size)
status: untriaged

Quoted 4 lines

I didn't look closely, but: I am a little skeptical that these signed size problems are worth fixing; while the other items on your list look worth fixing to me.

...