Skip to contentSkip to conversation

ASoC: rt1320: fix the warning 'rae_fw' from request_firmware() not released

PATCH In review [email protected] 2 participants 2 messages Apr 14

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rt1320: fix the warning 'rae_fw' from request_firmware() not released

From: Shuming Fan <[email protected]>

New smatch warnings:
sound/soc/codecs/rt1320-sdw.c:1575 rt1320_rae_load() warn: 'rae_fw' from request_firmware() not released on lines: 1575.

Fixes 22937af75abb ("ASoC: rt1320: support RAE parameters loading")
---
 sound/soc/codecs/rt1320-sdw.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/rt1320-sdw.c +1 -0
index b0aeeab26bd9..192faa431b5e 100644
@@ -1498,6 +1498,7 @@ static int rt1320_rae_load(struct rt1320_sdw_priv *rt1320)
 		}
 		if (!retry && !(value & 0x40)) {
 			dev_err(dev, "%s: RAE is not ready to load\n", __func__);
+			release_firmware(rae_fw);
 			return -ETIMEDOUT;
 		}
 
Signature · 1 line
2.53.0
maintainer
#1 lore raw
Quoted 1 line · On Tue, 14 Apr 2026 15:14:41 +0800, [email protected] wrote:

ASoC: rt1320: fix the warning 'rae_fw' from request_firmware() not released

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.1

Thanks!

[1/1] ASoC: rt1320: fix the warning 'rae_fw' from request_firmware() not released

      https://git.kernel.org/broonie/sound/c/cf162476f7e0

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark