Skip to contentSkip to conversation

mm/memblock: fix off-by-one page leak in reserve_mem_release_by_name()

PATCH Superseded DaeMyung Kang 1 participant 1 message Apr 14

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mm/memblock: fix off-by-one page leak in reserve_mem_release_by_name()

free_reserved_area() treats its 'end' argument as exclusive: it aligns end down via 'end & PAGE_MASK' and iterates with 'pos < end'.

reserve_mem_release_by_name() instead passes 'start + map->size - 1', which causes the last page of a page-aligned reservation to never be freed. For a reservation spanning N pages, only N - 1 pages are released back to the allocator.

Fix it by passing the exclusive end address, 'start + map->size'.

Fixes 74e2498ccf7b ("mm/memblock: Add reserved memory release function")

---
Changes in v2:
- Add Fixes: tag and Cc: stable (per Donet Tom's review).
- v1: https://lore.kernel.org/lkml/

 mm/memblock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/memblock.c +1 -1
index b3ddfdec7a80..d4a02f1750e9 100644
@@ -2434,7 +2434,7 @@ int reserve_mem_release_by_name(const char *name)
 		return 0;
 
 	start = phys_to_virt(map->start);
-	end = start + map->size - 1;
+	end = start + map->size;
 	snprintf(buf, sizeof(buf), "reserve_mem:%s", name);
 	free_reserved_area(start, end, 0, buf);
 	map->size = 0;
Signature · 1 line
2.43.0