tools/rtla: Fix --dump-tasks usage in timerlat
Subsystems (2)
PATCH v2 1/1 tools/rtla: Fix --dump-tasks usage in timerlat
Fix --dump-task to --dump-tasks in timerlat_hist usage string and getopt_long table for consistency with timerlat_top.
Add missing --dump-tasks to timerlat_top usage synopsis.
---
v2:
- Address comments of Crystal Wood.
--- tools/tracing/rtla/src/timerlat_hist.c | 4 ++-- tools/tracing/rtla/src/timerlat_top.c | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-)
tools/tracing/rtla/src/timerlat_hist.c +2 -2
@@ -694,7 +694,7 @@ static void timerlat_hist_usage(void)"[-d s] [-D] [-n] [-a us] [-p us] [-i us] [-T us] [-s us] \\" ," [-t [file]] [-e sys[:event]] [--filter <filter>] [--trigger <trigger>] [-c cpu-list] [-H cpu-list]\\" ," [-P priority] [-E N] [-b N] [--no-irq] [--no-thread] [--no-header] [--no-summary] \\" , -" [--no-index] [--with-zeros] [--dma-latency us] [-C [cgroup_name]] [--no-aa] [--dump-task] [-u|-k]" , +" [--no-index] [--with-zeros] [--dma-latency us] [-C [cgroup_name]] [--no-aa] [--dump-tasks] [-u|-k]" ," [--warm-up s] [--deepest-idle-state n]" , NULL, };
@@ -808,7 +808,7 @@ static struct common_params {"filter", required_argument, 0, '7'}, {"dma-latency", required_argument, 0, '8'}, {"no-aa", no_argument, 0, '9'}, - {"dump-task", no_argument, 0, '\1'}, + {"dump-tasks", no_argument, 0, '\1'}, {"warm-up", required_argument, 0, '\2'}, {"trace-buffer-size", required_argument, 0, '\3'}, {"deepest-idle-state", required_argument, 0, '\4'},
tools/tracing/rtla/src/timerlat_top.c +2 -1
@@ -467,7 +467,8 @@ static void timerlat_top_usage(void)static const char *const msg_start[] = {"[-q] [-a us] [-d s] [-D] [-n] [-p us] [-i us] [-T us] [-s us] \\" ," [[-t [file]] [-e sys[:event]] [--filter <filter>] [--trigger <trigger>] [-c cpu-list] [-H cpu-list]\\" , -" [-P priority] [--dma-latency us] [--aa-only us] [-C [cgroup_name]] [-u|-k] [--warm-up s] [--deepest-idle-state n]" , +" [-P priority] [--dma-latency us] [--aa-only us] [-C [cgroup_name]] [--dump-tasks] [-u|-k] [--warm-up s]\\" , +" [--deepest-idle-state n]" ,NULL , };
Signature · 1 line
2.53.0
Tomas Glozar
maintainerút 14. 4. 2026 v 20:52 odesílatel Costa Shulyupin
<[email protected]> napsal:
Quoted 11 lines
Fix --dump-task to --dump-tasks in
timerlat_histusage string andgetopt_longtable for consistency withtimerlat_top.Add missing --dump-tasks to
timerlat_topusage synopsis.Assisted-by Claude:claude-opus-4-6Signed-off-by Costa Shulyupin <[email protected]>---
v2:
- Address comments of Crystal Wood.
Please also add the link to v1 next time when sending a v2, it makes it easier to check what is being addressed in the v2.
Quoted 5 lines
--- tools/tracing/rtla/src/timerlat_hist.c | 4 ++-- tools/tracing/rtla/src/timerlat_top.c | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-)
The runtime test expanded to hist in [1] now passes, thanks! Adding:
[1] https://lore.kernel.org/linux-trace-kernel/[email protected]/
Tomas