gpio: aspeed: fix AST2700 debounce selector bit definitions
Subsystems (2)
Billy Tsai
reviewerPATCH 1/1 gpio: aspeed: fix AST2700 debounce selector bit definitions
The AST2700 datasheet defines reg_debounce_sel1 as the low bit and reg_debounce_sel2 as the high bit. The current driver uses the AST2600 mapping instead, where sel1 is the high bit and sel2 is the low bit.
As a result, the debounce selector bits are programmed in reverse on AST2700. Swap the G7 sel1/sel2 bit definitions so the driver matches the hardware definition.
--- drivers/gpio/gpio-aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpio/gpio-aspeed.c +2 -2
@@ -42,8 +42,8 @@#define GPIO_G7_CTRL_IRQ_TYPE1 BIT(4)#define GPIO_G7_CTRL_IRQ_TYPE2 BIT(5)#define GPIO_G7_CTRL_RST_TOLERANCE BIT(6) -#define GPIO_G7_CTRL_DEBOUNCE_SEL1 BIT(7) -#define GPIO_G7_CTRL_DEBOUNCE_SEL2 BIT(8) +#define GPIO_G7_CTRL_DEBOUNCE_SEL2 BIT(7) +#define GPIO_G7_CTRL_DEBOUNCE_SEL1 BIT(8)#define GPIO_G7_CTRL_INPUT_MASK BIT(9)#define GPIO_G7_CTRL_IRQ_STS BIT(12)#define GPIO_G7_CTRL_IN_DATA BIT(13)
---
base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f
change-id: 20260415-gpio-fix-1745583ecf06
Best regards,
Signature · 1 line
Billy Tsai <[email protected]>
Bartosz Golaszewski
AppliedQuoted 9 lines · Billy Tsai
The AST2700 datasheet defines
reg_debounce_sel1as the low bit andreg_debounce_sel2as the high bit. The current driver uses the AST2600 mapping instead, where sel1 is the high bit and sel2 is the low bit.As a result, the debounce selector bits are programmed in reverse on AST2700. Swap the G7 sel1/sel2 bit definitions so the driver matches the hardware definition.
[...]
Applied, thanks!
[1/1] gpio: aspeed: fix AST2700 debounce selector bit definitions
https://git.kernel.org/brgl/c/e31eee4a961077d60ef2362507240c6743c1c2ae
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>