imx: imx9: Select ARCH_MISC_INIT for all i.MX9 SoCs
Subsystems (3)
PATCH 1/1 imx: imx9: Select ARCH_MISC_INIT for all i.MX9 SoCs
Instead of adding select ARCH_MISC_INIT for each i.MX 9x SoC, select it at the i.MX9 family Kconfig level. The corresponding arch_misc_init() is already defined in the common arch/arm/mach-imx/imx9/soc.c file and will print out ELE firmware BuildInfo for all i.MX9 SoCs now instead of just i.MX91 and i.MX95.
--- arch/arm/mach-imx/imx9/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/mach-imx/imx9/Kconfig +1 -2
@@ -7,6 +7,7 @@ config AHAB_BOOT config IMX9 bool + select ARCH_MISC_INIT select BINMAN select CPU select CPU_IMX
@@ -22,7 +23,6 @@ config IMX93 config IMX91 bool select IMX9 - select ARCH_MISC_INIT select ARMV8_SPL_EXCEPTION_VECTORS config IMX95_A0
@@ -30,7 +30,6 @@ config IMX95_A0 config IMX95 bool - select ARCH_MISC_INIT select ARMV8_SPL_EXCEPTION_VECTORS select IMX9 select DM_MAILBOX
Signature · 1 line
2.34.1
Quoted 8 lines
Subject: [PATCH] imx: imx9: Select
ARCH_MISC_INITfor all i.MX9 SoCsInstead of adding select
ARCH_MISC_INITfor each i.MX 9x SoC, select it at the i.MX9 familyKconfiglevel. The correspondingarch_misc_init()is already defined in the commonarch/arm/mach-imx/imx9/soc.cfile and will print out ELE firmware BuildInfo for all i.MX9 SoCs now instead of just
i.MX91 and i.MX95.
This will also make the Kconfig being select for i.MX93 and i.MX94. I think this is ok. But please mention that in commit log, then:
Regards
Peng.
Hi Peng,
Quoted 9 lines · Peng Fan
Quoted 8 lines
Subject: [PATCH] imx: imx9: Select
ARCH_MISC_INITfor all i.MX9 SoCsInstead of adding select
ARCH_MISC_INITfor each i.MX 9x SoC, select it at the i.MX9 familyKconfiglevel. The correspondingarch_misc_init()is already defined in the commonarch/arm/mach-imx/imx9/soc.cfile and will print out ELE firmware BuildInfo for all i.MX9 SoCs now instead of just
i.MX91 and i.MX95.
Quoted 3 lines
This will also make the
Kconfigbeing select for i.MX93 and i.MX94. I think this is ok. But please mention that in commit log, then:
I think commit message is already clear here?
"...will print out ELE firmware BuildInfo for all i.MX9 SoCs now..."
Do you think explicitly spelling out each SoC from i.MX9 family will help anyhow? Then I also have to mention i.MX 952, right? :)
I explicitly mentioned i.MX91 and i.MX95 just because they were already selecting ARCH_MISC_INIT option.
Anyhow I was only able to test this on i.MX93 since I don't have any i.MX94 board at hand. But I am pretty confident it should work there too.
Finally, should I send v2 with improved commit message or are you fine with current explanation?
BR,
Primoz
Quoted 4 lines
Reviewed-by Peng Fan <[email protected]>Regards
Peng.
Signature · 9 lines
Primoz Fiser phone: +386-41-390-545 email: [email protected] -- Norik systems d.o.o. Your embedded software partner Slovenia, EU phone: +386-41-540-545 email: [email protected]
Quoted 16 lines
Subject: Re: [PATCH] imx: imx9: Select
ARCH_MISC_INITfor all i.MX9 SoCsQuoted 3 lines
This will also make the
Kconfigbeing select for i.MX93 and i.MX94. I think this is ok. But please mention that in commit log, then:I think commit message is already clear here?
"...will print out ELE firmware BuildInfo for all i.MX9 SoCs now..."
Do you think explicitly spelling out each SoC from i.MX9 family will help anyhow? Then I also have to mention i.MX 952, right? :)
I explicitly mentioned i.MX91 and i.MX95 just because they were already selecting
ARCH_MISC_INIToption.
Quoted 6 lines
Anyhow I was only able to test this on i.MX93 since I don't have any i.MX94 board at hand. But I am pretty confident it should work there too.
Finally, should I send v2 with improved commit message or are you fine with current explanation?
I am ok with current explanation.
Thanks
Peng
Quoted 20 lines
BR,
PrimozQuoted 4 lines
Reviewed-by Peng Fan <[email protected]>Regards
Peng.--
Primoz Fiser
phone: +386-41-390-545
email: [email protected]
--
Norik systems d.o.o.
Your embedded software partner
Slovenia, EU
phone: +386-41-540-545
email: [email protected]