Skip to contentSkip to conversation

staging: fbtft: clarify TODO comment in fbtft-core

PATCH In review Sachin Kumar 3 participants 7 messages Apr 16 – Apr 27

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: clarify TODO comment in fbtft-core

Improve wording of a TODO comment to better describe the intended optimization. The comment now clearly states that only the changed display area should be updated instead of refreshing the entire screen.

---
 drivers/staging/fbtft/fbtft-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/fbtft/fbtft-core.c +3 -1
index f427c0914..4984aad9c 100644
@@ -414,7 +414,9 @@ static void fbtft_ops_damage_range(struct fb_info *info, off_t off, size_t len)
 {
 	struct fbtft_par *par = info->par;
 
-	/* TODO: only mark changed area update all for now */
+	/* TODO: Optimize to update only the changed area instead of
+	 * refreshing the entire display
+	 */
 	par->fbtftops.mkdirty(info, -1, 0);
 }
 
Signature · 1 line
2.43.0
#1 lore raw
Quoted 5 lines · Sachin Kumar

Improve wording of a TODO comment to better describe the intended optimization. The comment now clearly states that only the changed display area should be updated instead of refreshing the entire screen.

...

drivers/staging/fbtft/fbtft-core.c static void fbtft_ops_damage_range(struct fb_info *info, off_t off, size_t len) · line 419

Quoted 4 lines
drivers/staging/fbtft/fbtft-core.c +3 -1
-       /* TODO: only mark changed area update all for now */
+       /* TODO: Optimize to update only the changed area instead of
+        * refreshing the entire display
+        */

Wrong style.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw

PATCH 1/1 staging: fbtft: clarify TODO comment in fbtft-core

Improve wording of a TODO comment to better describe the intended optimization. The comment now clearly states that only the changed display area should be updated instead of refreshing the entire screen.

---
 drivers/staging/fbtft/fbtft-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fbtft-core.c +1 -1
index f427c0914..cff838955 100644
@@ -414,7 +414,7 @@ static void fbtft_ops_damage_range(struct fb_info *info, off_t off, size_t len)
 {
 	struct fbtft_par *par = info->par;
 
-	/* TODO: only mark changed area update all for now */
+	/* TODO: update only changed area, not entire display */
 	par->fbtftops.mkdirty(info, -1, 0);
 }
 
Signature · 1 line
2.43.0
#3 lore raw

PATCH v2 1/1 staging: fbtft: clarify TODO comment in fbtft-core

In reply to Andy Shevchenko

Improve wording of a TODO comment to better describe the intended optimization. The comment now clearly states that only the changed display area should be updated instead of refreshing the entire screen.

---
 drivers/staging/fbtft/fbtft-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fbtft-core.c +1 -1
index f427c0914..cff838955 100644
@@ -414,7 +414,7 @@ static void fbtft_ops_damage_range(struct fb_info *info, off_t off, size_t len)
 {
 	struct fbtft_par *par = info->par;
 
-	/* TODO: only mark changed area update all for now */
+	/* TODO: update only changed area, not entire display */
 	par->fbtftops.mkdirty(info, -1, 0);
 }
 
Signature · 1 line
2.43.0
maintainer
#4 lore raw
Quoted 27 lines · Sachin Kumar

Improve wording of a TODO comment to better describe the intended optimization. The comment now clearly states that only the changed display area should be updated instead of refreshing the entire screen.

---
 drivers/staging/fbtft/fbtft-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fbtft-core.c +1 -1
index f427c0914..cff838955 100644
@@ -414,7 +414,7 @@ static void fbtft_ops_damage_range(struct fb_info *info, off_t off, size_t len)
 {
 	struct fbtft_par *par = info->par;
 
-	/* TODO: only mark changed area update all for now */
+	/* TODO: update only changed area, not entire display */
 	par->fbtftops.mkdirty(info, -1, 0);
 }
 
Signature · 1 line
2.43.0

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- This looks like a new version of a previously submitted patch, but you did not list below the --- line any changes from the previous version. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/process/submitting-patches.rst for what needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

#5 lore raw

PATCH v3 1/1 staging: fbtft: clarify TODO comment in fbtft-core

In reply to Andy Shevchenko

Improve wording of a TODO comment to better describe the intended optimization. The comment now clearly states that only the changed display area should be updated instead of refreshing the entire screen.

---
v3:
- add missing changelog for previous version
- simplify TODO comment to match kernel style

 drivers/staging/fbtft/fbtft-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fbtft-core.c +1 -1
index f427c0914..cff838955 100644
@@ -414,7 +414,7 @@ static void fbtft_ops_damage_range(struct fb_info *info, off_t off, size_t len)
 {
 	struct fbtft_par *par = info->par;
 
-	/* TODO: only mark changed area update all for now */
+	/* TODO: update only changed area, not entire display */
 	par->fbtftops.mkdirty(info, -1, 0);
 }
 
Signature · 1 line
2.43.0
maintainer
#6 lore raw
Quoted 30 lines · Sachin Kumar

Improve wording of a TODO comment to better describe the intended optimization. The comment now clearly states that only the changed display area should be updated instead of refreshing the entire screen.

---
v3:
- add missing changelog for previous version
- simplify TODO comment to match kernel style

 drivers/staging/fbtft/fbtft-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fbtft-core.c +1 -1
index f427c0914..cff838955 100644
@@ -414,7 +414,7 @@ static void fbtft_ops_damage_range(struct fb_info *info, off_t off, size_t len)
 {
 	struct fbtft_par *par = info->par;
 
-	/* TODO: only mark changed area update all for now */
+	/* TODO: update only changed area, not entire display */
 	par->fbtftops.mkdirty(info, -1, 0);
 }
 
Signature · 1 line
2.43.0

Does not apply to the tree anymore :(