Skip to contentSkip to conversation

tpm: eventlog: remove unused structs tcg_algorithm_{size,info}

PATCH In review Thorsten Blum 2 participants 2 messages Apr 17 – Apr 19

Subsystems (2)
Keys-trusted TPM device driver
lore
Share & tools
lore

Thorsten Blum

author
#0 lore raw

PATCH 1/1 tpm: eventlog: remove unused structs tcg_algorithm_{size,info}

Remove the unused structs tcg_algorithm_size and tcg_algorithm_info.

Signed-off-by Thorsten Blum <[email protected]>
---
 include/linux/tpm_eventlog.h | 16 ----------------
 1 file changed, 16 deletions(-)
include/linux/tpm_eventlog.h +0 -16
index aff8ea2fa98e..615bd0af5173 100644
@@ -114,22 +114,6 @@ struct tcg_pcr_event2_head {
 	struct tpm_digest digests[];
 } __packed;
 
-struct tcg_algorithm_size {
-	u16 algorithm_id;
-	u16 algorithm_size;
-};
-
-struct tcg_algorithm_info {
-	u8 signature[16];
-	u32 platform_class;
-	u8 spec_version_minor;
-	u8 spec_version_major;
-	u8 spec_errata;
-	u8 uintn_size;
-	u32 number_of_algorithms;
-	struct tcg_algorithm_size digest_sizes[];
-};
-
 #ifndef TPM_MEMREMAP
 static inline void *TPM_MEMREMAP(unsigned long start, size_t size)
 {
maintainer
#1 lore raw
Quoted 24 lines · Thorsten Blum

Remove the unused structs tcg_algorithm_size and tcg_algorithm_info.

Signed-off-by Thorsten Blum <[email protected]>
---
 include/linux/tpm_eventlog.h | 16 ----------------
 1 file changed, 16 deletions(-)
include/linux/tpm_eventlog.h +0 -9
index aff8ea2fa98e..615bd0af5173 100644
@@ -114,22 +114,6 @@ struct tcg_pcr_event2_head {
 	struct tpm_digest digests[];
 } __packed;
 
-struct tcg_algorithm_size {
-	u16 algorithm_id;
-	u16 algorithm_size;
-};
-
-struct tcg_algorithm_info {
-	u8 signature[16];
-	u32 platform_class;
-	u8 spec_version_minor;

include/linux/tpm_eventlog.h struct tcg_pcr_event2_head { · line 119

Quoted 10 lines
include/linux/tpm_eventlog.h +0 -7
-	u8 spec_version_major;
-	u8 spec_errata;
-	u8 uintn_size;
-	u32 number_of_algorithms;
-	struct tcg_algorithm_size digest_sizes[];
-};
-
 #ifndef TPM_MEMREMAP
 static inline void *TPM_MEMREMAP(unsigned long start, size_t size)
 {

NAK. If you are doing something useful here then it is fine.

The only feature that pure cleanup patches cause are potential merge conflicts when backporting actual bug fixes.

BR, Jarkko