Skip to contentSkip to conversation

arm: dts: fsl-ls1088a-qds: Fix missed -u-boot.dtsi

PATCH In review Ye Li 2 participants 4 messages Apr 17 – Apr 20 Arm (32-bit)

lore
Share & tools
lore

Ye Li

author
#0 lore raw

PATCH 1/4 arm: dts: fsl-ls1088a-qds: Fix missed -u-boot.dtsi

LS1088AQDS u-boot contains multiple DTB files:
fsl-ls1088a-qds-21-x.dtb and fsl-ls1088a-qds-29-x.dtb. It does not use default device tree fsl-ls1088a-qds.dtb

However, the nodes updated in fsl-ls1088a-qds-u-boot.dtsi are not included for fsl-ls1088a-qds-21-x.dts and fsl-ls1088a-qds-29-x.dts, so fail to get any output from serial.

---
 arch/arm/dts/fsl-ls1088a-qds-21-x-u-boot.dtsi | 9 +++++++++
 arch/arm/dts/fsl-ls1088a-qds-29-x-u-boot.dtsi | 9 +++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 arch/arm/dts/fsl-ls1088a-qds-21-x-u-boot.dtsi
 create mode 100644 arch/arm/dts/fsl-ls1088a-qds-29-x-u-boot.dtsi
arch/arm/dts/fsl-ls1088a-qds-21-x-u-boot.dtsi new file +9 -0
new file mode 100644
index 00000000000..1d58f1c593b
@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2024 NXP
+ *
+ */
+
+#include <config.h>
+
+#include "fsl-ls1088a-qds-u-boot.dtsi"
arch/arm/dts/fsl-ls1088a-qds-29-x-u-boot.dtsi new file +9 -0
new file mode 100644
index 00000000000..1d58f1c593b
@@ -0,0 +1,9 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2024 NXP
+ *
+ */
+
+#include <config.h>
+
+#include "fsl-ls1088a-qds-u-boot.dtsi"
Signature · 1 line
2.37.1
author
#1 lore raw

PATCH 2/4 arm: dts: fsl-ls1088a: Set dpmac nodes default to disabled

Disable ethernet controller dpmac nodes in fsl-ls1088a.dtsi. Board dts is responsible to enable them. Otherwise will meet failure from ldpaa_eth driver on LS1088AQDS board, because only few dpmac controllers can be enabled on this board.

---
 arch/arm/dts/fsl-ls1088a.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/dts/fsl-ls1088a.dtsi +10 -0
index e5fb137ac02..9a62f148d8e 100644
@@ -978,51 +978,61 @@
 				dpmac1: ethernet@1 {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <1>;
+					status = "disabled";
 				};
 
 				dpmac2: ethernet@2 {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <2>;
+					status = "disabled";
 				};
 
 				dpmac3: ethernet@3 {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <3>;
+					status = "disabled";
 				};
 
 				dpmac4: ethernet@4 {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <4>;
+					status = "disabled";
 				};
 
 				dpmac5: ethernet@5 {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <5>;
+					status = "disabled";
 				};
 
 				dpmac6: ethernet@6 {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <6>;
+					status = "disabled";
 				};
 
 				dpmac7: ethernet@7 {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <7>;
+					status = "disabled";
 				};
 
 				dpmac8: ethernet@8 {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <8>;
+					status = "disabled";
 				};
 
 				dpmac9: ethernet@9 {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <9>;
+					status = "disabled";
 				};
 
 				dpmac10: ethernet@a {
 					compatible = "fsl,qoriq-mc-dpmac";
 					reg = <0xa>;
+					status = "disabled";
 				};
 			};
 		};
Signature · 1 line
2.37.1
Reviewed-by on v1 2/4
#2 lore raw

Re: [PATCH 2/4] arm: dts: fsl-ls1088a: Set dpmac nodes default to disabled

Quoted 7 lines · Ye Li

Disable ethernet controller dpmac nodes in fsl-ls1088a.dtsi. Board dts is responsible to enable them. Otherwise will meet failure from ldpaa_eth driver on LS1088AQDS board, because only few dpmac controllers can be enabled on this board.

A better place to do this change would be x-u-boot.dtsi, but since this board is still not using OF_UPSTREAM, it is fine for now.

Reviewed-by on v1 1/4
#3 lore raw
In reply to Ye Li
Quoted 10 lines · Ye Li

LS1088AQDS u-boot contains multiple DTB files:
fsl-ls1088a-qds-21-x.dtb and fsl-ls1088a-qds-29-x.dtb. It does not use default device tree fsl-ls1088a-qds.dtb

However, the nodes updated in fsl-ls1088a-qds-u-boot.dtsi are not included for fsl-ls1088a-qds-21-x.dts and fsl-ls1088a-qds-29-x.dts, so fail to get any output from serial.