Skip to contentSkip to conversation

xfs/653: require realtime

PATCH In review Andrey Albershteyn 3 participants 3 messages Apr 17 – Apr 22

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/653: require realtime

This test fails to mount without CONFIG_XFS_RT.

---
 tests/xfs/653 | 1 +
 1 file changed, 1 insertion(+)
tests/xfs/653 +1 -0
index 12d606c436f0..bba59cc36626 100755
@@ -24,6 +24,7 @@ _cleanup()
 
 _require_test
 _require_loop
+_require_realtime
 _require_xfs_io_command "truncate"
 
 fsbsize=4096
Signature · 1 line
2.51.2
#1 lore raw
Quoted 1 line · Andrey Albershteyn

This test fails to mount without CONFIG_XFS_RT.

It would also fail without zone device support, and the || _notrun should handle that. I guess it doesn't for you?

#2 lore raw
Quoted 4 lines · Christoph Hellwig
Quoted 1 line · Andrey Albershteyn

This test fails to mount without CONFIG_XFS_RT.

It would also fail without zone device support

The CONFIG_BLK_DEV_ZONED? Seems to pass if XFS_RT=y

Quoted 2 lines

, and the || _notrun
should handle that. I guess it doesn't for you?

I suppose mkfs.xfs is fine with formatting the device even when XFS_RT=n, but mount then fails, so _notrun doesn't catch it.

Signature · 26 lines
- Andrey

-- 

[root@kd:~]# mkfs.xfs -b size=4k -r zoned=1,size=2040928b -f /dev/vdb
meta-data=/dev/vdb               isize=512    agcount=4, agsize=32768 blks
         =                       sectsz=512   attr=2, projid32bit=1
         =                       crc=1        finobt=1, sparse=1, rmapbt=1
         =                       reflink=0    bigtime=1 inobtcount=1 nrext64=1
         =                       exchange=1   metadir=1
data     =                       bsize=4096   blocks=131072, imaxpct=25
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0, ftype=1, parent=1
log      =internal log           bsize=4096   blocks=16384, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =internal               extsz=4096   blocks=2359296, rtextents=2359296
         =                       rgcount=36   rgsize=65536 extents
         =                       zoned=1      start=131072 reserved=56224
Discarding blocks...Done.

[root@kd:~]# mount /dev/vdb /mnt/scratch
XFS (vdb): EXPERIMENTAL zoned RT device feature enabled.  Use at your own risk!
XFS (vdb): Not built with CONFIG_XFS_RT
XFS (vdb): RT mount failed
mount: /mnt/scratch: fsconfig() failed: Function not implemented.
       dmesg(1) may have more information after failed mount system call.