drm/amd/display: Undo accidental fix revert in amdgpu_dm_ism.c
Subsystems (3)
[email protected]
maintainerPATCH 1/1 drm/amd/display: Undo accidental fix revert in amdgpu_dm_ism.c
From: Leo Li <[email protected]>
[Why]
Pausing DPM power profiles during static screen caused a bunch of audio/performance/clock issues that were addressed in this fix:1412482b7143 ("Revert "drm/amd/display: pause the workload setting in dm"")
This logic in function amdgpu_dm_crtc_vblank_control_worker() was moved to amdgpu_dm_ism.c, but the fix was lost in the process.
[How]
Reapply the fix to amdgpu_dm_ism.c
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c | 10 ---------- 1 file changed, 10 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c +0 -10
@@ -270,7 +270,6 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,struct amdgpu_crtc *acrtc =ism_to_amdgpu_crtc (ism);struct amdgpu_device *adev =drm_to_adev (acrtc->base.dev);struct amdgpu_display_manager *dm = &adev->dm; -int r; trace_amdgpu_dm_ism_commit(dm->active_vblank_irq_count, vblank_enabled,
@@ -315,16 +314,7 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,*/ if (!vblank_enabled && dm->active_vblank_irq_count ==0 ) {dc_post_update_surfaces_to_stream (dm->dc); - - r =amdgpu_dpm_pause_power_profile (adev, true); -if (r) -dev_warn (adev->dev,"failed to set default power profile mode\n" ); -dc_allow_idle_optimizations (dm->dc, true); - - r =amdgpu_dpm_pause_power_profile (adev, false); -if (r) -dev_warn (adev->dev,"failed to restore the power profile mode\n" ); } }
Signature · 1 line
2.53.0
Quoted 11 lines · On 4/17/26 12:54, [email protected] wrote:
From: Leo Li <[email protected]>
[Why]
Pausing DPM power profiles during static screen caused a bunch of audio/performance/clock issues that were addressed in this fix:
1412482b7143("Revert "drm/amd/display: pause the workload setting in dm"")This logic in function
amdgpu_dm_crtc_vblank_control_worker()was moved toamdgpu_dm_ism.c, but the fix was lost in the process.
Quoted 6 lines
[How]
Reapply the fix to
amdgpu_dm_ism.cFixes 0b572a6bf04a ("drm/amd/display: Add Idle state manager(ISM)")Signed-off-by Leo Li <[email protected]>
Oh joy. Well glad it's caught early in the kernel cycle. Pretty much identical revert to 1412482b714358ffa30d38fd3dd0b05795163648.
Quoted 33 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c +0
-10@@ -270,7 +270,6 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,struct amdgpu_crtc *acrtc =ism_to_amdgpu_crtc (ism);struct amdgpu_device *adev =drm_to_adev (acrtc->base.dev);struct amdgpu_display_manager *dm = &adev->dm; -int r; trace_amdgpu_dm_ism_commit(dm->active_vblank_irq_count, vblank_enabled,@@ -315,16 +314,7 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,*/ if (!vblank_enabled && dm->active_vblank_irq_count ==0 ) {dc_post_update_surfaces_to_stream (dm->dc); - - r =amdgpu_dpm_pause_power_profile (adev, true); -if (r) -dev_warn (adev->dev,"failed to set default power profile mode\n" ); -dc_allow_idle_optimizations (dm->dc, true); - - r =amdgpu_dpm_pause_power_profile (adev, false); -if (r) -dev_warn (adev->dev,"failed to restore the power profile mode\n" ); } }
Quoted 11 lines · On Fri, Apr 17, 2026 at 2:14 PM <[email protected]> wrote:
From: Leo Li <[email protected]>
[Why]
Pausing DPM power profiles during static screen caused a bunch of audio/performance/clock issues that were addressed in this fix:
1412482b7143("Revert "drm/amd/display: pause the workload setting in dm"")This logic in function
amdgpu_dm_crtc_vblank_control_worker()was moved toamdgpu_dm_ism.c, but the fix was lost in the process.
Do you think ISM will fix this so we can re-enable pausing the power profile?
Quoted 43 lines
[How]
Reapply the fix to
amdgpu_dm_ism.cFixes 0b572a6bf04a ("drm/amd/display: Add Idle state manager(ISM)")Signed-off-by Leo Li <[email protected]>--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c +0
-11@@ -270,7 +270,6 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,struct amdgpu_crtc *acrtc =ism_to_amdgpu_crtc (ism);struct amdgpu_device *adev =drm_to_adev (acrtc->base.dev);struct amdgpu_display_manager *dm = &adev->dm; -int r; trace_amdgpu_dm_ism_commit(dm->active_vblank_irq_count, vblank_enabled,@@ -315,16 +314,7 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,*/ if (!vblank_enabled && dm->active_vblank_irq_count ==0 ) {dc_post_update_surfaces_to_stream (dm->dc); - - r =amdgpu_dpm_pause_power_profile (adev, true); -if (r) -dev_warn (adev->dev,"failed to set default power profile mode\n" ); -dc_allow_idle_optimizations (dm->dc, true); - - r =amdgpu_dpm_pause_power_profile (adev, false); -if (r) -dev_warn (adev->dev,"failed to restore the power profile mode\n" ); } } --2.53.0
Leo Li
maintainerQuoted 10 lines · Alex Deucher
Quoted 9 lines · On Fri, Apr 17, 2026 at 2:14 PM <[email protected]> wrote:
From: Leo Li <[email protected]>
[Why]
Pausing DPM power profiles during static screen caused a bunch of audio/performance/clock issues that were addressed in this fix:
1412482b7143("Revert "drm/amd/display: pause the workload setting in dm"")
Quoted 6 lines
Quoted 2 lines
This logic in function
amdgpu_dm_crtc_vblank_control_worker()was moved toamdgpu_dm_ism.c, but the fix was lost in the process.Do you think ISM will fix this so we can re-enable pausing the power profile?
Reviewed-by Alex Deucher <[email protected]>
This regression was caught in our testing this week, so I don't think so.
The ISM doesn't differ from the original vblank on/off logic much. Instead of idle features relying on the drm vblank off timer + a dm-specific worker, we moved it to a dm-specific delayed worker + hysteresis to prevent idle state thrashing.
I guess the question is: what exactly is amdgpu_dpm_pause_power_profile() doing? Does it enter some low power-state? If so, what are the needed conditions for entry and exit?
Thanks,
Leo
Quoted 44 lines
Quoted 44 lines
[How]
Reapply the fix to
amdgpu_dm_ism.cFixes 0b572a6bf04a ("drm/amd/display: Add Idle state manager(ISM)")Signed-off-by Leo Li <[email protected]>--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c +0
-11@@ -270,7 +270,6 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,struct amdgpu_crtc *acrtc =ism_to_amdgpu_crtc (ism);struct amdgpu_device *adev =drm_to_adev (acrtc->base.dev);struct amdgpu_display_manager *dm = &adev->dm; -int r; trace_amdgpu_dm_ism_commit(dm->active_vblank_irq_count, vblank_enabled,@@ -315,16 +314,7 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,*/ if (!vblank_enabled && dm->active_vblank_irq_count ==0 ) {dc_post_update_surfaces_to_stream (dm->dc); - - r =amdgpu_dpm_pause_power_profile (adev, true); -if (r) -dev_warn (adev->dev,"failed to set default power profile mode\n" ); -dc_allow_idle_optimizations (dm->dc, true); - - r =amdgpu_dpm_pause_power_profile (adev, false); -if (r) -dev_warn (adev->dev,"failed to restore the power profile mode\n" ); } } --2.53.0
Quoted 23 lines · Leo Li
Quoted 10 lines · Alex Deucher
Quoted 9 lines · On Fri, Apr 17, 2026 at 2:14 PM <[email protected]> wrote:
From: Leo Li <[email protected]>
[Why]
Pausing DPM power profiles during static screen caused a bunch of audio/performance/clock issues that were addressed in this fix:
1412482b7143("Revert "drm/amd/display: pause the workload setting in dm"")Quoted 6 lines
Quoted 2 lines
This logic in function
amdgpu_dm_crtc_vblank_control_worker()was moved toamdgpu_dm_ism.c, but the fix was lost in the process.Do you think ISM will fix this so we can re-enable pausing the power profile?
Reviewed-by Alex Deucher <[email protected]>This regression was caught in our testing this week, so I don't think so.
Quoted 8 lines
The ISM doesn't differ from the original vblank on/off logic much. Instead of idle features relying on the drm vblank off timer + a dm-specific worker, we moved it to a dm-specific delayed worker + hysteresis to prevent idle state thrashing.
I guess the question is: what exactly is
amdgpu_dpm_pause_power_profile()doing? Does it enter some low power-state? If so, what are the needed conditions for entry and exit?
All it does is set the power profile back to the default/bootup profile. If there were workloads running the profile may be set to video, fullscreen3d, or compute. My understanding is that the DC low power stuff gets ignored if the profile is not in the bootup state when DC enters it's low power mode. To fix that, we called this helper to force the profile back to default/bootup do DC low power features will kick in.
Alex
Quoted 49 lines
Thanks,
LeoQuoted 44 lines
Quoted 44 lines
[How]
Reapply the fix to
amdgpu_dm_ism.cFixes 0b572a6bf04a ("drm/amd/display: Add Idle state manager(ISM)")Signed-off-by Leo Li <[email protected]>--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c +0
-11@@ -270,7 +270,6 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,struct amdgpu_crtc *acrtc =ism_to_amdgpu_crtc (ism);struct amdgpu_device *adev =drm_to_adev (acrtc->base.dev);struct amdgpu_display_manager *dm = &adev->dm; -int r; trace_amdgpu_dm_ism_commit(dm->active_vblank_irq_count, vblank_enabled,@@ -315,16 +314,7 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,*/ if (!vblank_enabled && dm->active_vblank_irq_count ==0 ) {dc_post_update_surfaces_to_stream (dm->dc); - - r =amdgpu_dpm_pause_power_profile (adev, true); -if (r) -dev_warn (adev->dev,"failed to set default power profile mode\n" ); -dc_allow_idle_optimizations (dm->dc, true); - - r =amdgpu_dpm_pause_power_profile (adev, false); -if (r) -dev_warn (adev->dev,"failed to restore the power profile mode\n" ); } } --2.53.0